You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by "TeslaCN (via GitHub)" <gi...@apache.org> on 2023/06/29 08:06:37 UTC

[GitHub] [shardingsphere] TeslaCN commented on a diff in pull request #26686: Fix values statement ClassCastException

TeslaCN commented on code in PR #26686:
URL: https://github.com/apache/shardingsphere/pull/26686#discussion_r1246273958


##########
parser/sql/dialect/mysql/src/main/antlr4/imports/mysql/DMLStatement.g4:
##########
@@ -231,7 +231,7 @@ tableStatement
     ;
 
 tableValueConstructor
-    : VALUES rowConstructorList
+    : VALUES rowConstructorList orderByClause? limitClause?

Review Comment:
   MySQL may not implement the "VALUES" statement in this way.
   https://github.com/mysql/mysql-server/blob/1bfe02bdad6604d54913c62614bde57a055c8332/sql/sql_yacc.yy#L10051-L10056



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org