You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/01/06 12:53:09 UTC
[GitHub] spark pull request #20175: [HOTFIX] Fix style checking failure
GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/20175
[HOTFIX] Fix style checking failure
## What changes were proposed in this pull request?
This PR is to fix the style checking failure.
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark stylefix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20175.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20175
----
commit 6b4ddcc4a1ba2c36475f8b1fa281c434a1138002
Author: gatorsmile <ga...@...>
Date: 2018-01-06T12:52:03Z
fix
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20175: [HOTFIX] Fix style checking failure
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20175
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20175: [HOTFIX] Fix style checking failure
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20175
**[Test build #85755 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85755/testReport)** for PR 20175 at commit [`6b4ddcc`](https://github.com/apache/spark/commit/6b4ddcc4a1ba2c36475f8b1fa281c434a1138002).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20175: [HOTFIX] Fix style checking failure
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on the issue:
https://github.com/apache/spark/pull/20175
@gatorsmile . Could you check Java style, too?
```
$ dev/lint-java
Using `mvn` from path: /usr/local/maven-3.5.2/bin/mvn
Checkstyle checks failed at following occurrences:
[ERROR] src/main/java/org/apache/spark/launcher/InProcessAppHandle.java:[20,8] (imports) UnusedImports: Unused import - java.io.IOException.
[ERROR] src/test/java/test/org/apache/spark/sql/JavaDataFrameSuite.java:[464] (sizes) LineLength: Line is longer than 100 characters (found 102).
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20175: [HOTFIX] Fix style checking failure
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20175
Thanks! Merged to master/2.3
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20175: [HOTFIX] Fix style checking failure
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/20175
@dongjoon-hyun The JAVA style check is disabled.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20175: [HOTFIX] Fix style checking failure
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20175
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85755/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20175: [HOTFIX] Fix style checking failure
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20175
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20175: [HOTFIX] Fix style checking failure
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20175
**[Test build #85755 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85755/testReport)** for PR 20175 at commit [`6b4ddcc`](https://github.com/apache/spark/commit/6b4ddcc4a1ba2c36475f8b1fa281c434a1138002).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org