You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/21 07:06:35 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #5482: ui: List Identity providers as domain admin
Pearl1594 opened a new pull request #5482:
URL: https://github.com/apache/cloudstack/pull/5482
### Description
This PR fixes: https://github.com/apache/cloudstack/issues/5477 wherein domain admins aren't allowed to list available IDPs.
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5482: ui: List Identity providers as domain admin
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5482:
URL: https://github.com/apache/cloudstack/pull/5482#issuecomment-923709085
Closing this as it can be handled as part of https://github.com/apache/cloudstack/pull/5481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 closed pull request #5482: ui: List Identity providers as domain admin
Posted by GitBox <gi...@apache.org>.
Pearl1594 closed pull request #5482:
URL: https://github.com/apache/cloudstack/pull/5482
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5482: ui: List Identity providers as domain admin
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5482:
URL: https://github.com/apache/cloudstack/pull/5482#issuecomment-923702818
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5482: ui: List Identity providers as domain admin
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5482:
URL: https://github.com/apache/cloudstack/pull/5482#issuecomment-923714005
The `listIdps` API doesn't actually have any authorization restriction based on user roles. However, it isn't part of the API list for roles other than root admin. Legacy UI, didn't enforce this check either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on a change in pull request #5482: ui: List Identity providers as domain admin
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #5482:
URL: https://github.com/apache/cloudstack/pull/5482#discussion_r712765308
##########
File path: ui/src/views/iam/AddAccount.vue
##########
@@ -222,9 +222,7 @@ export default {
this.fetchDomains()
this.fetchRoles()
this.fetchTimeZone()
- if ('listIdps' in this.$store.getters.apis) {
- this.fetchIdps()
- }
+ this.fetchIdps()
Review comment:
Shouldn't we check that, otherwise it could fail @Pearl1594 cc @shwstppr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org