You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2017/11/02 13:01:39 UTC

[GitHub] carbondata pull request #1386: [CARBONDATA-1513] bad-record for complex data...

Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1386#discussion_r148524506
  
    --- Diff: processing/src/main/java/org/apache/carbondata/processing/datatypes/ArrayDataType.java ---
    @@ -131,6 +131,10 @@ public void getAllPrimitiveChildren(List<GenericDataType> primitiveChild) {
         }
       }
     
    +  public GenericDataType getChildren() {
    --- End diff --
    
    It is better to add it in `GenericDataType` and override it here


---