You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Anders Hammar (JIRA)" <ji...@codehaus.org> on 2010/12/23 10:13:58 UTC

[jira] Created: (SUREFIRE-675) perCoreThreadCount param should be boolean

perCoreThreadCount param should be boolean
------------------------------------------

                 Key: SUREFIRE-675
                 URL: http://jira.codehaus.org/browse/SUREFIRE-675
             Project: Maven Surefire
          Issue Type: Improvement
          Components: Maven Failsafe Plugin, Maven Surefire Plugin
    Affects Versions: 2.7.1
         Environment: n/a
            Reporter: Anders Hammar
            Priority: Minor


The perCoreThreadCount param of the plugins is defined as a String, but used as a boolean. It should then be declared as a boolean.
Also, the default value should be defined through annotations so that it is included in documentation and help.

I'll see if I can provide a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SUREFIRE-675) perCoreThreadCount/useUnlimitedThreads param should be boolean

Posted by "Kristian Rosenvold (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Rosenvold updated SUREFIRE-675:
----------------------------------------

    Summary: perCoreThreadCount/useUnlimitedThreads param should be boolean  (was: perCoreThreadCount param should be boolean)

> perCoreThreadCount/useUnlimitedThreads param should be boolean
> --------------------------------------------------------------
>
>                 Key: SUREFIRE-675
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-675
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Maven Failsafe Plugin, Maven Surefire Plugin
>    Affects Versions: 2.7.1
>         Environment: n/a
>            Reporter: Anders Hammar
>            Priority: Minor
>         Attachments: surefire-SUREFIRE-675.patch
>
>
> The perCoreThreadCount param of the plugins is defined as a String, but used as a boolean. It should then be declared as a boolean.
> Also, the default value should be defined through annotations so that it is included in documentation and help.
> I'll see if I can provide a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SUREFIRE-675) perCoreThreadCount param should be boolean

Posted by "Anders Hammar (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SUREFIRE-675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=249525#action_249525 ] 

Anders Hammar commented on SUREFIRE-675:
----------------------------------------

The same is applicable for the useUnlimitedThreads param.
Please update summary!

> perCoreThreadCount param should be boolean
> ------------------------------------------
>
>                 Key: SUREFIRE-675
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-675
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Maven Failsafe Plugin, Maven Surefire Plugin
>    Affects Versions: 2.7.1
>         Environment: n/a
>            Reporter: Anders Hammar
>            Priority: Minor
>
> The perCoreThreadCount param of the plugins is defined as a String, but used as a boolean. It should then be declared as a boolean.
> Also, the default value should be defined through annotations so that it is included in documentation and help.
> I'll see if I can provide a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SUREFIRE-675) perCoreThreadCount param should be boolean

Posted by "Anders Hammar (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anders Hammar updated SUREFIRE-675:
-----------------------------------

    Attachment: surefire-SUREFIRE-675.patch

Attached patch. The changes spans over many of the surefire projects, so the patch file's base is the top surefire project.

> perCoreThreadCount param should be boolean
> ------------------------------------------
>
>                 Key: SUREFIRE-675
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-675
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Maven Failsafe Plugin, Maven Surefire Plugin
>    Affects Versions: 2.7.1
>         Environment: n/a
>            Reporter: Anders Hammar
>            Priority: Minor
>         Attachments: surefire-SUREFIRE-675.patch
>
>
> The perCoreThreadCount param of the plugins is defined as a String, but used as a boolean. It should then be declared as a boolean.
> Also, the default value should be defined through annotations so that it is included in documentation and help.
> I'll see if I can provide a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (SUREFIRE-675) perCoreThreadCount/useUnlimitedThreads param should be boolean

Posted by "Kristian Rosenvold (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SUREFIRE-675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kristian Rosenvold closed SUREFIRE-675.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.7.2
         Assignee: Kristian Rosenvold

Fixed in r1053566, thanks for the patch !

> perCoreThreadCount/useUnlimitedThreads param should be boolean
> --------------------------------------------------------------
>
>                 Key: SUREFIRE-675
>                 URL: http://jira.codehaus.org/browse/SUREFIRE-675
>             Project: Maven Surefire
>          Issue Type: Improvement
>          Components: Maven Failsafe Plugin, Maven Surefire Plugin
>    Affects Versions: 2.7.1
>         Environment: n/a
>            Reporter: Anders Hammar
>            Assignee: Kristian Rosenvold
>            Priority: Minor
>             Fix For: 2.7.2
>
>         Attachments: surefire-SUREFIRE-675.patch
>
>
> The perCoreThreadCount param of the plugins is defined as a String, but used as a boolean. It should then be declared as a boolean.
> Also, the default value should be defined through annotations so that it is included in documentation and help.
> I'll see if I can provide a patch.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira