[jira] [Commented] (MPMD-369) System encoding conflicts with XML encoding in CpdViolationCheckMojo

["Michael Osipov (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MPMD-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708943#comment-17708943 ] 

Michael Osipov commented on MPMD-369:
-------------------------------------

Beat me, but I have the feeling that I have seen this somewhere before.

> System encoding conflicts with XML encoding in CpdViolationCheckMojo
> --------------------------------------------------------------------
>
>                 Key: MPMD-369
>                 URL: https://issues.apache.org/jira/browse/MPMD-369
>             Project: Maven PMD Plugin
>          Issue Type: Bug
>            Reporter: Elliotte Rusty Harold
>            Priority: Major
>
> ```
>     @Override
>     protected List<Duplication> getErrorDetails( File cpdFile )
>         throws XmlPullParserException, IOException
>     {
>         try ( FileReader fileReader = new FileReader( cpdFile ) )
>         {
>             CpdXpp3Reader reader = new CpdXpp3Reader();
>             CpdErrorDetail details = reader.read( fileReader, false );
>             return details.getDuplications();
>         }
>     }
> ```
> It passes or fails depending on the system encoding. Instead it should use an inputstream rather than a reader and rely on the XML parser to detect the encoding. This breaks integration tests on some but not all platforms, again depending on whether the system encoding is or is not compatible with ISO-8859-1



--
This message was sent by Atlassian Jira
(v8.20.10#820010)