You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/02/18 19:21:51 UTC

[GitHub] [incubator-superset] serenajiang commented on a change in pull request #9146: [dashboard] clean up usage for old filter immune metadata

serenajiang commented on a change in pull request #9146: [dashboard] clean up usage for old filter immune metadata
URL: https://github.com/apache/incubator-superset/pull/9146#discussion_r380882694
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -1263,16 +1263,8 @@ def _set_dash_metadata(dashboard, data):
 
         if "timed_refresh_immune_slices" not in md:
             md["timed_refresh_immune_slices"] = []
-
         if "filter_scopes" in data:
-            md.pop("filter_immune_slices", None)
-            md.pop("filter_immune_slice_fields", None)
             md["filter_scopes"] = json.loads(data.get("filter_scopes", "{}"))
 
 Review comment:
   ```suggestion
               md["filter_scopes"] = json.loads(data["filter_scopes"])
   ```
   not yours, but might as well clean this up

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org