You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/08/20 18:25:35 UTC
[GitHub] [pulsar] bharanic-dev opened a new pull request #11732: [ PIP-82] [pulsar-broker] Fix a couple of issues
bharanic-dev opened a new pull request #11732:
URL: https://github.com/apache/pulsar/pull/11732
### Modifications
- Handle ChildrenChanged metadata-store event.
- Update the publish rate limiter correctly.
### Verifying this change
- [x] Make sure that the change passes the CI checks.
- [x] verified via manual testing
### Documentation
No documentation impact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] bharanic-dev commented on a change in pull request #11732: [ PIP-82] [pulsar-broker] Fix a couple of issues
Posted by GitBox <gi...@apache.org>.
bharanic-dev commented on a change in pull request #11732:
URL: https://github.com/apache/pulsar/pull/11732#discussion_r694373441
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupPublishLimiter.java
##########
@@ -160,12 +168,22 @@ private void replaceLimiters(Runnable updater) {
@Override
public void close() {
- this.apply();
- replaceLimiters(null);
+ replaceLimiters(null);
Review comment:
@cckellogg thank you. I added the comment. I also fixed the case where the callback was not getting called when ratelimiter is closed (not invoking the callback can leave the producer blocked forever). PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cckellogg commented on a change in pull request #11732: [ PIP-82] [pulsar-broker] Fix a couple of issues
Posted by GitBox <gi...@apache.org>.
cckellogg commented on a change in pull request #11732:
URL: https://github.com/apache/pulsar/pull/11732#discussion_r694208442
##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/resourcegroup/ResourceGroupPublishLimiter.java
##########
@@ -160,12 +168,22 @@ private void replaceLimiters(Runnable updater) {
@Override
public void close() {
- this.apply();
- replaceLimiters(null);
+ replaceLimiters(null);
Review comment:
Does the order of calls matter here? If so maybe add a comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] bharanic-dev commented on pull request #11732: [ PIP-82] [pulsar-broker] Fix a couple of issues
Posted by GitBox <gi...@apache.org>.
bharanic-dev commented on pull request #11732:
URL: https://github.com/apache/pulsar/pull/11732#issuecomment-902923754
@jerrypeng PTAL when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] cckellogg merged pull request #11732: [ PIP-82] [pulsar-broker] Fix a couple of issues
Posted by GitBox <gi...@apache.org>.
cckellogg merged pull request #11732:
URL: https://github.com/apache/pulsar/pull/11732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] bharanic-dev commented on pull request #11732: [ PIP-82] [pulsar-broker] Fix a couple of issues
Posted by GitBox <gi...@apache.org>.
bharanic-dev commented on pull request #11732:
URL: https://github.com/apache/pulsar/pull/11732#issuecomment-904817448
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] bharanic-dev commented on pull request #11732: [ PIP-82] [pulsar-broker] Fix a couple of issues
Posted by GitBox <gi...@apache.org>.
bharanic-dev commented on pull request #11732:
URL: https://github.com/apache/pulsar/pull/11732#issuecomment-904758026
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] bharanic-dev commented on pull request #11732: [ PIP-82] [pulsar-broker] Fix a couple of issues
Posted by GitBox <gi...@apache.org>.
bharanic-dev commented on pull request #11732:
URL: https://github.com/apache/pulsar/pull/11732#issuecomment-904846475
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ravi-vaidyanathan commented on pull request #11732: [ PIP-82] [pulsar-broker] Fix a couple of issues
Posted by GitBox <gi...@apache.org>.
ravi-vaidyanathan commented on pull request #11732:
URL: https://github.com/apache/pulsar/pull/11732#issuecomment-903942516
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org