You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/12/17 14:41:46 UTC
[GitHub] [commons-vfs] boris-petrov commented on a change in pull request #151: Refactor getOutputStream
boris-petrov commented on a change in pull request #151:
URL: https://github.com/apache/commons-vfs/pull/151#discussion_r545141302
##########
File path: commons-vfs2/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileOutputStream.java
##########
@@ -92,13 +90,7 @@ public void close() throws IOException {
if (exception != null) {
throw exception;
}
- try {
- this.closed = true;
- // Close the
- this.file.endOutput();
- } catch (final Exception e) {
- throw new FileSystemException(e);
- }
+ this.closed = true;
Review comment:
`endOutput` *will* be called because the only way to get a `RamFileOutputStream` is through `DefaultFileContent` which wraps the output stream and on close calls `endOutput`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org