You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/10/02 20:29:29 UTC
Re: Review Request 25966: Use pid namespace in
LinuxLauncher::destroy().
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/
-----------------------------------------------------------
(Updated Oct. 2, 2014, 11:29 a.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos-git
Description
-------
Check if a container is running in a pid namespace and thus all processes can be killed by the kernel, rather than using the freezer.
Diffs (updated)
-----
src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
Diff: https://reviews.apache.org/r/25966/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 25966: Use pid namespace in
LinuxLauncher::destroy().
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/#review56595
-----------------------------------------------------------
Bad patch!
Reviews applied: [25864, 25865]
Failed command: git apply --index 25865.patch
Error:
error: patch failed: src/Makefile.am:344
error: src/Makefile.am: patch does not apply
error: patch failed: src/slave/containerizer/linux_launcher.cpp:105
error: src/slave/containerizer/linux_launcher.cpp: patch does not apply
error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:40
error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply
- Mesos ReviewBot
On Oct. 14, 2014, 8:35 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25966/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2014, 8:35 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Check if a container is running in a pid namespace and thus all processes can be killed by the kernel, rather than using the freezer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
> src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
> src/tests/slave_recovery_tests.cpp 4fb357bd55f69f71193e92fd03765b808f932d33
>
> Diff: https://reviews.apache.org/r/25966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 25966: Use pid namespace in
LinuxLauncher::destroy().
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/#review58425
-----------------------------------------------------------
Bad patch!
Reviews applied: [27091, 27127, 27091]
Failed command: ./support/apply-review.sh -n -r 27091
Error:
2014-10-24 22:56:52 URL:https://reviews.apache.org/r/27091/diff/raw/ [16720/16720] -> "27091.patch" [1]
error: patch failed: src/Makefile.am:406
error: src/Makefile.am: patch does not apply
error: src/linux/ns.hpp: already exists in index
error: patch failed: src/slave/containerizer/isolators/network/port_mapping.cpp:45
error: src/slave/containerizer/isolators/network/port_mapping.cpp: patch does not apply
error: src/tests/ns_tests.cpp: already exists in index
error: src/tests/setns_test_helper.hpp: already exists in index
error: src/tests/setns_test_helper.cpp: already exists in index
Failed to apply patch
- Mesos ReviewBot
On Oct. 24, 2014, 9:53 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25966/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 9:53 p.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Check if a container is running in a pid namespace and thus all processes can be killed by the kernel, rather than using the freezer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
> src/tests/slave_recovery_tests.cpp 813e2d66f0127a84282d3b4ed0423eab36e7ef8b
>
> Diff: https://reviews.apache.org/r/25966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 25966: Use pid namespace in
LinuxLauncher::destroy().
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/#review58448
-----------------------------------------------------------
Ship it!
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/25966/#comment99465>
"registerExecutorMessage"
Ditto below.
- Ben Mahler
On Oct. 24, 2014, 9:53 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25966/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 9:53 p.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Check if a container is running in a pid namespace and thus all processes can be killed by the kernel, rather than using the freezer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
> src/tests/slave_recovery_tests.cpp 813e2d66f0127a84282d3b4ed0423eab36e7ef8b
>
> Diff: https://reviews.apache.org/r/25966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 25966: Use pid namespace in
LinuxLauncher::destroy().
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/
-----------------------------------------------------------
(Updated Oct. 24, 2014, 2:53 p.m.)
Review request for mesos, Ben Mahler and Jie Yu.
Repository: mesos-git
Description
-------
Check if a container is running in a pid namespace and thus all processes can be killed by the kernel, rather than using the freezer.
Diffs (updated)
-----
src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
src/tests/slave_recovery_tests.cpp 813e2d66f0127a84282d3b4ed0423eab36e7ef8b
Diff: https://reviews.apache.org/r/25966/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 25966: Use pid namespace in
LinuxLauncher::destroy().
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/#review58252
-----------------------------------------------------------
Bad patch!
Reviews applied: [27091, 27127, 27091]
Failed command: ./support/apply-review.sh -n -r 27091
Error:
--2014-10-24 08:00:19-- https://reviews.apache.org/r/27091/diff/raw/
Resolving reviews.apache.org (reviews.apache.org)... 140.211.11.74
Connecting to reviews.apache.org (reviews.apache.org)|140.211.11.74|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 12885 (13K) [text/x-patch]
Saving to: '27091.patch'
0K .......... .. 100% 45.3M=0s
2014-10-24 08:00:19 (45.3 MB/s) - '27091.patch' saved [12885/12885]
error: patch failed: src/Makefile.am:406
error: src/Makefile.am: patch does not apply
error: src/linux/ns.hpp: already exists in index
error: patch failed: src/slave/containerizer/isolators/network/port_mapping.cpp:45
error: src/slave/containerizer/isolators/network/port_mapping.cpp: patch does not apply
error: src/tests/ns_tests.cpp: already exists in index
Failed to apply patch
- Mesos ReviewBot
On Oct. 24, 2014, 1:28 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25966/
> -----------------------------------------------------------
>
> (Updated Oct. 24, 2014, 1:28 a.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Check if a container is running in a pid namespace and thus all processes can be killed by the kernel, rather than using the freezer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
> src/tests/slave_recovery_tests.cpp 813e2d66f0127a84282d3b4ed0423eab36e7ef8b
>
> Diff: https://reviews.apache.org/r/25966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 25966: Use pid namespace in
LinuxLauncher::destroy().
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 6:28 p.m.)
Review request for mesos, Ben Mahler and Jie Yu.
Repository: mesos-git
Description
-------
Check if a container is running in a pid namespace and thus all processes can be killed by the kernel, rather than using the freezer.
Diffs
-----
src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
src/tests/slave_recovery_tests.cpp 813e2d66f0127a84282d3b4ed0423eab36e7ef8b
Diff: https://reviews.apache.org/r/25966/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 25966: Use pid namespace in
LinuxLauncher::destroy().
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/#review58058
-----------------------------------------------------------
Bad patch!
Reviews applied: [27091, 25865]
Failed command: ./support/apply-review.sh -n -r 25865
Error:
--2014-10-23 19:14:26-- https://reviews.apache.org/r/25865/diff/raw/
Resolving reviews.apache.org (reviews.apache.org)... 140.211.11.74
Connecting to reviews.apache.org (reviews.apache.org)|140.211.11.74|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 17565 (17K) [text/x-patch]
Saving to: '25865.patch'
0K .......... ....... 100% 540K=0.03s
2014-10-23 19:14:26 (540 KB/s) - '25865.patch' saved [17565/17565]
error: patch failed: src/Makefile.am:343
error: src/Makefile.am: patch does not apply
error: patch failed: src/slave/containerizer/linux_launcher.cpp:105
error: src/slave/containerizer/linux_launcher.cpp: patch does not apply
error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:43
error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Oct. 23, 2014, 5:48 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25966/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2014, 5:48 p.m.)
>
>
> Review request for mesos, Ben Mahler and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Check if a container is running in a pid namespace and thus all processes can be killed by the kernel, rather than using the freezer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
> src/tests/slave_recovery_tests.cpp 813e2d66f0127a84282d3b4ed0423eab36e7ef8b
>
> Diff: https://reviews.apache.org/r/25966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 25966: Use pid namespace in
LinuxLauncher::destroy().
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 10:48 a.m.)
Review request for mesos, Ben Mahler and Jie Yu.
Changes
-------
Updated to use revised pid namespace killall rather than cgroups::emptied() (no longer needed)
Repository: mesos-git
Description
-------
Check if a container is running in a pid namespace and thus all processes can be killed by the kernel, rather than using the freezer.
Diffs
-----
src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
src/tests/slave_recovery_tests.cpp 813e2d66f0127a84282d3b4ed0423eab36e7ef8b
Diff: https://reviews.apache.org/r/25966/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 25966: Use pid namespace in
LinuxLauncher::destroy().
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/
-----------------------------------------------------------
(Updated Oct. 23, 2014, 10:46 a.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos-git
Description
-------
Check if a container is running in a pid namespace and thus all processes can be killed by the kernel, rather than using the freezer.
Diffs (updated)
-----
src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
src/tests/slave_recovery_tests.cpp 813e2d66f0127a84282d3b4ed0423eab36e7ef8b
Diff: https://reviews.apache.org/r/25966/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 25966: Use pid namespace in
LinuxLauncher::destroy().
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 3:37 p.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos-git
Description
-------
Check if a container is running in a pid namespace and thus all processes can be killed by the kernel, rather than using the freezer.
Diffs
-----
src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
src/tests/slave_recovery_tests.cpp 4fb357bd55f69f71193e92fd03765b808f932d33
Diff: https://reviews.apache.org/r/25966/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 25966: Use pid namespace in
LinuxLauncher::destroy().
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/#review56815
-----------------------------------------------------------
Bad patch!
Reviews applied: [25864, 25864]
Failed command: git apply --index 25864.patch
Error:
error: patch failed: src/linux/cgroups.hpp:362
error: src/linux/cgroups.hpp: patch does not apply
error: patch failed: src/linux/cgroups.cpp:1702
error: src/linux/cgroups.cpp: patch does not apply
- Mesos ReviewBot
On Oct. 15, 2014, 7:27 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25966/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2014, 7:27 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Check if a container is running in a pid namespace and thus all processes can be killed by the kernel, rather than using the freezer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
> src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
> src/tests/slave_recovery_tests.cpp 4fb357bd55f69f71193e92fd03765b808f932d33
>
> Diff: https://reviews.apache.org/r/25966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 25966: Use pid namespace in
LinuxLauncher::destroy().
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/
-----------------------------------------------------------
(Updated Oct. 15, 2014, 12:27 p.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Changes
-------
Added review dependencies
Repository: mesos-git
Description
-------
Check if a container is running in a pid namespace and thus all processes can be killed by the kernel, rather than using the freezer.
Diffs
-----
src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
src/tests/slave_recovery_tests.cpp 4fb357bd55f69f71193e92fd03765b808f932d33
Diff: https://reviews.apache.org/r/25966/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 25966: Use pid namespace in
LinuxLauncher::destroy().
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/
-----------------------------------------------------------
(Updated Oct. 14, 2014, 1:35 p.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Changes
-------
Added roll forward and roll back tests.
Repository: mesos-git
Description
-------
Check if a container is running in a pid namespace and thus all processes can be killed by the kernel, rather than using the freezer.
Diffs (updated)
-----
src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
src/slave/containerizer/mesos/containerizer.cpp 9d083294caa5c5a47ba3ceaa1b57346144cb795c
src/tests/slave_recovery_tests.cpp 4fb357bd55f69f71193e92fd03765b808f932d33
Diff: https://reviews.apache.org/r/25966/diff/
Testing
-------
Thanks,
Ian Downes
Re: Review Request 25966: Use pid namespace in
LinuxLauncher::destroy().
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25966/#review55252
-----------------------------------------------------------
Bad patch!
Reviews applied: [25864, 25865]
Failed command: git apply --index 25865.patch
Error:
error: patch failed: src/Makefile.am:339
error: src/Makefile.am: patch does not apply
error: src/slave/containerizer/isolators/filesystem/shared.cpp: does not exist in index
error: patch failed: src/slave/containerizer/linux_launcher.cpp:106
error: src/slave/containerizer/linux_launcher.cpp: patch does not apply
error: patch failed: src/slave/containerizer/mesos/containerizer.cpp:40
error: src/slave/containerizer/mesos/containerizer.cpp: patch does not apply
- Mesos ReviewBot
On Oct. 2, 2014, 6:29 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25966/
> -----------------------------------------------------------
>
> (Updated Oct. 2, 2014, 6:29 p.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Check if a container is running in a pid namespace and thus all processes can be killed by the kernel, rather than using the freezer.
>
>
> Diffs
> -----
>
> src/slave/containerizer/linux_launcher.cpp f7bc894830a7ca3f55465dacc7b653cdc2d7758b
>
> Diff: https://reviews.apache.org/r/25966/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>