You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Yingchun Lai (Code Review)" <ge...@cloudera.org> on 2023/07/19 16:56:38 UTC
[kudu-CR](branch-1.17.x) [client] KUDU-1945 Add UPSERT support
Hello Marton Greber, Alexey Serbin, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/20228
to review the following change.
Change subject: [client] KUDU-1945 Add UPSERT support
......................................................................
[client] KUDU-1945 Add UPSERT support
This patch adds UPSERT support to Kudu C++ and Java clients by removing
the previously added checks to discard UPSERT operations. The functionality
added is only supported if the entire primary key is provided including
the auto-incrementing column.
Also added verification to reject INSERT operations with
auto-incrementing column set on the client side.
Thanks to Marton Greber for diagnosing the python client side issue.
Change-Id: I27a95e3a6b1d1b584cad849978313b3c8222cd3d
Reviewed-on: http://gerrit.cloudera.org:8080/20083
Tested-by: Kudu Jenkins
Reviewed-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 39302dfa8edc1fd1268f78f3ddd3f34ca26cc43f)
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M python/kudu/tests/test_client.py
M src/kudu/client/client-test.cc
M src/kudu/client/session-internal.cc
M src/kudu/common/partial_row.cc
M src/kudu/common/partial_row.h
M src/kudu/integration-tests/auto_incrementing-itest.cc
9 files changed, 318 insertions(+), 92 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/20228/1
--
To view, visit http://gerrit.cloudera.org:8080/20228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I27a95e3a6b1d1b584cad849978313b3c8222cd3d
Gerrit-Change-Number: 20228
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR](branch-1.17.x) [client] KUDU-1945 Add UPSERT support
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has removed a vote on this change.
Change subject: [client] KUDU-1945 Add UPSERT support
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/20228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I27a95e3a6b1d1b584cad849978313b3c8222cd3d
Gerrit-Change-Number: 20228
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) [client] KUDU-1945 Add UPSERT support
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Hello Marton Greber, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20228
to look at the new patch set (#2).
Change subject: [client] KUDU-1945 Add UPSERT support
......................................................................
[client] KUDU-1945 Add UPSERT support
This patch adds UPSERT support to Kudu C++ and Java clients by removing
the previously added checks to discard UPSERT operations. The functionality
added is only supported if the entire primary key is provided including
the auto-incrementing column.
Also added verification to reject INSERT operations with
auto-incrementing column set on the client side.
Thanks to Marton Greber for diagnosing the python client side issue.
Change-Id: I27a95e3a6b1d1b584cad849978313b3c8222cd3d
Reviewed-on: http://gerrit.cloudera.org:8080/20083
Tested-by: Kudu Jenkins
Reviewed-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 39302dfa8edc1fd1268f78f3ddd3f34ca26cc43f)
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M python/kudu/tests/test_client.py
M src/kudu/client/client-test.cc
M src/kudu/client/session-internal.cc
M src/kudu/common/partial_row.cc
M src/kudu/common/partial_row.h
M src/kudu/integration-tests/auto_incrementing-itest.cc
9 files changed, 318 insertions(+), 92 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/20228/2
--
To view, visit http://gerrit.cloudera.org:8080/20228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I27a95e3a6b1d1b584cad849978313b3c8222cd3d
Gerrit-Change-Number: 20228
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
[kudu-CR](branch-1.17.x) [client] KUDU-1945 Add UPSERT support
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20228 )
Change subject: [client] KUDU-1945 Add UPSERT support
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I27a95e3a6b1d1b584cad849978313b3c8222cd3d
Gerrit-Change-Number: 20228
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 21 Jul 2023 03:58:48 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [client] KUDU-1945 Add UPSERT support
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20228 )
Change subject: [client] KUDU-1945 Add UPSERT support
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I27a95e3a6b1d1b584cad849978313b3c8222cd3d
Gerrit-Change-Number: 20228
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
Gerrit-Comment-Date: Fri, 21 Jul 2023 01:46:00 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.17.x) [client] KUDU-1945 Add UPSERT support
Posted by "Yingchun Lai (Code Review)" <ge...@cloudera.org>.
Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20228 )
Change subject: [client] KUDU-1945 Add UPSERT support
......................................................................
[client] KUDU-1945 Add UPSERT support
This patch adds UPSERT support to Kudu C++ and Java clients by removing
the previously added checks to discard UPSERT operations. The functionality
added is only supported if the entire primary key is provided including
the auto-incrementing column.
Also added verification to reject INSERT operations with
auto-incrementing column set on the client side.
Thanks to Marton Greber for diagnosing the python client side issue.
Change-Id: I27a95e3a6b1d1b584cad849978313b3c8222cd3d
Reviewed-on: http://gerrit.cloudera.org:8080/20083
Tested-by: Kudu Jenkins
Reviewed-by: Marton Greber <gr...@gmail.com>
Reviewed-by: Alexey Serbin <al...@apache.org>
(cherry picked from commit 39302dfa8edc1fd1268f78f3ddd3f34ca26cc43f)
Reviewed-on: http://gerrit.cloudera.org:8080/20228
Reviewed-by: Yifan Zhang <ch...@163.com>
Tested-by: Yingchun Lai <la...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduTable.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M python/kudu/tests/test_client.py
M src/kudu/client/client-test.cc
M src/kudu/client/session-internal.cc
M src/kudu/common/partial_row.cc
M src/kudu/common/partial_row.h
M src/kudu/integration-tests/auto_incrementing-itest.cc
9 files changed, 318 insertions(+), 92 deletions(-)
Approvals:
Marton Greber: Looks good to me, but someone else must approve
Yifan Zhang: Looks good to me, approved
Yingchun Lai: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I27a95e3a6b1d1b584cad849978313b3c8222cd3d
Gerrit-Change-Number: 20228
Gerrit-PatchSet: 3
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Yingchun Lai <la...@apache.org>
[kudu-CR](branch-1.17.x) [client] KUDU-1945 Add UPSERT support
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20228 )
Change subject: [client] KUDU-1945 Add UPSERT support
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I27a95e3a6b1d1b584cad849978313b3c8222cd3d
Gerrit-Change-Number: 20228
Gerrit-PatchSet: 2
Gerrit-Owner: Yingchun Lai <la...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Comment-Date: Thu, 20 Jul 2023 11:30:24 +0000
Gerrit-HasComments: No