You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/04 06:46:37 UTC

[GitHub] [apisix] Firstsawyou commented on a change in pull request #2941: docs: update doc of test

Firstsawyou commented on a change in pull request #2941:
URL: https://github.com/apache/apisix/pull/2941#discussion_r535872864



##########
File path: doc/how-to-build.md
##########
@@ -119,17 +119,29 @@ Makefile rules:
 ### Troubleshoot Testing
 
 **Set Nginx Path**
+
 - If you run in to an issue `Error unknown directive "lua_package_path" in /API_ASPIX/apisix/t/servroot/conf/nginx.conf`
 make sure to set openresty as default nginx. And export the path as below.
+
 * export PATH=/usr/local/openresty/nginx/sbin:$PATH
     - Linux default installation path:
         * export PATH=/usr/local/openresty/nginx/sbin:$PATH
     - OSx default installation path via homebrew:
         * export PATH=/usr/local/opt/openresty/nginx/sbin:$PATH
 
 **Run Individual Test Cases**
+
+Because the test case of `apisix` depends on the https://github.com/api7/test-toolkit test kit. Therefore, before running a single test case, you need to execute `make test` to automatically download the test kit or manually clone the `test-toolkit` to the `apisix/t/` directory:
+
+```shell
+git clone https://github.com/api7/test-toolkit/ t/toolkit

Review comment:
       What I think is necessary, before running a single test case, if we have not executed the `make test` command, then `t/toolkit` is an empty directory. Therefore, we need to explain how to download this test kit. At the same time, this is also to show that our test cases depend on the `test-toolkit` package. I will add the reason why this command `git clone https://github.com/api7/test-toolkit/t/toolkit` failed later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org