You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Volodymyr Verovkin (Code Review)" <ge...@cloudera.org> on 2020/05/02 21:31:01 UTC
[kudu-CR] [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition.
Volodymyr Verovkin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15758 )
Change subject: [partitioning] KUDU-2671 [part 1] Support for different hash partitioning per range partition.
......................................................................
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition-test.cc
File src/kudu/common/partition-test.cc:
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition-test.cc@867
PS7, Line 867: Schema schema({ ColumnSchema("k", INT32) },
> nit: add 'const' if it's not going to change in this scenario?
Done
http://gerrit.cloudera.org:8080/#/c/15758/7/src/kudu/common/partition-test.cc@877
PS7, Line 877: vector<PartitionSchema::HashBucketSchema> hash_buckets1;
: hash_buckets1.emplace_back(PartitionSchema::HashBucketSchema{{ColumnId(0)}, 2, 0});
: vector<PartitionSchema::HashBucketSchema> hash_buckets2;
: hash_buckets2.emplace_back(PartitionSchema::HashBucketSchema{{ColumnId(0)}, 3, 0});
: boost::optional<PartitionSchema::RangeHashBuckets> range_hash_buckets = {
> Could you also add a test that this works if these have more than one eleme
Done
--
To view, visit http://gerrit.cloudera.org:8080/15758
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie843f37392240c3a47a589658d9702c2049ee011
Gerrit-Change-Number: 15758
Gerrit-PatchSet: 7
Gerrit-Owner: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Volodymyr Verovkin <ve...@cloudera.com>
Gerrit-Comment-Date: Sat, 02 May 2020 21:31:01 +0000
Gerrit-HasComments: Yes