[jira] [Commented] (CASSANDRA-16378) Expose application_name and application_version in virtual table system_views.clients

["Tibor Repasi (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-16378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17485138#comment-17485138 ] 

Tibor Repasi commented on CASSANDRA-16378:
------------------------------------------

At commit [#e7ad|https://github.com/rtib/cassandra/commit/78a069a331da1b36ef1138a3b3dfc757a1a2e7ad] I've updated the according documentation page, but I'm afraid that this one will need further review, as many things have changed since this page was written and page might be moved as with 4.1 virtual tables won't be new anymore.

> Expose application_name and application_version in virtual table system_views.clients
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-16378
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16378
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Feature/Virtual Tables
>            Reporter: Tibor Repasi
>            Assignee: Tibor Repasi
>            Priority: Normal
>              Labels: AdventCalendar2021, gsoc2021, lhf, mentor
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Recent java-driver's [com.datastax.oss.driver.api.core.session.SessionBuilder|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html] respects properties [ApplicationName|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html#withApplicationName-java.lang.String-] and [ApplicationVersion|https://docs.datastax.com/en/drivers/java/4.9/com/datastax/oss/driver/api/core/session/SessionBuilder.html#withApplicationVersion-java.lang.String-].
> It would be helpful to exposed this information via virtual table {{system_views.clients}} and with {{nodetool clientstats}}.
> +Additional information for newcomers:+
> The drivers can send as part of the {{STARTUP MESSAGE}} the {{APPLICATION_NAME}} and {{APPLICATION_VERSION}} options. To new volatile fields {{applicationName}} and {{applicationVersion}} need to be added to {{ClientState}} in a similar way to {{driverName}} and {{driverVersion}}.
> The  {{APPLICATION_NAME}} and {{APPLICATION_VERSION}} optionsneed to be retrieved in {{StartupMessage#execute}} and passed to the {{ClientState}}. 
> The new {{application_name}} and {{application_version}} columns need to be added to the {{system_views.clients}} represented by the {{ClientsTable}} class. The data then need to be retrieved from the {{ClientState}} through {{ConnectedClient}}.
> Some unit tests similat to {{SettingsTableTest}} should be added. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org