You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/08/06 14:07:32 UTC
[GitHub] [openwhisk-release] rabbah commented on a change in pull request #344: document some more Release Manager assumptions
rabbah commented on a change in pull request #344:
URL: https://github.com/apache/openwhisk-release/pull/344#discussion_r466437477
##########
File path: docs/release_instructions.md
##########
@@ -19,6 +19,24 @@
# Instructions for Release Managers
+## Release Manager Initial Setup
+
+If you have never served as a Release Manager (or it has been a while
+since you have done it), first read the
+[Release Manager Setup](release_manager_setup.md) instructions.
+We have scripts that automate many of the tasks a Release Manager must
+perform, but these scripts assume you have followed the instructions
+in the Release Manager Setup before you start executing them.
+
+## Non-PMC Release Managers
+
+Actually publishing a release is an official act of the OpenWhisk
+Project Management Committee (PMC). If you an OpenWhisk Committer,
Review comment:
```suggestion
Project Management Committee (PMC). If you are an OpenWhisk Committer,
```
##########
File path: docs/release_instructions.md
##########
@@ -19,6 +19,24 @@
# Instructions for Release Managers
+## Release Manager Initial Setup
+
+If you have never served as a Release Manager (or it has been a while
+since you have done it), first read the
+[Release Manager Setup](release_manager_setup.md) instructions.
+We have scripts that automate many of the tasks a Release Manager must
+perform, but these scripts assume you have followed the instructions
+in the Release Manager Setup before you start executing them.
+
+## Non-PMC Release Managers
+
+Actually publishing a release is an official act of the OpenWhisk
+Project Management Committee (PMC). If you an OpenWhisk Committer,
+but not an OpenWhisk PMC member, you will need to pair-up with a PMC member to
+accomplish some of the steps. In brief, any step that adds or removes
+an artifact from a public distributions channel must be executed by
+an OpenWhisk PMC member.
Review comment:
```suggestion
an OpenWhisk PMC member.
```
##########
File path: docs/release_instructions.md
##########
@@ -142,8 +160,13 @@ script will run rcverify.sh against your local artifacts.
./local_verify.sh ../release-configs/<MY_RELEASE_CONFIG>.json
```
-TODO: We should also run Apache Rat as part of local_verify.sh; for now it is
-a recommended best practice to run Apache Rat by hand on each of your .tar.gz files.
+TODO: We should also run Apache Rat (https://creadur.apache.org/rat/)
+as part of local_verify.sh; for now it is a recommended best practice
Review comment:
```suggestion
as part of `local_verify.sh`; for now it is a recommended best practice
```
##########
File path: docs/release_instructions.md
##########
@@ -250,14 +274,17 @@ information into the release description.
### Dockerhub updates
+**Only a PMC member can push images to the openwhisk organization on dockerhub**
Review comment:
```suggestion
**Only a PMC member can push images to the OpenWhisk organization on Docker Hub**
```
##########
File path: docs/release_instructions.md
##########
@@ -250,14 +274,17 @@ information into the release description.
### Dockerhub updates
+**Only a PMC member can push images to the openwhisk organization on dockerhub**
Review comment:
heh I see `dockerhub` is throughout... ignore this nit :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org