You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/11 13:07:33 UTC
[GitHub] [superset] zhaoyongjie opened a new pull request #12408: refactor: from superset.utils.core break down date_parser
zhaoyongjie opened a new pull request #12408:
URL: https://github.com/apache/superset/pull/12408
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
The `superset.utils.core` is too large and difficult to maintain, so break down date_parser.py
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
UT to the new place
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12408: refactor: from superset.utils.core break down date_parser
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12408:
URL: https://github.com/apache/superset/pull/12408#issuecomment-757956454
# [Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=h1) Report
> Merging [#12408](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=desc) (a08944f) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `6.17%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12408 +/- ##
==========================================
- Coverage 66.88% 60.71% -6.18%
==========================================
Files 1014 529 -485
Lines 49513 19607 -29906
Branches 5077 5077
==========================================
- Hits 33118 11904 -21214
+ Misses 16264 7493 -8771
- Partials 131 210 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.71% <ø> (ø)` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/chart/ChartContainer.jsx](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0Q29udGFpbmVyLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [superset-frontend/src/explore/reducers/index.js](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvaW5kZXguanM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/dashboard/containers/Dashboard.jsx](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZC5qc3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/filters/components/Select/types.ts](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHlwZXMudHM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/dashboard/containers/SliceAdder.jsx](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL1NsaWNlQWRkZXIuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...t-frontend/src/explore/reducers/getInitialState.js](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZ2V0SW5pdGlhbFN0YXRlLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/visualizations/presets/MainPreset.js](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3Zpc3VhbGl6YXRpb25zL3ByZXNldHMvTWFpblByZXNldC5qcw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [667 more](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=footer). Last update [ff7b789...9add899](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #12408: refactor: from superset.utils.core break down date_parser
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #12408:
URL: https://github.com/apache/superset/pull/12408#issuecomment-758256878
this is beyond my ability to test. 😅
@graceguo-supercat thanks for reviewing!
@ktmud can you take another look and merge it if everything looks ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12408: refactor: from superset.utils.core break down date_parser
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12408:
URL: https://github.com/apache/superset/pull/12408#issuecomment-757956454
# [Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=h1) Report
> Merging [#12408](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=desc) (9add899) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `3.25%`.
> The diff coverage is `90.68%`.
[](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12408 +/- ##
==========================================
- Coverage 66.88% 63.63% -3.26%
==========================================
Files 1014 486 -528
Lines 49513 29884 -19629
Branches 5077 0 -5077
==========================================
- Hits 33118 19016 -14102
+ Misses 16264 10868 -5396
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.63% <90.68%> (-0.59%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...56f1c4c6\_migrate\_num\_period\_compare\_and\_period\_.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8zZGRhNTZmMWM0YzZfbWlncmF0ZV9udW1fcGVyaW9kX2NvbXBhcmVfYW5kX3BlcmlvZF8ucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.20% <50.00%> (+0.02%)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.93% <60.00%> (+0.02%)` | :arrow_up: |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `95.10% <95.10%> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.66% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.91% <100.00%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <100.00%> (-1.31%)` | :arrow_down: |
| [superset/views/api.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `70.90% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [547 more](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=footer). Last update [ff7b789...9add899](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12408: refactor: from superset.utils.core break down date_parser
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12408:
URL: https://github.com/apache/superset/pull/12408#issuecomment-757956454
# [Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=h1) Report
> Merging [#12408](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=desc) (9add899) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `4.26%`.
> The diff coverage is `90.68%`.
[](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12408 +/- ##
==========================================
- Coverage 66.88% 62.62% -4.27%
==========================================
Files 1014 1015 +1
Lines 49513 49506 -7
Branches 5077 5077
==========================================
- Hits 33118 31003 -2115
- Misses 16264 18293 +2029
- Partials 131 210 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.71% <ø> (ø)` | |
| python | `63.87% <90.68%> (-0.35%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...56f1c4c6\_migrate\_num\_period\_compare\_and\_period\_.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8zZGRhNTZmMWM0YzZfbWlncmF0ZV9udW1fcGVyaW9kX2NvbXBhcmVfYW5kX3BlcmlvZF8ucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.20% <50.00%> (+0.02%)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.93% <60.00%> (+0.02%)` | :arrow_up: |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `95.10% <95.10%> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.66% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.91% <100.00%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <100.00%> (-1.31%)` | :arrow_down: |
| [superset/views/api.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `70.90% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [203 more](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=footer). Last update [ff7b789...9add899](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #12408: refactor: from superset.utils.core break down date_parser
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12408:
URL: https://github.com/apache/superset/pull/12408#issuecomment-758256878
this is beyond my ability to review. 😅
@graceguo-supercat thanks for reviewing!
@ktmud can you take another look and merge it if everything looks ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12408: refactor: from superset.utils.core break down date_parser
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12408:
URL: https://github.com/apache/superset/pull/12408#issuecomment-757956454
# [Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=h1) Report
> Merging [#12408](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=desc) (9add899) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `3.22%`.
> The diff coverage is `90.68%`.
[](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12408 +/- ##
==========================================
- Coverage 66.88% 63.66% -3.23%
==========================================
Files 1014 486 -528
Lines 49513 29899 -19614
Branches 5077 0 -5077
==========================================
- Hits 33118 19035 -14083
+ Misses 16264 10864 -5400
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.66% <90.68%> (-0.56%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...56f1c4c6\_migrate\_num\_period\_compare\_and\_period\_.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8zZGRhNTZmMWM0YzZfbWlncmF0ZV9udW1fcGVyaW9kX2NvbXBhcmVfYW5kX3BlcmlvZF8ucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.20% <50.00%> (+0.02%)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.93% <60.00%> (+0.02%)` | :arrow_up: |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `95.10% <95.10%> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.66% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.91% <100.00%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <100.00%> (-1.31%)` | :arrow_down: |
| [superset/views/api.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `70.90% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [537 more](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=footer). Last update [ff7b789...9add899](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #12408: refactor: from superset.utils.core break down date_parser
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #12408:
URL: https://github.com/apache/superset/pull/12408#issuecomment-758256878
this is beyond my ability to test. 😅
@graceguo-supercat thanks for reviewing!
@ktmud can you take another look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12408: refactor: from superset.utils.core break down date_parser
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12408:
URL: https://github.com/apache/superset/pull/12408#issuecomment-757956454
# [Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=h1) Report
> Merging [#12408](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=desc) (9add899) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `3.30%`.
> The diff coverage is `90.68%`.
[](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12408 +/- ##
==========================================
- Coverage 66.88% 63.58% -3.31%
==========================================
Files 1014 486 -528
Lines 49513 29884 -19629
Branches 5077 0 -5077
==========================================
- Hits 33118 19001 -14117
+ Misses 16264 10883 -5381
+ Partials 131 0 -131
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `?` | |
| python | `63.58% <90.68%> (-0.64%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...56f1c4c6\_migrate\_num\_period\_compare\_and\_period\_.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8zZGRhNTZmMWM0YzZfbWlncmF0ZV9udW1fcGVyaW9kX2NvbXBhcmVfYW5kX3BlcmlvZF8ucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.20% <50.00%> (+0.02%)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.93% <60.00%> (+0.02%)` | :arrow_up: |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `95.10% <95.10%> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.66% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.91% <100.00%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <100.00%> (-1.31%)` | :arrow_down: |
| [superset/views/api.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `70.90% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| ... and [551 more](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=footer). Last update [ff7b789...9add899](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #12408: refactor: from superset.utils.core break down date_parser
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #12408:
URL: https://github.com/apache/superset/pull/12408
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #12408: refactor: from superset.utils.core break down date_parser
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #12408:
URL: https://github.com/apache/superset/pull/12408#issuecomment-758259483
CI is green so this is probably safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12408: refactor: from superset.utils.core break down date_parser
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12408:
URL: https://github.com/apache/superset/pull/12408#issuecomment-757956454
# [Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=h1) Report
> Merging [#12408](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=desc) (9add899) into [master](https://codecov.io/gh/apache/superset/commit/ff7b7899312c8d6d0205f37fd3e5321a8f4a8f16?el=desc) (ff7b789) will **decrease** coverage by `4.39%`.
> The diff coverage is `90.68%`.
[](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12408 +/- ##
==========================================
- Coverage 66.88% 62.49% -4.40%
==========================================
Files 1014 1015 +1
Lines 49513 49506 -7
Branches 5077 5077
==========================================
- Hits 33118 30939 -2179
- Misses 16264 18357 +2093
- Partials 131 210 +79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `60.71% <ø> (ø)` | |
| python | `63.66% <90.68%> (-0.56%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...56f1c4c6\_migrate\_num\_period\_compare\_and\_period\_.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy8zZGRhNTZmMWM0YzZfbWlncmF0ZV9udW1fcGVyaW9kX2NvbXBhcmVfYW5kX3BlcmlvZF8ucHk=) | `0.00% <0.00%> (ø)` | |
| [superset/viz\_sip38.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5) | `0.00% <0.00%> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `82.20% <50.00%> (+0.02%)` | :arrow_up: |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `59.93% <60.00%> (+0.02%)` | :arrow_up: |
| [superset/utils/date\_parser.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0ZV9wYXJzZXIucHk=) | `95.10% <95.10%> (ø)` | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `91.66% <100.00%> (+0.07%)` | :arrow_up: |
| [superset/tasks/cache.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2FjaGUucHk=) | `73.91% <100.00%> (ø)` | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `88.56% <100.00%> (-1.31%)` | :arrow_down: |
| [superset/views/api.py](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYXBpLnB5) | `70.90% <100.00%> (ø)` | |
| [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [207 more](https://codecov.io/gh/apache/superset/pull/12408/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=footer). Last update [ff7b789...9add899](https://codecov.io/gh/apache/superset/pull/12408?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org