You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by GitBox <gi...@apache.org> on 2021/12/26 00:47:02 UTC
[GitHub] [guacamole-server] necouchman opened a new pull request #358: GUACAMOLE-1293: Add support for notifying that a user has joined an existing connection.
necouchman opened a new pull request #358:
URL: https://github.com/apache/guacamole-server/pull/358
This pull request adds support for notifying the connection owner that another user has joined their connection. This is broken up into three commits - the first adds the underlying support for the "msg" instruction and updates the protocol accordingly, the second adds support for the "name" handshake instruction, allowing guacd to have a human-readable user name, and the third the actual support for sending the notification.
I'm sure it needs some work and clean-up, and there may be better approaches, but I took a shot :-D.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] jmuehlner commented on a change in pull request #358: GUACAMOLE-1293: Add support for notifying that a user has joined an existing connection.
Posted by GitBox <gi...@apache.org>.
jmuehlner commented on a change in pull request #358:
URL: https://github.com/apache/guacamole-server/pull/358#discussion_r840956018
##########
File path: src/libguac/user-handlers.c
##########
@@ -676,6 +677,21 @@ int __guac_handshake_image_handler(guac_user* user, int argc, char** argv) {
}
+int __guac_handshake_name_handler(guac_user* user, int argc, char** argv) {
+
+ /* Free any past value */
+ free((char *) user->info.name);
+
+ if (argc > 0 && strcmp(argv[0], ""))
Review comment:
I think this would benefit from a comment describing what this is for, and maybe some more descriptive variable names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] necouchman commented on a change in pull request #358: GUACAMOLE-1293: Add support for notifying that a user has joined an existing connection.
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #358:
URL: https://github.com/apache/guacamole-server/pull/358#discussion_r840971661
##########
File path: src/libguac/user-handlers.c
##########
@@ -676,6 +677,21 @@ int __guac_handshake_image_handler(guac_user* user, int argc, char** argv) {
}
+int __guac_handshake_name_handler(guac_user* user, int argc, char** argv) {
+
+ /* Free any past value */
+ free((char *) user->info.name);
+
+ if (argc > 0 && strcmp(argv[0], ""))
Review comment:
Okay, I've added some additional comments to that area, and I renamed the `name` member of the `info` struct to `real_name`. I was having trouble coming up with anything that fit it any better - as usual, open to suggestions. I need to update the client-side code, as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-server] necouchman commented on a change in pull request #358: GUACAMOLE-1293: Add support for notifying that a user has joined an existing connection.
Posted by GitBox <gi...@apache.org>.
necouchman commented on a change in pull request #358:
URL: https://github.com/apache/guacamole-server/pull/358#discussion_r840981841
##########
File path: src/libguac/user-handlers.c
##########
@@ -676,6 +677,21 @@ int __guac_handshake_image_handler(guac_user* user, int argc, char** argv) {
}
+int __guac_handshake_name_handler(guac_user* user, int argc, char** argv) {
+
+ /* Free any past value */
+ free((char *) user->info.name);
+
+ if (argc > 0 && strcmp(argv[0], ""))
Review comment:
Actually, scratch that, I went with "username". I can do "client_username" if that makes more sense....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org