[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #13852: support sql comment hint.

[GitBox <gi...@apache.org>]

strongduanmu commented on a change in pull request #13852:
URL: https://github.com/apache/shardingsphere/pull/13852#discussion_r758955619



##########
File path: shardingsphere-infra/shardingsphere-infra-binder/src/main/java/org/apache/shardingsphere/infra/binder/statement/CommonSQLStatementContext.java
##########
@@ -72,4 +75,13 @@ private DatabaseType getDatabaseType(final SQLStatement sqlStatement) {
         }
         throw new UnsupportedOperationException(sqlStatement.getClass().getName());
     }
+    
+    /**
+     * Extract hint datasource name.
+     *
+     * @return datasource name
+     */
+    public Optional<String> extractHintDataSourceName() {

Review comment:
       @tuichenchuxin Do you think `findHintDataSourceName` is better?

##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/common/extractor/SQLHintExtractor.java
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.sql.parser.sql.common.extractor;
+
+import lombok.AccessLevel;
+import lombok.NoArgsConstructor;
+import org.apache.shardingsphere.sql.parser.sql.common.segment.generic.CommentSegment;
+import org.apache.shardingsphere.sql.parser.sql.common.statement.AbstractSQLStatement;
+
+import java.util.Optional;
+
+/**
+ * SQL hint extractor.
+ */
+@NoArgsConstructor(access = AccessLevel.PRIVATE)
+public final class SQLHintExtractor {
+    
+    private static final String SQL_COMMENT_SUFFIX = "*/";
+    
+    private static final String SQL_HINT_TOKEN = "shardingsphere hint:";
+    
+    private static final String SQL_HINT_SPLIT = "=";
+    
+    private static final String SQL_HINT_DATASOURCE_NAME_KEY = "datasourcename";
+    
+    /**
+     * Extract hint datasource name.
+     *
+     * @param statement statement
+     * @return datasource name
+     */
+    public static Optional<String> extractHintDataSourceName(final AbstractSQLStatement statement) {

Review comment:
       @tuichenchuxin Can we add some unit test for this class?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org