[GitHub] [incubator-kyuubi] cfmcgrady commented on a diff in pull request #2966: Remove TProtocolVersion from SessionHandle/OperationHandle

[GitBox <gi...@apache.org>]

cfmcgrady commented on code in PR #2966:
URL: https://github.com/apache/incubator-kyuubi/pull/2966#discussion_r909465928


##########
kyuubi-common/src/test/scala/org/apache/kyuubi/operation/OperationHandleSuite.scala:
##########
@@ -19,31 +19,19 @@ package org.apache.kyuubi.operation
 
 import java.util.UUID
 
-import org.apache.hive.service.rpc.thrift.TProtocolVersion
-import org.apache.hive.service.rpc.thrift.TProtocolVersion._
-
 import org.apache.kyuubi.KyuubiFunSuite
 
 class OperationHandleSuite extends KyuubiFunSuite {
 
   test("OperationHandle") {
-    val h1 = OperationHandle(HIVE_CLI_SERVICE_PROTOCOL_V10)
-    TProtocolVersion.values().foreach { protocol =>
-      assert(h1 === OperationHandle(h1.identifier, protocol))
-    }
-
+    val h1 = OperationHandle()
     val t1 = h1.toTOperationHandle
-    TProtocolVersion.values().foreach { protocol =>
-      assert(h1 === OperationHandle(t1, protocol))
-    }
-    val h2 = OperationHandle(t1)
-    assert(h1 === h2)
+    OperationHandle(t1)

Review Comment:
   nit: useless code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org