You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/01/31 02:30:25 UTC

[GitHub] [druid] codecov-io commented on issue #8848: Refactor DirectDruidClient, extract QueryContextInputStreamResponseHandler

codecov-io commented on issue #8848: Refactor DirectDruidClient, extract QueryContextInputStreamResponseHandler
URL: https://github.com/apache/druid/pull/8848#issuecomment-580554959
 
 
   # [Codecov](https://codecov.io/gh/apache/druid/pull/8848?src=pr&el=h1) Report
   > Merging [#8848](https://codecov.io/gh/apache/druid/pull/8848?src=pr&el=desc) into [master](https://codecov.io/gh/apache/druid/commit/204ba9966f94d3e99be980ec9b2817eda0931ee2?src=pr&el=desc) will **increase** coverage by `0.96%`.
   > The diff coverage is `17.96%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/druid/pull/8848/graphs/tree.svg?width=650&token=hn9gC9NXg0&height=150&src=pr)](https://codecov.io/gh/apache/druid/pull/8848?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8848      +/-   ##
   ============================================
   + Coverage     62.93%    63.9%   +0.96%     
   - Complexity    22577    22580       +3     
   ============================================
     Files          2980     2865     -115     
     Lines        123590   117386    -6204     
     Branches      17030    15646    -1384     
   ============================================
   - Hits          77785    75010    -2775     
   + Misses        38708    35510    -3198     
   + Partials       7097     6866     -231
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/druid/pull/8848?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ava/org/apache/druid/client/DirectDruidClient.java](https://codecov.io/gh/apache/druid/pull/8848/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kcnVpZC9jbGllbnQvRGlyZWN0RHJ1aWRDbGllbnQuamF2YQ==) | `79.31% <100%> (+41.17%)` | `9 <0> (ø)` | :arrow_down: |
   | [...client/QueryContextInputStreamResponseHandler.java](https://codecov.io/gh/apache/druid/pull/8848/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kcnVpZC9jbGllbnQvUXVlcnlDb250ZXh0SW5wdXRTdHJlYW1SZXNwb25zZUhhbmRsZXIuamF2YQ==) | `16.26% <16.26%> (ø)` | `2 <2> (?)` | |
   | [...java/org/apache/druid/client/BrokerServerView.java](https://codecov.io/gh/apache/druid/pull/8848/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kcnVpZC9jbGllbnQvQnJva2VyU2VydmVyVmlldy5qYXZh) | `57.37% <50%> (+1.12%)` | `10 <1> (ø)` | :arrow_down: |
   | [.../server/coordination/SegmentChangeRequestNoop.java](https://codecov.io/gh/apache/druid/pull/8848/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kcnVpZC9zZXJ2ZXIvY29vcmRpbmF0aW9uL1NlZ21lbnRDaGFuZ2VSZXF1ZXN0Tm9vcC5qYXZh) | `20% <0%> (-20%)` | `1% <0%> (-1%)` | |
   | [.../apache/druid/client/BatchServerInventoryView.java](https://codecov.io/gh/apache/druid/pull/8848/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kcnVpZC9jbGllbnQvQmF0Y2hTZXJ2ZXJJbnZlbnRvcnlWaWV3LmphdmE=) | `80.76% <0%> (-5.77%)` | `10% <0%> (-1%)` | |
   | [...ache/druid/indexing/overlord/RemoteTaskRunner.java](https://codecov.io/gh/apache/druid/pull/8848/diff?src=pr&el=tree#diff-aW5kZXhpbmctc2VydmljZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHJ1aWQvaW5kZXhpbmcvb3ZlcmxvcmQvUmVtb3RlVGFza1J1bm5lci5qYXZh) | `63.26% <0%> (-0.35%)` | `83% <0%> (-1%)` | |
   | [...che/druid/metadata/SqlSegmentsMetadataManager.java](https://codecov.io/gh/apache/druid/pull/8848/diff?src=pr&el=tree#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kcnVpZC9tZXRhZGF0YS9TcWxTZWdtZW50c01ldGFkYXRhTWFuYWdlci5qYXZh) | `71.69% <0%> (-0.27%)` | `66% <0%> (-1%)` | |
   | [...nsole/src/components/show-history/show-history.tsx](https://codecov.io/gh/apache/druid/pull/8848/diff?src=pr&el=tree#diff-d2ViLWNvbnNvbGUvc3JjL2NvbXBvbmVudHMvc2hvdy1oaXN0b3J5L3Nob3ctaGlzdG9yeS50c3g=) | | | |
   | [web-console/src/components/loader/loader.tsx](https://codecov.io/gh/apache/druid/pull/8848/diff?src=pr&el=tree#diff-d2ViLWNvbnNvbGUvc3JjL2NvbXBvbmVudHMvbG9hZGVyL2xvYWRlci50c3g=) | | | |
   | [web-console/src/components/deferred/deferred.tsx](https://codecov.io/gh/apache/druid/pull/8848/diff?src=pr&el=tree#diff-d2ViLWNvbnNvbGUvc3JjL2NvbXBvbmVudHMvZGVmZXJyZWQvZGVmZXJyZWQudHN4) | | | |
   | ... and [123 more](https://codecov.io/gh/apache/druid/pull/8848/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/druid/pull/8848?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/druid/pull/8848?src=pr&el=footer). Last update [204ba99...806825f](https://codecov.io/gh/apache/druid/pull/8848?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org