[GitHub] [arrow] assignUser commented on pull request #36835: GH-29847: [C++] Build with Azure SDK for C++

["assignUser (via GitHub)" <gi...@apache.org>]

assignUser commented on PR #36835:
URL: https://github.com/apache/arrow/pull/36835#issuecomment-1692399865

   > It seems like we're passing -Wall -Werror when building bundled dependencies? It makes us heavily dependent on maintenance policies of third-party projects.
   
   I agree dependencies should not be build with -Werror etc. This is an issue with the use of the flag variables directly. As we can now use cmake 3.16 we should move to target based properties vs global flags but that is of course a major refactor...
   
   @Tom-Newton the use of external project within arrow is 'historic' as we just recently increased our minimum cmake version enough to make use of fc. Eventually it would be great to move everything to fc so adding new deps with fc instead of ep is in my eyes encouraged!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org