You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/22 16:50:02 UTC
[GitHub] [beam] ahmedabu98 opened a new pull request, #17446: [BEAM-14356] fixing a postcommit test
ahmedabu98 opened a new pull request, #17446:
URL: https://github.com/apache/beam/pull/17446
BigQueryIOJsonIT.java is failing due to a missing pipeline option. This PR is for a small fix to get it running properly again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on a diff in pull request #17446: [BEAM-14356] fixing a postcommit test
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on code in PR #17446:
URL: https://github.com/apache/beam/pull/17446#discussion_r856519336
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOJsonIT.java:
##########
@@ -65,7 +66,13 @@
public class BigQueryIOJsonIT {
private static final Logger LOG = LoggerFactory.getLogger(BigQueryIOJsonIT.class);
- @Rule public final transient TestPipeline p = TestPipeline.create();
+ private static PipelineOptions testOptions = TestPipeline.testingPipelineOptions();
+
+ static {
+ testOptions.setTempLocation("gs://bigqueryio-json-it-temp/java-tmp");
Review Comment:
Was going to make the bucket available for allUsers, but your suggestion is a lot more reasonable.
Made the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] apilloud commented on a diff in pull request #17446: [BEAM-14356] fixing a postcommit test
Posted by GitBox <gi...@apache.org>.
apilloud commented on code in PR #17446:
URL: https://github.com/apache/beam/pull/17446#discussion_r856510214
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOJsonIT.java:
##########
@@ -65,7 +66,13 @@
public class BigQueryIOJsonIT {
private static final Logger LOG = LoggerFactory.getLogger(BigQueryIOJsonIT.class);
- @Rule public final transient TestPipeline p = TestPipeline.create();
+ private static PipelineOptions testOptions = TestPipeline.testingPipelineOptions();
+
+ static {
+ testOptions.setTempLocation("gs://bigqueryio-json-it-temp/java-tmp");
Review Comment:
How do you expect this test to run for those who don't have access to `gs://bigqueryio-json-it-temp`? We have a bunch of tests that do something like `options.setTempLocation(options.getTempRoot() + "/java-tmp");` can you do something like that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17446: [BEAM-14356] fixing a postcommit test
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17446:
URL: https://github.com/apache/beam/pull/17446#issuecomment-1106690759
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] apilloud commented on pull request #17446: [BEAM-14356] fixing a postcommit test
Posted by GitBox <gi...@apache.org>.
apilloud commented on PR #17446:
URL: https://github.com/apache/beam/pull/17446#issuecomment-1108745824
run java postcommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #17446: [BEAM-14356] fixing a postcommit test
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #17446:
URL: https://github.com/apache/beam/pull/17446#issuecomment-1108680361
R: @apilloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17446: [BEAM-14356] fixing a postcommit test
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17446:
URL: https://github.com/apache/beam/pull/17446#issuecomment-1106690756
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #17446: [BEAM-14356] fixing a postcommit test
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #17446:
URL: https://github.com/apache/beam/pull/17446#issuecomment-1106787913
R: @apilloud
This should fix the failing postcommits.
PreCommits failing for other reasons
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] apilloud commented on pull request #17446: [BEAM-14356] fixing a postcommit test
Posted by GitBox <gi...@apache.org>.
apilloud commented on PR #17446:
URL: https://github.com/apache/beam/pull/17446#issuecomment-1106791627
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] asf-ci commented on pull request #17446: [BEAM-14356] fixing a postcommit test
Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17446:
URL: https://github.com/apache/beam/pull/17446#issuecomment-1106690766
Can one of the admins verify this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] apilloud merged pull request #17446: [BEAM-14356] fixing a postcommit test
Posted by GitBox <gi...@apache.org>.
apilloud merged PR #17446:
URL: https://github.com/apache/beam/pull/17446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] apilloud commented on a diff in pull request #17446: [BEAM-14356] fixing a postcommit test
Posted by GitBox <gi...@apache.org>.
apilloud commented on code in PR #17446:
URL: https://github.com/apache/beam/pull/17446#discussion_r856523487
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOJsonIT.java:
##########
@@ -281,6 +289,10 @@ public void readAndValidateRows(BigQueryIOJsonOptions options) {
bigqueryIO = bigqueryIO.from(options.getInputTable());
}
+ if (options.getReadMethod() == TypedRead.Method.EXPORT) {
+ options.setTempLocation("gs://bigqueryio-json-it-temp/java-tmp");
Review Comment:
nit: this one too...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #17446: [BEAM-14356] fixing a postcommit test
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #17446:
URL: https://github.com/apache/beam/pull/17446#issuecomment-1106692657
Run PostCommit_Java_DataflowV2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #17446: [BEAM-14356] fixing a postcommit test
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #17446:
URL: https://github.com/apache/beam/pull/17446#issuecomment-1107652569
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #17446: [BEAM-14356] fixing a postcommit test
Posted by GitBox <gi...@apache.org>.
ahmedabu98 commented on PR #17446:
URL: https://github.com/apache/beam/pull/17446#issuecomment-1106815392
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org