You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/03/10 23:56:27 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #1266: HBASE-23956 Use less resources running tests

Apache9 commented on a change in pull request #1266: HBASE-23956 Use less resources running tests
URL: https://github.com/apache/hbase/pull/1266#discussion_r390676375
 
 

 ##########
 File path: hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/DefaultNettyEventLoopConfig.java
 ##########
 @@ -31,10 +30,16 @@
  */
 @InterfaceAudience.Private
 class DefaultNettyEventLoopConfig {
 
 Review comment:
   This is not the design...
   
   The design is to create a new EventLoop and make the code use it.
   
   Change a configuration to change the 'default' instance and then make the code use the 'default' instance seems strange...
   
   And also another anti pattern is that, we even do not have a Configuration instance here...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services