You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/21 19:35:37 UTC
[GitHub] [spark] amaliujia opened a new pull request, #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
amaliujia opened a new pull request, #38335:
URL: https://github.com/apache/spark/pull/38335
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
1. Improve README for how to install `buf` dependency and then run the proto generated file script.
2. Improve the message for out-of-sync check script.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
3. If you fix a bug, you can clarify why it is a bug.
-->
Improve developer experience either when touching Connect proto files or not touch those files but having master branch out of sync with local branch.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Existing checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #38335:
URL: https://github.com/apache/spark/pull/38335#discussion_r1002285288
##########
python/pyspark/sql/connect/README.md:
##########
@@ -49,3 +49,8 @@ To use the release version of Spark Connect:
./python/run-tests --testnames 'pyspark.sql.tests.connect.test_connect_basic'
```
+## Generate proto generated files for the Python client
+1. Install `buf`: https://docs.buf.build/installation
+2. Run `pip install grpcio==1.48.1 protobuf==4.21.6 mypy-protobuf==3.3.0`
+3. Run `./dev/generate_protos.sh`
Review Comment:
@amaliujia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #38335:
URL: https://github.com/apache/spark/pull/38335#discussion_r1002269337
##########
python/pyspark/sql/connect/README.md:
##########
@@ -49,3 +49,7 @@ To use the release version of Spark Connect:
./python/run-tests --testnames 'pyspark.sql.tests.connect.test_connect_basic'
```
+## Generate proto generated files for the Python client
+1. Install `buf`: https://docs.buf.build/installation
Review Comment:
`buf`'s version in CI is `1.8.0`, the latest on is `1.9.0`. I think we also need to mention the version
##########
python/pyspark/sql/connect/README.md:
##########
@@ -49,3 +49,7 @@ To use the release version of Spark Connect:
./python/run-tests --testnames 'pyspark.sql.tests.connect.test_connect_basic'
```
+## Generate proto generated files for the Python client
+1. Install `buf`: https://docs.buf.build/installation
Review Comment:
`buf`'s version in CI is `1.8.0`, the latest one is `1.9.0`. I think we also need to mention the version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #38335:
URL: https://github.com/apache/spark/pull/38335#discussion_r1002269147
##########
python/pyspark/sql/connect/README.md:
##########
@@ -49,3 +49,7 @@ To use the release version of Spark Connect:
./python/run-tests --testnames 'pyspark.sql.tests.connect.test_connect_basic'
```
+## Generate proto generated files for the Python client
+1. Install `buf`: https://docs.buf.build/installation
Review Comment:
I think we also need to mention the related python packages:
grpcio==1.48.1
protobuf==4.21.6
mypy-protobuf==3.3.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rangadi commented on a diff in pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
Posted by GitBox <gi...@apache.org>.
rangadi commented on code in PR #38335:
URL: https://github.com/apache/spark/pull/38335#discussion_r1002179251
##########
dev/check-codegen-python.py:
##########
@@ -75,7 +75,9 @@ def check_connect_protos():
else:
fail(
"Generated files for pyspark-connect are out of sync! "
- "Please run ./connector/connect/dev/generate_protos.sh"
+ "If you have touched files under connector/connect/src/main/protobuf, "
+ "please run ./connector/connect/dev/generate_protos.sh. "
+ "If you haven't touched any file above, please rebase your PR against main branch."
Review Comment:
Is this for CI/CD or for local tests? Rebasing helps local branch, yes, not for CI/CD.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38335:
URL: https://github.com/apache/spark/pull/38335#discussion_r1002175956
##########
dev/check-codegen-python.py:
##########
@@ -75,7 +75,9 @@ def check_connect_protos():
else:
fail(
"Generated files for pyspark-connect are out of sync! "
- "Please run ./connector/connect/dev/generate_protos.sh"
+ "If you have touched files under connector/connect/src/main/protobuf, "
+ "please run ./connector/connect/dev/generate_protos.sh. "
+ "If you haven't touched any file above, please rebase your PR against main branch."
Review Comment:
This script generates files from the proto itself, and proto might be updated in the main branch, so that the generated files in the sky now is different from the files in this local branch thus the check fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng closed pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
Posted by GitBox <gi...@apache.org>.
zhengruifeng closed pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
URL: https://github.com/apache/spark/pull/38335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38335:
URL: https://github.com/apache/spark/pull/38335#issuecomment-1287367746
R: @zhengruifeng @HyukjinKwon
cc: @HeartSaVioR @rangadi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38335:
URL: https://github.com/apache/spark/pull/38335#discussion_r1002289255
##########
python/pyspark/sql/connect/README.md:
##########
@@ -49,3 +49,8 @@ To use the release version of Spark Connect:
./python/run-tests --testnames 'pyspark.sql.tests.connect.test_connect_basic'
```
+## Generate proto generated files for the Python client
+1. Install `buf`: https://docs.buf.build/installation
+2. Run `pip install grpcio==1.48.1 protobuf==4.21.6 mypy-protobuf==3.3.0`
+3. Run `./dev/generate_protos.sh`
Review Comment:
oops I copied this from my local command which is not under the spark repo root directory.
@zhengruifeng maybe you BTW update it in the PR that you pin dependency versions.
##########
python/pyspark/sql/connect/README.md:
##########
@@ -49,3 +49,8 @@ To use the release version of Spark Connect:
./python/run-tests --testnames 'pyspark.sql.tests.connect.test_connect_basic'
```
+## Generate proto generated files for the Python client
+1. Install `buf`: https://docs.buf.build/installation
+2. Run `pip install grpcio==1.48.1 protobuf==4.21.6 mypy-protobuf==3.3.0`
+3. Run `./dev/generate_protos.sh`
Review Comment:
oops I copied this from my local command which is not under the spark repo root directory.
@zhengruifeng maybe you can BTW update it in the PR that you pin dependency versions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38335:
URL: https://github.com/apache/spark/pull/38335#discussion_r1002181146
##########
dev/check-codegen-python.py:
##########
@@ -75,7 +75,9 @@ def check_connect_protos():
else:
fail(
"Generated files for pyspark-connect are out of sync! "
- "Please run ./connector/connect/dev/generate_protos.sh"
+ "If you have touched files under connector/connect/src/main/protobuf, "
+ "please run ./connector/connect/dev/generate_protos.sh. "
+ "If you haven't touched any file above, please rebase your PR against main branch."
Review Comment:
This is to help pass CI/CD. CI/CD sync to latest main branch if I understand it right:
<img width="454" alt="Screen Shot 2022-10-21 at 1 55 14 PM" src="https://user-images.githubusercontent.com/1938382/197287176-e92cf3f5-7dc8-4273-bc8d-e3e0272327b3.png">
If don't consider CI/CD, the local development has no issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38335:
URL: https://github.com/apache/spark/pull/38335#issuecomment-1287552170
merged into master, thank you @amaliujia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38335:
URL: https://github.com/apache/spark/pull/38335#discussion_r1002175956
##########
dev/check-codegen-python.py:
##########
@@ -75,7 +75,9 @@ def check_connect_protos():
else:
fail(
"Generated files for pyspark-connect are out of sync! "
- "Please run ./connector/connect/dev/generate_protos.sh"
+ "If you have touched files under connector/connect/src/main/protobuf, "
+ "please run ./connector/connect/dev/generate_protos.sh. "
+ "If you haven't touched any file above, please rebase your PR against main branch."
Review Comment:
Here are two layers of things: proto and its generated files.
This script generates files from the proto itself, and proto might be updated in the main branch, so that the generated files in the sky now is different from the files in this local branch thus the check fails.
When merging with the main branch, the generated files might not encounter conflicts but I guess that does not mean it matches when one try to re-generate it from the proto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #38335:
URL: https://github.com/apache/spark/pull/38335#discussion_r1002289219
##########
python/pyspark/sql/connect/README.md:
##########
@@ -49,3 +49,8 @@ To use the release version of Spark Connect:
./python/run-tests --testnames 'pyspark.sql.tests.connect.test_connect_basic'
```
+## Generate proto generated files for the Python client
+1. Install `buf`: https://docs.buf.build/installation
+2. Run `pip install grpcio==1.48.1 protobuf==4.21.6 mypy-protobuf==3.3.0`
+3. Run `./dev/generate_protos.sh`
Review Comment:
I fix it in https://github.com/apache/spark/pull/38339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38335:
URL: https://github.com/apache/spark/pull/38335#discussion_r1002270515
##########
python/pyspark/sql/connect/README.md:
##########
@@ -49,3 +49,7 @@ To use the release version of Spark Connect:
./python/run-tests --testnames 'pyspark.sql.tests.connect.test_connect_basic'
```
+## Generate proto generated files for the Python client
+1. Install `buf`: https://docs.buf.build/installation
Review Comment:
makes sense. I updated this doc with versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] amaliujia commented on a diff in pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
Posted by GitBox <gi...@apache.org>.
amaliujia commented on code in PR #38335:
URL: https://github.com/apache/spark/pull/38335#discussion_r1002181146
##########
dev/check-codegen-python.py:
##########
@@ -75,7 +75,9 @@ def check_connect_protos():
else:
fail(
"Generated files for pyspark-connect are out of sync! "
- "Please run ./connector/connect/dev/generate_protos.sh"
+ "If you have touched files under connector/connect/src/main/protobuf, "
+ "please run ./connector/connect/dev/generate_protos.sh. "
+ "If you haven't touched any file above, please rebase your PR against main branch."
Review Comment:
This is to help pass CI/CD. CI/CD sync to latest main branch if I understand it right then we hit the scenario above:
<img width="454" alt="Screen Shot 2022-10-21 at 1 55 14 PM" src="https://user-images.githubusercontent.com/1938382/197287176-e92cf3f5-7dc8-4273-bc8d-e3e0272327b3.png">
If don't consider CI/CD, the local development has no issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] rangadi commented on a diff in pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
Posted by GitBox <gi...@apache.org>.
rangadi commented on code in PR #38335:
URL: https://github.com/apache/spark/pull/38335#discussion_r1002173180
##########
dev/check-codegen-python.py:
##########
@@ -75,7 +75,9 @@ def check_connect_protos():
else:
fail(
"Generated files for pyspark-connect are out of sync! "
- "Please run ./connector/connect/dev/generate_protos.sh"
+ "If you have touched files under connector/connect/src/main/protobuf, "
+ "please run ./connector/connect/dev/generate_protos.sh. "
+ "If you haven't touched any file above, please rebase your PR against main branch."
Review Comment:
How does rebase help? I think ci/cd merges with master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #38335: [SPARK-40796][CONNECT][FOLLOW-UP] Improve README for proto generated files in Connect Python client
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #38335:
URL: https://github.com/apache/spark/pull/38335#discussion_r1002284563
##########
python/pyspark/sql/connect/README.md:
##########
@@ -49,3 +49,8 @@ To use the release version of Spark Connect:
./python/run-tests --testnames 'pyspark.sql.tests.connect.test_connect_basic'
```
+## Generate proto generated files for the Python client
+1. Install `buf`: https://docs.buf.build/installation
+2. Run `pip install grpcio==1.48.1 protobuf==4.21.6 mypy-protobuf==3.3.0`
+3. Run `./dev/generate_protos.sh`
Review Comment:
oops, should be `./connector/connect/dev/generate_protos.sh`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org