[jira] [Commented] (HTRACE-146) Search page: Remove sorting and improve pagination

["Colin Patrick McCabe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTRACE-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14389761#comment-14389761 ] 

Colin Patrick McCabe commented on HTRACE-146:
---------------------------------------------

I think this jira should be renamed to "remove client-side sorting", right?  We still do server-side sorting and that has always worked.

{code}
115	    this.state.finished = resp.length <= 10;
{code}
Should be a constant?  Or at least some named variable, if Javascript doesn't allow that :)

It looks like we're moving from using "gt" to get the span after the saved span, to using "ge" on a span we've saved from the previous page.  What's the motivation for this change?

Also why are we hard-coding a predicate for spanId?  The predicates should be user-defined, right?  Maybe we want to sort by begin time.

> Search page: Remove sorting and improve pagination
> --------------------------------------------------
>
>                 Key: HTRACE-146
>                 URL: https://issues.apache.org/jira/browse/HTRACE-146
>             Project: HTrace
>          Issue Type: Sub-task
>            Reporter: Abraham Elmahrek
>            Assignee: Abraham Elmahrek
>              Labels: ui
>             Fix For: 3.2.0
>
>         Attachments: HTRACE-146.001.patch
>
>
> Search page sorting doesn't really work because it is in infinite scroll mode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)