You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/10/21 22:28:12 UTC
[GitHub] [incubator-superset] betodealmeida opened a new pull request #11373: feat: add affordances for new export functionality
betodealmeida opened a new pull request #11373:
URL: https://github.com/apache/incubator-superset/pull/11373
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11373: feat: add affordances for new export functionality
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11373:
URL: https://github.com/apache/incubator-superset/pull/11373#issuecomment-714032501
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=h1) Report
> Merging [#11373](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=desc) into [SO-1002](https://codecov.io/gh/apache/incubator-superset/commit/fb90e06622ef407e035fe25386a9785de674d076?el=desc) will **decrease** coverage by `6.78%`.
> The diff coverage is `42.30%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## SO-1002 #11373 +/- ##
===========================================
- Coverage 65.91% 59.13% -6.79%
===========================================
Files 842 804 -38
Lines 40015 38721 -1294
Branches 3652 3450 -202
===========================================
- Hits 26377 22897 -3480
- Misses 13537 15654 +2117
- Partials 101 170 +69
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.96% <26.82%> (-0.08%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `60.84% <100.00%> (-0.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `2.81% <0.00%> (-79.24%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `1.75% <0.00%> (-71.42%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.15% <ø> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.73% <ø> (-2.84%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.43% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `69.49% <58.82%> (-12.91%)` | :arrow_down: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <100.00%> (ø)` | |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.55% <100.00%> (+0.43%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `95.23% <100.00%> (+0.50%)` | :arrow_up: |
| ... and [286 more](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=footer). Last update [fb90e06...82f43c0](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io commented on pull request #11373: feat: add affordances for new export functionality
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #11373:
URL: https://github.com/apache/incubator-superset/pull/11373#issuecomment-714032501
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=h1) Report
> Merging [#11373](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=desc) into [SO-1002](https://codecov.io/gh/apache/incubator-superset/commit/fb90e06622ef407e035fe25386a9785de674d076?el=desc) will **decrease** coverage by `5.61%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## SO-1002 #11373 +/- ##
===========================================
- Coverage 65.91% 60.30% -5.62%
===========================================
Files 842 397 -445
Lines 40015 25131 -14884
Branches 3652 0 -3652
===========================================
- Hits 26377 15154 -11223
+ Misses 13537 9977 -3560
+ Partials 101 0 -101
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.30% <100.00%> (-0.89%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.15% <ø> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.73% <ø> (-2.84%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <ø> (-25.14%)` | :arrow_down: |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.55% <100.00%> (+0.43%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `95.23% <100.00%> (+0.50%)` | :arrow_up: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.44% <100.00%> (-3.30%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| ... and [460 more](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=footer). Last update [fb90e06...82f43c0](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] betodealmeida merged pull request #11373: feat: add affordances for new export functionality
Posted by GitBox <gi...@apache.org>.
betodealmeida merged pull request #11373:
URL: https://github.com/apache/incubator-superset/pull/11373
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11373: feat: add affordances for new export functionality
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11373:
URL: https://github.com/apache/incubator-superset/pull/11373#issuecomment-714032501
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=h1) Report
> Merging [#11373](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=desc) into [SO-1002](https://codecov.io/gh/apache/incubator-superset/commit/fb90e06622ef407e035fe25386a9785de674d076?el=desc) will **decrease** coverage by `5.61%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## SO-1002 #11373 +/- ##
===========================================
- Coverage 65.91% 60.30% -5.62%
===========================================
Files 842 397 -445
Lines 40015 25131 -14884
Branches 3652 0 -3652
===========================================
- Hits 26377 15154 -11223
+ Misses 13537 9977 -3560
+ Partials 101 0 -101
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.30% <100.00%> (-0.89%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.15% <ø> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.73% <ø> (-2.84%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `62.30% <ø> (-25.14%)` | :arrow_down: |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.55% <100.00%> (+0.43%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `95.23% <100.00%> (+0.50%)` | :arrow_up: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.44% <100.00%> (-3.30%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| ... and [460 more](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=footer). Last update [fb90e06...82f43c0](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11373: feat: add affordances for new export functionality
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11373:
URL: https://github.com/apache/incubator-superset/pull/11373#issuecomment-714032501
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=h1) Report
> Merging [#11373](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=desc) into [SO-1002](https://codecov.io/gh/apache/incubator-superset/commit/fb90e06622ef407e035fe25386a9785de674d076?el=desc) will **decrease** coverage by `5.06%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## SO-1002 #11373 +/- ##
===========================================
- Coverage 65.91% 60.84% -5.07%
===========================================
Files 842 397 -445
Lines 40015 25131 -14884
Branches 3652 0 -3652
===========================================
- Hits 26377 15292 -11085
+ Misses 13537 9839 -3698
+ Partials 101 0 -101
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `?` | |
| #javascript | `?` | |
| #python | `60.84% <100.00%> (-0.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.15% <ø> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.73% <ø> (-2.84%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.43% <ø> (ø)` | |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.55% <100.00%> (+0.43%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `95.23% <100.00%> (+0.50%)` | :arrow_up: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `89.44% <100.00%> (-3.30%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `79.59% <0.00%> (-12.25%)` | :arrow_down: |
| [superset/db\_engine\_specs/sqlite.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NxbGl0ZS5weQ==) | `65.62% <0.00%> (-9.38%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `82.97% <0.00%> (-8.52%)` | :arrow_down: |
| ... and [453 more](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=footer). Last update [fb90e06...82f43c0](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #11373: feat: add affordances for new export functionality
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #11373:
URL: https://github.com/apache/incubator-superset/pull/11373#issuecomment-714032501
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=h1) Report
> Merging [#11373](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=desc) into [SO-1002](https://codecov.io/gh/apache/incubator-superset/commit/fb90e06622ef407e035fe25386a9785de674d076?el=desc) will **decrease** coverage by `7.01%`.
> The diff coverage is `42.30%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## SO-1002 #11373 +/- ##
===========================================
- Coverage 65.91% 58.90% -7.02%
===========================================
Files 842 804 -38
Lines 40015 38721 -1294
Branches 3652 3450 -202
===========================================
- Hits 26377 22809 -3568
- Misses 13537 15734 +2197
- Partials 101 178 +77
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `55.31% <26.82%> (-0.72%)` | :arrow_down: |
| #javascript | `?` | |
| #python | `60.84% <100.00%> (-0.34%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4) | `2.81% <0.00%> (-79.24%)` | :arrow_down: |
| [...ontend/src/views/CRUD/data/dataset/DatasetList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0RhdGFzZXRMaXN0LnRzeA==) | `1.75% <0.00%> (-71.42%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `76.98% <ø> (ø)` | |
| [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.15% <ø> (ø)` | |
| [superset/databases/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `87.73% <ø> (-2.84%)` | :arrow_down: |
| [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `87.43% <ø> (ø)` | |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `69.49% <58.82%> (-12.91%)` | :arrow_down: |
| [superset-frontend/src/featureFlags.ts](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZlYXR1cmVGbGFncy50cw==) | `100.00% <100.00%> (ø)` | |
| [superset/charts/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2V4cG9ydC5weQ==) | `95.55% <100.00%> (+0.43%)` | :arrow_up: |
| [superset/dashboards/commands/export.py](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9leHBvcnQucHk=) | `95.23% <100.00%> (+0.50%)` | :arrow_up: |
| ... and [288 more](https://codecov.io/gh/apache/incubator-superset/pull/11373/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=footer). Last update [fb90e06...82f43c0](https://codecov.io/gh/apache/incubator-superset/pull/11373?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org