You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by solomax <gi...@git.apache.org> on 2016/11/16 17:03:40 UTC
[GitHub] wicket pull request #190: AjaxDownload is implemented using hidden iframe
GitHub user solomax opened a pull request:
https://github.com/apache/wicket/pull/190
AjaxDownload is implemented using hidden iframe
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/solomax/wicket wicket-7.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/190.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #190
----
commit 3901031084e9a8ef97c24fce469aab0fc31fc23f
Author: Maxim Solodovnik <so...@gmail.com>
Date: 2016-11-16T17:02:44Z
AjaxDownload is implemented using hidden iframe
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #190: AjaxDownload is implemented using hidden iframe
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/190
@Jezza Please check the implementation by @svenmeier at https://issues.apache.org/jira/browse/WICKET-6286.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request #190: AjaxDownload is implemented using hidden iframe
Posted by solomax <gi...@git.apache.org>.
Github user solomax closed the pull request at:
https://github.com/apache/wicket/pull/190
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #190: AjaxDownload is implemented using hidden iframe
Posted by Jezza <gi...@git.apache.org>.
Github user Jezza commented on the issue:
https://github.com/apache/wicket/pull/190
This seems overtly complex given you can achieve the same thing with resources.
Requiring a behaviour to be attached seems a bit too much, as well as the potential page lock.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #190: AjaxDownload is implemented using hidden iframe
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/190
@solomax Please close this PR! We will use the solution in https://issues.apache.org/jira/browse/WICKET-6286. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---