You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by payou <gi...@git.apache.org> on 2016/02/27 10:03:05 UTC
[GitHub] wicket pull request: Upgrade to Atmosphere 2.4.2
GitHub user payou opened a pull request:
https://github.com/apache/wicket/pull/160
Upgrade to Atmosphere 2.4.2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/payou/wicket master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/160.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #160
----
commit bf22a254cc0b3787d4658da9f5c603c7a10d7435
Author: unknown <ol...@gmail.com>
Date: 2016-02-27T09:01:19Z
Upgrade to Atmosphere 2.4.2
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Upgrade to Atmosphere 2.4.2
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/160#issuecomment-191319406
Ah, I didn't notice that you have updated the PR.
I'll test it locally and update to 2.4.3 if everything is OK.
Thank you!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Upgrade to Atmosphere 2.4.2
Posted by payou <gi...@git.apache.org>.
Github user payou commented on a diff in the pull request:
https://github.com/apache/wicket/pull/160#discussion_r54528005
--- Diff: wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereRequestHandler.java ---
@@ -73,7 +74,19 @@ public void respond(IRequestCycle requestCycle)
{
WebApplication application = WebApplication.get();
Integer pageId = pageKey.getPageId();
+ Session.get().getPageManager().touchPage(new Page() {
--- End diff --
Don't remember why.
I commit again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Upgrade to Atmosphere 2.4.2
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/160#discussion_r54380384
--- Diff: wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java ---
@@ -16,11 +16,7 @@
*/
package org.apache.wicket.atmosphere;
-import org.apache.wicket.Application;
-import org.apache.wicket.Component;
-import org.apache.wicket.MetaDataKey;
-import org.apache.wicket.Page;
-import org.apache.wicket.WicketRuntimeException;
+import org.apache.wicket.*;
--- End diff --
Yes, but I'll fix those before committing them to Apache Git repo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Upgrade to Atmosphere 2.4.2
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/160#discussion_r54375979
--- Diff: wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereRequestHandler.java ---
@@ -73,7 +74,19 @@ public void respond(IRequestCycle requestCycle)
{
WebApplication application = WebApplication.get();
Integer pageId = pageKey.getPageId();
+ Session.get().getPageManager().touchPage(new Page() {
+ @Override
+ public PageParameters getPageParameters() {
+ return super.getPageParameters();
+ }
+
+ @Override
+ public int getPageId() {
+ return 0;
--- End diff --
And why this id is `0`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Upgrade to Atmosphere 2.4.2
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/160#discussion_r54750689
--- Diff: wicket-experimental/wicket-atmosphere/pom.xml ---
@@ -41,7 +41,7 @@
</repository>
</repositories>
<properties>
- <atmosphere.version>2.2.8</atmosphere.version>
+ <atmosphere.version>2.4.2</atmosphere.version>
--- End diff --
2.4.3 has been released in the meantime.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Upgrade to Atmosphere 2.4.2
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/160#issuecomment-207852651
Please try to make https://github.com/apache/wicket/tree/pr-160-master running againts latest Atmosphere version.
I've hit several issues with 2.4.x.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Upgrade to Atmosphere 2.4.2
Posted by MarcGiffing <gi...@git.apache.org>.
Github user MarcGiffing commented on the pull request:
https://github.com/apache/wicket/pull/160#issuecomment-193862809
I've currently have problems with the lookup of the atmopshere.xml in an embedded tomcat.
Maybe the deprecated methods should be updated with the update of the latest atmosphere version.
EventBus.java:
```
private static Broadcaster lookupDefaultBroadcaster()
{
BroadcasterFactory factory = BroadcasterFactory.getDefault();
if (factory == null)
{
throw new WicketRuntimeException(
"There is no Atmosphere BroadcasterFactory configured. Did you include the "
+ "atmosphere.xml configuration file and configured AtmosphereServlet?");
}
```
The BroadcasterFactory.getDefault(); is deprecated and instead you should use:
`org.atmosphere.cpr.AtmosphereConfig.resourcesFactory()`
It's only a hint...I'm not sure if its related to my problem.
https://github.com/Atmosphere/atmosphere/wiki/Getting-BroadcasterFactory-and-AtmosphereResourceFactory-with-2.2-and-newer
> With the release of Atmosphere 2.2.0, the static getters BroadcasterFactory.getDefault() and AtmosphereResourceFactory.getDefault() were deprecated, and from 2.3+ they are completely removed.
Okay...the static getters are still there ... :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #160: Upgrade to Atmosphere 2.4.2
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the issue:
https://github.com/apache/wicket/pull/160
@payou Please close this PR! Wicket team decided to discontinue the support for Wicket-Atmosphere (see https://issues.apache.org/jira/browse/WICKET-6305). Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request #160: Upgrade to Atmosphere 2.4.2
Posted by payou <gi...@git.apache.org>.
Github user payou closed the pull request at:
https://github.com/apache/wicket/pull/160
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Upgrade to Atmosphere 2.4.2
Posted by payou <gi...@git.apache.org>.
Github user payou commented on a diff in the pull request:
https://github.com/apache/wicket/pull/160#discussion_r54527947
--- Diff: wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java ---
@@ -382,7 +375,9 @@ public synchronized void unregisterConnection(String trackingId)
*/
public void post(Object event, String resourceUuid)
{
- AtmosphereResource resource = AtmosphereResourceFactory.getDefault().find(resourceUuid);
+// AtmosphereResource resource = AtmosphereResourceFactory.getDefault().find(resourceUuid);
--- End diff --
ok
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Upgrade to Atmosphere 2.4.2
Posted by AlienQueen <gi...@git.apache.org>.
Github user AlienQueen commented on the pull request:
https://github.com/apache/wicket/pull/160#issuecomment-207822549
Good evening,
Any news with this PR, please? I'd really like it to join the wicket-7.x branch.
Thanks in advance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Upgrade to Atmosphere 2.4.2
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/160#issuecomment-192905999
X-Ref: https://github.com/Atmosphere/atmosphere/issues/2140
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Upgrade to Atmosphere 2.4.2
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on a diff in the pull request:
https://github.com/apache/wicket/pull/160#discussion_r54375917
--- Diff: wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereRequestHandler.java ---
@@ -73,7 +74,19 @@ public void respond(IRequestCycle requestCycle)
{
WebApplication application = WebApplication.get();
Integer pageId = pageKey.getPageId();
+ Session.get().getPageManager().touchPage(new Page() {
--- End diff --
Why this is needed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Upgrade to Atmosphere 2.4.2
Posted by martin-g <gi...@git.apache.org>.
Github user martin-g commented on the pull request:
https://github.com/apache/wicket/pull/160#issuecomment-192903071
There are some problems with the PR.
Initially its single unit test was failing.
I've fixed it by using again TesterBroadcaster.
Now deployment at Tomcat 8.x fails with:
```
java.lang.NullPointerException
org.atmosphere.handler.ReflectorServletProcessor.loadServlet(ReflectorServletProcessor.java:104)
org.atmosphere.handler.ReflectorServletProcessor.loadWebApplication(ReflectorServletProcessor.java:84)
org.atmosphere.handler.ReflectorServletProcessor.init(ReflectorServletProcessor.java:172)
org.atmosphere.cpr.AtmosphereFramework.initAtmosphereHandler(AtmosphereFramework.java:1732)
org.atmosphere.cpr.AtmosphereFramework.initAtmosphereHandler(AtmosphereFramework.java:1721)
org.atmosphere.cpr.AtmosphereFramework.init(AtmosphereFramework.java:917)
org.atmosphere.cpr.AtmosphereFramework.init(AtmosphereFramework.java:838)
org.atmosphere.cpr.AtmosphereFrameworkInitializer.configureFramework(AtmosphereFrameworkInitializer.java:75)
org.atmosphere.cpr.AtmosphereServlet.configureFramework(AtmosphereServlet.java:84)
org.atmosphere.cpr.AtmosphereServlet.configureFramework(AtmosphereServlet.java:80)
org.atmosphere.cpr.AtmosphereServlet.init(AtmosphereServlet.java:75)
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:501)
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79)
org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:610)
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:516)
org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1086)
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:659)
org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223)
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1558)
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1515)
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
java.lang.Thread.run(Thread.java:745)
```
Please take a look at branch https://github.com/apache/wicket/tree/pr-160-master and commit https://github.com/apache/wicket/commit/ebfa1bb3381b187b704b0170b742f06ad2b84c24
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Upgrade to Atmosphere 2.4.2
Posted by shuraa <gi...@git.apache.org>.
Github user shuraa commented on a diff in the pull request:
https://github.com/apache/wicket/pull/160#discussion_r54380477
--- Diff: wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/EventBus.java ---
@@ -382,7 +375,9 @@ public synchronized void unregisterConnection(String trackingId)
*/
public void post(Object event, String resourceUuid)
{
- AtmosphereResource resource = AtmosphereResourceFactory.getDefault().find(resourceUuid);
+// AtmosphereResource resource = AtmosphereResourceFactory.getDefault().find(resourceUuid);
--- End diff --
You should remove this line of code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket issue #160: Upgrade to Atmosphere 2.4.2
Posted by payou <gi...@git.apache.org>.
Github user payou commented on the issue:
https://github.com/apache/wicket/pull/160
OK
Atmosphere is �ber complicated
So good luck with WebSocket
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] wicket pull request: Upgrade to Atmosphere 2.4.2
Posted by shuraa <gi...@git.apache.org>.
Github user shuraa commented on a diff in the pull request:
https://github.com/apache/wicket/pull/160#discussion_r54379879
--- Diff: wicket-experimental/wicket-atmosphere/src/main/java/org/apache/wicket/atmosphere/AtmosphereBehavior.java ---
@@ -16,11 +16,7 @@
*/
package org.apache.wicket.atmosphere;
-import org.apache.wicket.Application;
-import org.apache.wicket.Component;
-import org.apache.wicket.MetaDataKey;
-import org.apache.wicket.Page;
-import org.apache.wicket.WicketRuntimeException;
+import org.apache.wicket.*;
--- End diff --
As far as I know, wicket code convention doesn't allow to use imports with wildcard.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---