You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@yandex-team.ru> on 2017/09/11 09:17:01 UTC

Review Request 62213: Send TASK_STARTING from the built-in executors. [2/2]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62213/
-----------------------------------------------------------

Review request for mesos, Andrei Budnik and Alexander Rukletsov.


Bugs: MESOS-7941
    https://issues.apache.org/jira/browse/MESOS-7941


Repository: mesos


Description
-------

Fix unit tests for previous commit.


Diffs
-----

  src/tests/api_tests.cpp 0902a66772d178505e83b81878b7878a45c7bb25 
  src/tests/check_tests.cpp cc7be317030d147c5617e784a50e42b0365b9df6 
  src/tests/command_executor_tests.cpp f706f55b5bfab824268498d95d775b216561cd66 
  src/tests/container_logger_tests.cpp 97e79792d3ea8023890ad2a705db47f2aeb419cf 
  src/tests/containerizer/environment_secret_isolator_tests.cpp 38fef2d5f677f768a0533d1ac085b1197b3b764d 
  src/tests/containerizer/posix_rlimits_isolator_tests.cpp 0030cd1e1f73422bef806bbc0453134e3d7840d8 
  src/tests/default_executor_tests.cpp 186b8333c02ba3b9257e19437c6d689761085362 
  src/tests/disk_quota_tests.cpp 3bf0508238a228d86737d6cc899fa68e2046f2e2 
  src/tests/fault_tolerance_tests.cpp 5ac38a897fefb6f40d69ca6e27a6f23176e42d36 
  src/tests/health_check_tests.cpp 2c43241a5cc245a1797ea16c68c94638cec6803d 
  src/tests/master_tests.cpp 59fbad468ae671a8fd39457632262015989f26c2 
  src/tests/master_validation_tests.cpp 710b25c1afdff4de7b2eb9b8a38f6856c373fb3c 
  src/tests/oversubscription_tests.cpp a4c4a6083a2cb55e2d69eba1719555a7a13ee8fb 
  src/tests/partition_tests.cpp 0886f4890ac3fec6f38146946892769a99c3e68f 
  src/tests/persistent_volume_endpoints_tests.cpp 7a24bf48e9d84bf31ad85397ac3e1b4e566cbc2c 
  src/tests/persistent_volume_tests.cpp 3e1d1fe468298186347b07b5882973c5a16231a3 
  src/tests/reconciliation_tests.cpp 728961874239c7e5ce8accbaeb2a1c86a73a4f0f 
  src/tests/reservation_endpoints_tests.cpp 3278732cb130c73be0f20c0204eddaee05123ff9 
  src/tests/role_tests.cpp fc4c017dc59ab44a0ce0ea46f02eb6e1706ffb72 
  src/tests/scheduler_tests.cpp 21f8825c214bb0c331f66bfb9b12a354d6673a43 
  src/tests/slave_authorization_tests.cpp 30eceae0920351cffc9c3393c6d08917c4041c1a 
  src/tests/slave_recovery_tests.cpp 0e46748be266809c413fb10fc447516c51504fce 
  src/tests/slave_tests.cpp 1bdadce4c50cbff958f2be2a4261e130b414acfd 
  src/tests/teardown_tests.cpp 8834333bbcdb6a04a95a6ed9632ad4ead0791f76 


Diff: https://reviews.apache.org/r/62213/diff/1/


Testing
-------


Thanks,

Benno Evers


Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62213/#review186752
-----------------------------------------------------------



FAIL: Some Mesos tests failed.

Reviews applied: `['62212', '62213']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose --gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62213

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62213/logs/mesos-tests-stdout.log):

```
[----------] Global test environment tear-down
[==========] 636 tests from 67 test cases ran. (588866 ms total)
[  PASSED  ] 615 tests.
[  FAILED  ] 21 tests, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckStatusChange
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout
[  FAILED  ] CommandExecutorCheckTest.CommandCheckAndHealthCheckNoShadowing
[  FAILED  ] DefaultExecutorCheckTest.CommandCheckAndHealthCheckNoShadowing
[  FAILED  ] HTTPCommandExecutorTest.ExplicitAcknowledgements
[  FAILED  ] HealthCheckTest.HealthyTask
[  FAILED  ] HealthCheckTest.HealthyTaskNonShell
[  FAILED  ] HealthCheckTest.ConsecutiveFailures
[  FAILED  ] HealthCheckTest.EnvironmentSetup
[  FAILED  ] HealthCheckTest.GracePeriod
[  FAILED  ] HealthCheckTest.CheckCommandTimeout
[  FAILED  ] HealthCheckTest.HealthyToUnhealthyTransitionWithinGracePeriod
[  FAILED  ] HealthCheckTest.HealthyTaskViaTCP
[  FAILED  ] SlaveTest.CommandTaskWithKillPolicy
[  FAILED  ] SlaveTest.StatisticsEndpointRunningExecutor
[  FAILED  ] HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/0, where GetParam() = false
[  FAILED  ] HTTPCommandExecutor/CommandExecutorTest.NoTaskKillingCapability/1, where GetParam() = true
[  FAILED  ] HTTPCommandExecutor/CommandExecutorTest.TaskKillingCapability/0, where GetParam() = false
[  FAILED  ] HTTPCommandExecutor/CommandExecutorTest.TaskKillingCapability/1, where GetParam() = true
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.ROOT_ContainerStatusForTask/0, where GetParam() = "mesos"
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"

21 FAILED TESTS
  YOU HAVE 174 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62213/logs/mesos-tests-stderr.log):

```
I0929 22:19:53.078156 31456 master.cpp:8418] Removing framework 469678d9-0630-4a2c-bea0-3fe1bf761c71-0000 (default)
I0929 22:19:53.078156 31456 master.cpp:3267] Deactivating framework 469678d9-0630-4a2c-bea0-3fe1bf761c71-0000 (default)
I0929 22:19:53.079155 30516 hierarchical.cpp:412] Deactivated framework 469678d9-0630-4a2c-bea0-3fe1bf761c71-0000
I0929 22:19:53.079155 30024 slave.cpp:3248] Shutting down framework 469678d9-0630-4a2c-bea0-3fe1bf761c71-0000
I0929 22:19:53.079155 31456 master.cpp:8993] Updating the state of task 0be475a3-9a01-457e-a42a-7ac80c78d758 of framework 469678d9-0630-4a2c-bea0-3fe1bf761c71-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I0929 22:19:53.096598 30024 slave.cpp:5755] Shutting down executor 'default' of framework 469678d9-0630-4a2c-bea0-3fe1bf761c71-0000 (via HTTP)
I0929 22:19:53.099606 31456 master.cpp:9087] Removing task 0be475a3-9a01-457e-a42a-7ac80c78d758 with resources [{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}] of framework 469678d9-0630-4a2c-bea0-3fe1bf761c71-0000 on agent 469678d9-0630-4a2c-bea0-3fe1bf761c71-S0 at slave(255)@10.3.1.7:54694 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0929 22:19:53.117606 31456 master.cpp:9116] Removing executor 'default' with resources [] of framework 469678d9-0630-4a2c-bea0-3fe1bf761c71-0000 on agent 469678d9-0630-4a2c-bea0-3fe1bf761c71-S0 at slave(255)@10.3.1.7:54694 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0929 22:19:53.120606 29992 hierarchical.cpp:355] Removed framework 469678d9-0630-4a2c-bea0-3fe1bf761c71-0000
E0929 22:19:53.121605 31440 scheduler.cpp:649] End-Of-File received from master. The master closed the event stream
I0929 22:19:53.126607 29992 scheduler.cpp:444] Re-detecting master
I0929 22:19:53.130606 29992 scheduler.cpp:470] New master detected at master@10.3.1.7:54694
I0929 22:19:53.140605 31456 slave.cpp:5420] Executor 'default' of framework 469678d9-0630-4a2c-bea0-3fe1bf761c71-0000 exited with status 0
I0929 22:19:53.155608 31456 slave.cpp:5524] Cleaning up executor 'default' of framework 469678d9-0630-4a2c-bea0-3fe1bf761c71-0000 (via HTTP)
W0929 22:19:53.155608 30868 master.cpp:7021] Ignoring unknown exited executor 'default' of framework 469678d9-0630-4a2c-bea0-3fe1bf761c71-0000 on agent 469678d9-0630-4a2c-bea0-3fe1bf761c71-S0 at slave(255)@10.3.1.7:54694 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0929 22:19:53.156605 30024 gc.cpp:90] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\En2QUo\slaves\469678d9-0630-4a2c-bea0-3fe1bf761c71-S0\frameworks\469678d9-0630-4a2c-bea0-3fe1bf761c71-0000\executors\default\runs\007efc1a-1c04-422a-92a1-05f4124999e8' for gc 6.99998661335704days in the future
I0929 22:19:53.158605 31448 gc.cpp:90] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\En2QUo\slaves\469678d9-0630-4a2c-bea0-3fe1bf761c71-S0\frameworks\469678d9-0630-4a2c-bea0-3fe1bf761c71-0000\executors\default' for gc 6.99998659020741days in the future
I0929 22:19:53.158605 31456 slave.cpp:5631] Cleaning up framework 469678d9-0630-4a2c-bea0-3fe1bf761c71-0000
I0929 22:19:53.184608 30516 status_update_manager.cpp:285] Closing status update streams for framework 469678d9-0630-4a2c-bea0-3fe1bf761c71-0000
I0929 22:19:53.185607 29992 gc.cpp:90] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\En2QUo\slaves\469678d9-0630-4a2c-bea0-3fe1bf761c71-S0\frameworks\469678d9-0630-4a2c-bea0-3fe1bf761c71-0000' for gc 6.99998627768593days in the future
I0929 22:19:53.185607 31456 slave.cpp:869] Agent terminating
I0929 22:19:53.186607 30868 master.cpp:1321] Agent 469678d9-0630-4a2c-bea0-3fe1bf761c71-S0 at slave(255)@10.3.1.7:54694 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0929 22:19:53.186607 30868 master.cpp:3304] Disconnecting agent 469678d9-0630-4a2c-bea0-3fe1bf761c71-S0 at slave(255)@10.3.1.7:54694 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0929 22:19:53.187608 30868 master.cpp:3323] Deactivating agent 469678d9-0630-4a2c-bea0-3fe1bf761c71-S0 at slave(255)@10.3.1.7:54694 (mesos-bld-s2.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0929 22:19:53.198606 31440 hierarchical.cpp:690] Agent 469678d9-0630-4a2c-bea0-3fe1bf761c71-S0 deactivated
I0929 22:19:53.216608 29992 master.cpp:1163] Master terminating
I0929 22:19:53.220608 31440 hierarchical.cpp:626] Removed agent 469678d9-0630-4a2c-bea0-3fe1bf761c71-S0
W0929 22:19:53.225608 31264 master.hpp:2761] Failed to close HTTP pipe for 469678d9-0630-4a2c-bea0-3fe1bf761c71-0000 (default)
I0929 22:19:53.998628 28348 process.cpp:1068] Failed to accept socket: future discarded
```

- Mesos Reviewbot Windows


On Sept. 29, 2017, 7:48 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62213/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2017, 7:48 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
>     https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix unit tests that were broken by the additional TASK_STARTING update.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp d260a1c9560e8ff6b46eea7f2f4ddb11e18653e3 
>   src/tests/check_tests.cpp fd15a47f1d67ad852d84d83aad54c9fa93c60bbb 
>   src/tests/command_executor_tests.cpp f706f55b5bfab824268498d95d775b216561cd66 
>   src/tests/container_logger_tests.cpp fb8e441bd3842b1840a384a025fa8e9ccbb22cf6 
>   src/tests/containerizer/environment_secret_isolator_tests.cpp cf7b9eb6fd76dbdd3650ea2ad5b9097cf490e948 
>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp 0030cd1e1f73422bef806bbc0453134e3d7840d8 
>   src/tests/default_executor_tests.cpp dd1a6ad0d4e2bf74972e15b478652196ee9cd927 
>   src/tests/disk_quota_tests.cpp 742b6e1a6340d488f4bae8acbd09a3e575c72ad2 
>   src/tests/fault_tolerance_tests.cpp c34850aaa76289d822317f30e5da0e0cb7f115c6 
>   src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
>   src/tests/master_tests.cpp 98908c00c2d5bfd08122fd317a2ce95332d9583d 
>   src/tests/master_validation_tests.cpp f00dd9b6fcb963b995fa238766a531f073205ce9 
>   src/tests/oversubscription_tests.cpp 02b10d6689dd6f01510cd2d5db2bb76b4b190eca 
>   src/tests/partition_tests.cpp 0886f4890ac3fec6f38146946892769a99c3e68f 
>   src/tests/persistent_volume_endpoints_tests.cpp 7a24bf48e9d84bf31ad85397ac3e1b4e566cbc2c 
>   src/tests/persistent_volume_tests.cpp 1b35af427a2561f6094560c7bc9387dcb948b781 
>   src/tests/reconciliation_tests.cpp 64a1d3da9f03b863551555c4734aef39e835b122 
>   src/tests/reservation_endpoints_tests.cpp 5a6e9a7f08a5306542830f359868b2c31f4820c6 
>   src/tests/role_tests.cpp fc4c017dc59ab44a0ce0ea46f02eb6e1706ffb72 
>   src/tests/scheduler_tests.cpp 4eda96e50a505eb36588bbcf9c3ba76d9ede7839 
>   src/tests/slave_authorization_tests.cpp 4c7d37fd14c8f3e7a52d35fb685fb8f05cba1e70 
>   src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312 
>   src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723 
>   src/tests/teardown_tests.cpp 5eada4f4392b7c721f5efbd537b0e817d40c7a27 
> 
> 
> Diff: https://reviews.apache.org/r/62213/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62213/#review188553
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Oct. 18, 2017, 4:24 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62213/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2017, 4:24 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
>     https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 0e99e7bf3a2cf4243cd73a5cb857bfc4d4e55f78 
>   src/tests/check_tests.cpp fd15a47f1d67ad852d84d83aad54c9fa93c60bbb 
>   src/tests/command_executor_tests.cpp f706f55b5bfab824268498d95d775b216561cd66 
>   src/tests/container_logger_tests.cpp fb8e441bd3842b1840a384a025fa8e9ccbb22cf6 
>   src/tests/containerizer/cgroups_isolator_tests.cpp 3fc93417f2d3febf2feca3ec1c8476c9edcfbf4d 
>   src/tests/containerizer/cni_isolator_tests.cpp e673d914fa9251fa585deea3a29438371c185fdb 
>   src/tests/containerizer/cpu_isolator_tests.cpp 153990d8960b1e74379e37b2e2ddf23f242a3712 
>   src/tests/containerizer/docker_containerizer_tests.cpp 45f0d1dbc5b21b174cd9974664299d466129df01 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp ed7d43840bf73fd4dd5c21f8d65e0a538338ee26 
>   src/tests/containerizer/environment_secret_isolator_tests.cpp cf7b9eb6fd76dbdd3650ea2ad5b9097cf490e948 
>   src/tests/containerizer/linux_filesystem_isolator_tests.cpp a657a6f60995330d14861e86df59b090ab7a015e 
>   src/tests/containerizer/memory_isolator_tests.cpp 14bd7050e147fabfae5fb32fe14d78a893a892c5 
>   src/tests/containerizer/memory_pressure_tests.cpp c4d8bfc63d6c0953cc2b3524401767fdbdf0648d 
>   src/tests/containerizer/nested_mesos_containerizer_tests.cpp f8b4423de8a468501336acc5ee0c67f181dc65f5 
>   src/tests/containerizer/port_mapping_tests.cpp 56e193bd84222648f47e36d6a1107046b2954977 
>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp 0030cd1e1f73422bef806bbc0453134e3d7840d8 
>   src/tests/containerizer/provisioner_appc_tests.cpp 89fe4fcd1b123edc762835595432f24cb699fd61 
>   src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4 
>   src/tests/containerizer/runtime_isolator_tests.cpp ea5d035ee25ead1966db8b9e4772180dfb20747d 
>   src/tests/containerizer/volume_host_path_isolator_tests.cpp f692b87e1cc95944a626b9e7c6dfb4ea9ac2bbef 
>   src/tests/default_executor_tests.cpp 68312010a45df5dbdb6d9d4c49d1faa5d8c60472 
>   src/tests/disk_quota_tests.cpp 742b6e1a6340d488f4bae8acbd09a3e575c72ad2 
>   src/tests/fault_tolerance_tests.cpp c34850aaa76289d822317f30e5da0e0cb7f115c6 
>   src/tests/gc_tests.cpp 37d3eac5c8e241a423e3a2dcd9c0f7e8dfe05bc4 
>   src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
>   src/tests/hook_tests.cpp c4fadbb6258aa1e87fbfa6a906d2e4f1f67880fa 
>   src/tests/master_tests.cpp 5d96457c86871b27c2fbe7f41a9444bbc2da6e06 
>   src/tests/master_validation_tests.cpp f00dd9b6fcb963b995fa238766a531f073205ce9 
>   src/tests/oversubscription_tests.cpp cd98b8f8eb301c41c991452ae36b0cfe767fb11f 
>   src/tests/partition_tests.cpp 0597bd2afaa60121245e0d43b81ac223257e377a 
>   src/tests/persistent_volume_endpoints_tests.cpp 444737a6c1d251e23971d9a4501f3ef76fcf5ed5 
>   src/tests/persistent_volume_tests.cpp 11fe43255cd8121f94c93a0437f7499fee1b6514 
>   src/tests/reconciliation_tests.cpp 64a1d3da9f03b863551555c4734aef39e835b122 
>   src/tests/reservation_endpoints_tests.cpp e70dd0dd36def4fbb5b61519f8bb949c50afe36e 
>   src/tests/role_tests.cpp 568ea90427cfb870b77a3c1809d8be1715d2ca33 
>   src/tests/scheduler_tests.cpp 4eda96e50a505eb36588bbcf9c3ba76d9ede7839 
>   src/tests/slave_authorization_tests.cpp 868e39ebac3b56374463b6b8278e93a49a2dc8cd 
>   src/tests/slave_recovery_tests.cpp 30d8c23de4312cc386354ef6cb44a62055c70f64 
>   src/tests/slave_tests.cpp 91d97d195acd695ae9c469651596511eafb50557 
>   src/tests/teardown_tests.cpp 5eada4f4392b7c721f5efbd537b0e817d40c7a27 
> 
> 
> Diff: https://reviews.apache.org/r/62213/diff/8/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62213/
-----------------------------------------------------------

(Updated Oct. 18, 2017, 4:24 p.m.)


Review request for mesos, Andrei Budnik and Alexander Rukletsov.


Changes
-------

Fix DynamicAddDelofCniConfig that was broken during rebase


Bugs: MESOS-7941
    https://issues.apache.org/jira/browse/MESOS-7941


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/tests/api_tests.cpp 0e99e7bf3a2cf4243cd73a5cb857bfc4d4e55f78 
  src/tests/check_tests.cpp fd15a47f1d67ad852d84d83aad54c9fa93c60bbb 
  src/tests/command_executor_tests.cpp f706f55b5bfab824268498d95d775b216561cd66 
  src/tests/container_logger_tests.cpp fb8e441bd3842b1840a384a025fa8e9ccbb22cf6 
  src/tests/containerizer/cgroups_isolator_tests.cpp 3fc93417f2d3febf2feca3ec1c8476c9edcfbf4d 
  src/tests/containerizer/cni_isolator_tests.cpp e673d914fa9251fa585deea3a29438371c185fdb 
  src/tests/containerizer/cpu_isolator_tests.cpp 153990d8960b1e74379e37b2e2ddf23f242a3712 
  src/tests/containerizer/docker_containerizer_tests.cpp 45f0d1dbc5b21b174cd9974664299d466129df01 
  src/tests/containerizer/docker_volume_isolator_tests.cpp ed7d43840bf73fd4dd5c21f8d65e0a538338ee26 
  src/tests/containerizer/environment_secret_isolator_tests.cpp cf7b9eb6fd76dbdd3650ea2ad5b9097cf490e948 
  src/tests/containerizer/linux_filesystem_isolator_tests.cpp a657a6f60995330d14861e86df59b090ab7a015e 
  src/tests/containerizer/memory_isolator_tests.cpp 14bd7050e147fabfae5fb32fe14d78a893a892c5 
  src/tests/containerizer/memory_pressure_tests.cpp c4d8bfc63d6c0953cc2b3524401767fdbdf0648d 
  src/tests/containerizer/nested_mesos_containerizer_tests.cpp f8b4423de8a468501336acc5ee0c67f181dc65f5 
  src/tests/containerizer/port_mapping_tests.cpp 56e193bd84222648f47e36d6a1107046b2954977 
  src/tests/containerizer/posix_rlimits_isolator_tests.cpp 0030cd1e1f73422bef806bbc0453134e3d7840d8 
  src/tests/containerizer/provisioner_appc_tests.cpp 89fe4fcd1b123edc762835595432f24cb699fd61 
  src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4 
  src/tests/containerizer/runtime_isolator_tests.cpp ea5d035ee25ead1966db8b9e4772180dfb20747d 
  src/tests/containerizer/volume_host_path_isolator_tests.cpp f692b87e1cc95944a626b9e7c6dfb4ea9ac2bbef 
  src/tests/default_executor_tests.cpp 68312010a45df5dbdb6d9d4c49d1faa5d8c60472 
  src/tests/disk_quota_tests.cpp 742b6e1a6340d488f4bae8acbd09a3e575c72ad2 
  src/tests/fault_tolerance_tests.cpp c34850aaa76289d822317f30e5da0e0cb7f115c6 
  src/tests/gc_tests.cpp 37d3eac5c8e241a423e3a2dcd9c0f7e8dfe05bc4 
  src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
  src/tests/hook_tests.cpp c4fadbb6258aa1e87fbfa6a906d2e4f1f67880fa 
  src/tests/master_tests.cpp 5d96457c86871b27c2fbe7f41a9444bbc2da6e06 
  src/tests/master_validation_tests.cpp f00dd9b6fcb963b995fa238766a531f073205ce9 
  src/tests/oversubscription_tests.cpp cd98b8f8eb301c41c991452ae36b0cfe767fb11f 
  src/tests/partition_tests.cpp 0597bd2afaa60121245e0d43b81ac223257e377a 
  src/tests/persistent_volume_endpoints_tests.cpp 444737a6c1d251e23971d9a4501f3ef76fcf5ed5 
  src/tests/persistent_volume_tests.cpp 11fe43255cd8121f94c93a0437f7499fee1b6514 
  src/tests/reconciliation_tests.cpp 64a1d3da9f03b863551555c4734aef39e835b122 
  src/tests/reservation_endpoints_tests.cpp e70dd0dd36def4fbb5b61519f8bb949c50afe36e 
  src/tests/role_tests.cpp 568ea90427cfb870b77a3c1809d8be1715d2ca33 
  src/tests/scheduler_tests.cpp 4eda96e50a505eb36588bbcf9c3ba76d9ede7839 
  src/tests/slave_authorization_tests.cpp 868e39ebac3b56374463b6b8278e93a49a2dc8cd 
  src/tests/slave_recovery_tests.cpp 30d8c23de4312cc386354ef6cb44a62055c70f64 
  src/tests/slave_tests.cpp 91d97d195acd695ae9c469651596511eafb50557 
  src/tests/teardown_tests.cpp 5eada4f4392b7c721f5efbd537b0e817d40c7a27 


Diff: https://reviews.apache.org/r/62213/diff/8/

Changes: https://reviews.apache.org/r/62213/diff/7-8/


Testing
-------


Thanks,

Benno Evers


Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62213/
-----------------------------------------------------------

(Updated Oct. 17, 2017, 6:14 p.m.)


Review request for mesos, Andrei Budnik and Alexander Rukletsov.


Changes
-------

Additional fixes for jenkins builds.


Bugs: MESOS-7941
    https://issues.apache.org/jira/browse/MESOS-7941


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/tests/api_tests.cpp 0e99e7bf3a2cf4243cd73a5cb857bfc4d4e55f78 
  src/tests/check_tests.cpp fd15a47f1d67ad852d84d83aad54c9fa93c60bbb 
  src/tests/command_executor_tests.cpp f706f55b5bfab824268498d95d775b216561cd66 
  src/tests/container_logger_tests.cpp fb8e441bd3842b1840a384a025fa8e9ccbb22cf6 
  src/tests/containerizer/cgroups_isolator_tests.cpp 3fc93417f2d3febf2feca3ec1c8476c9edcfbf4d 
  src/tests/containerizer/cni_isolator_tests.cpp e673d914fa9251fa585deea3a29438371c185fdb 
  src/tests/containerizer/cpu_isolator_tests.cpp 153990d8960b1e74379e37b2e2ddf23f242a3712 
  src/tests/containerizer/docker_containerizer_tests.cpp 45f0d1dbc5b21b174cd9974664299d466129df01 
  src/tests/containerizer/docker_volume_isolator_tests.cpp ed7d43840bf73fd4dd5c21f8d65e0a538338ee26 
  src/tests/containerizer/environment_secret_isolator_tests.cpp cf7b9eb6fd76dbdd3650ea2ad5b9097cf490e948 
  src/tests/containerizer/linux_filesystem_isolator_tests.cpp a657a6f60995330d14861e86df59b090ab7a015e 
  src/tests/containerizer/memory_isolator_tests.cpp 14bd7050e147fabfae5fb32fe14d78a893a892c5 
  src/tests/containerizer/memory_pressure_tests.cpp c4d8bfc63d6c0953cc2b3524401767fdbdf0648d 
  src/tests/containerizer/nested_mesos_containerizer_tests.cpp f8b4423de8a468501336acc5ee0c67f181dc65f5 
  src/tests/containerizer/port_mapping_tests.cpp 56e193bd84222648f47e36d6a1107046b2954977 
  src/tests/containerizer/posix_rlimits_isolator_tests.cpp 0030cd1e1f73422bef806bbc0453134e3d7840d8 
  src/tests/containerizer/provisioner_appc_tests.cpp 89fe4fcd1b123edc762835595432f24cb699fd61 
  src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4 
  src/tests/containerizer/runtime_isolator_tests.cpp ea5d035ee25ead1966db8b9e4772180dfb20747d 
  src/tests/containerizer/volume_host_path_isolator_tests.cpp f692b87e1cc95944a626b9e7c6dfb4ea9ac2bbef 
  src/tests/default_executor_tests.cpp 68312010a45df5dbdb6d9d4c49d1faa5d8c60472 
  src/tests/disk_quota_tests.cpp 742b6e1a6340d488f4bae8acbd09a3e575c72ad2 
  src/tests/fault_tolerance_tests.cpp c34850aaa76289d822317f30e5da0e0cb7f115c6 
  src/tests/gc_tests.cpp 37d3eac5c8e241a423e3a2dcd9c0f7e8dfe05bc4 
  src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
  src/tests/hook_tests.cpp c4fadbb6258aa1e87fbfa6a906d2e4f1f67880fa 
  src/tests/master_tests.cpp 5d96457c86871b27c2fbe7f41a9444bbc2da6e06 
  src/tests/master_validation_tests.cpp f00dd9b6fcb963b995fa238766a531f073205ce9 
  src/tests/oversubscription_tests.cpp cd98b8f8eb301c41c991452ae36b0cfe767fb11f 
  src/tests/partition_tests.cpp 0597bd2afaa60121245e0d43b81ac223257e377a 
  src/tests/persistent_volume_endpoints_tests.cpp 444737a6c1d251e23971d9a4501f3ef76fcf5ed5 
  src/tests/persistent_volume_tests.cpp 11fe43255cd8121f94c93a0437f7499fee1b6514 
  src/tests/reconciliation_tests.cpp 64a1d3da9f03b863551555c4734aef39e835b122 
  src/tests/reservation_endpoints_tests.cpp e70dd0dd36def4fbb5b61519f8bb949c50afe36e 
  src/tests/role_tests.cpp 568ea90427cfb870b77a3c1809d8be1715d2ca33 
  src/tests/scheduler_tests.cpp 4eda96e50a505eb36588bbcf9c3ba76d9ede7839 
  src/tests/slave_authorization_tests.cpp 868e39ebac3b56374463b6b8278e93a49a2dc8cd 
  src/tests/slave_recovery_tests.cpp 30d8c23de4312cc386354ef6cb44a62055c70f64 
  src/tests/slave_tests.cpp 91d97d195acd695ae9c469651596511eafb50557 
  src/tests/teardown_tests.cpp 5eada4f4392b7c721f5efbd537b0e817d40c7a27 


Diff: https://reviews.apache.org/r/62213/diff/7/

Changes: https://reviews.apache.org/r/62213/diff/6-7/


Testing
-------


Thanks,

Benno Evers


Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62213/
-----------------------------------------------------------

(Updated Oct. 13, 2017, 5:01 p.m.)


Review request for mesos, Andrei Budnik and Alexander Rukletsov.


Changes
-------

Added fixes for ROOT tests


Bugs: MESOS-7941
    https://issues.apache.org/jira/browse/MESOS-7941


Repository: mesos


Description
-------

See summary.


Diffs (updated)
-----

  src/tests/api_tests.cpp 3d0db3b6c6bfb088a79921c3841ad312dad1ee6a 
  src/tests/check_tests.cpp fd15a47f1d67ad852d84d83aad54c9fa93c60bbb 
  src/tests/command_executor_tests.cpp f706f55b5bfab824268498d95d775b216561cd66 
  src/tests/container_logger_tests.cpp fb8e441bd3842b1840a384a025fa8e9ccbb22cf6 
  src/tests/containerizer/cgroups_isolator_tests.cpp 3fc93417f2d3febf2feca3ec1c8476c9edcfbf4d 
  src/tests/containerizer/cni_isolator_tests.cpp e673d914fa9251fa585deea3a29438371c185fdb 
  src/tests/containerizer/cpu_isolator_tests.cpp 153990d8960b1e74379e37b2e2ddf23f242a3712 
  src/tests/containerizer/docker_containerizer_tests.cpp 45f0d1dbc5b21b174cd9974664299d466129df01 
  src/tests/containerizer/docker_volume_isolator_tests.cpp ed7d43840bf73fd4dd5c21f8d65e0a538338ee26 
  src/tests/containerizer/environment_secret_isolator_tests.cpp cf7b9eb6fd76dbdd3650ea2ad5b9097cf490e948 
  src/tests/containerizer/linux_filesystem_isolator_tests.cpp a657a6f60995330d14861e86df59b090ab7a015e 
  src/tests/containerizer/memory_isolator_tests.cpp 14bd7050e147fabfae5fb32fe14d78a893a892c5 
  src/tests/containerizer/memory_pressure_tests.cpp c4d8bfc63d6c0953cc2b3524401767fdbdf0648d 
  src/tests/containerizer/nested_mesos_containerizer_tests.cpp f8b4423de8a468501336acc5ee0c67f181dc65f5 
  src/tests/containerizer/posix_rlimits_isolator_tests.cpp 0030cd1e1f73422bef806bbc0453134e3d7840d8 
  src/tests/containerizer/provisioner_appc_tests.cpp 89fe4fcd1b123edc762835595432f24cb699fd61 
  src/tests/containerizer/provisioner_docker_tests.cpp 920be77b16178a4458d72145020c015130799ec4 
  src/tests/containerizer/runtime_isolator_tests.cpp ea5d035ee25ead1966db8b9e4772180dfb20747d 
  src/tests/containerizer/volume_host_path_isolator_tests.cpp f692b87e1cc95944a626b9e7c6dfb4ea9ac2bbef 
  src/tests/default_executor_tests.cpp 2b4c643b8fb2fc8f2a5e98984ae1c267f66885d1 
  src/tests/disk_quota_tests.cpp 742b6e1a6340d488f4bae8acbd09a3e575c72ad2 
  src/tests/fault_tolerance_tests.cpp c34850aaa76289d822317f30e5da0e0cb7f115c6 
  src/tests/gc_tests.cpp 37d3eac5c8e241a423e3a2dcd9c0f7e8dfe05bc4 
  src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
  src/tests/hook_tests.cpp c4fadbb6258aa1e87fbfa6a906d2e4f1f67880fa 
  src/tests/master_tests.cpp 4c776012e84c34dda7410841e063faab2a84f2df 
  src/tests/master_validation_tests.cpp f00dd9b6fcb963b995fa238766a531f073205ce9 
  src/tests/oversubscription_tests.cpp cd98b8f8eb301c41c991452ae36b0cfe767fb11f 
  src/tests/partition_tests.cpp 0597bd2afaa60121245e0d43b81ac223257e377a 
  src/tests/persistent_volume_endpoints_tests.cpp 7a24bf48e9d84bf31ad85397ac3e1b4e566cbc2c 
  src/tests/persistent_volume_tests.cpp 11fe43255cd8121f94c93a0437f7499fee1b6514 
  src/tests/reconciliation_tests.cpp 64a1d3da9f03b863551555c4734aef39e835b122 
  src/tests/reservation_endpoints_tests.cpp 5a6e9a7f08a5306542830f359868b2c31f4820c6 
  src/tests/role_tests.cpp fc4c017dc59ab44a0ce0ea46f02eb6e1706ffb72 
  src/tests/scheduler_tests.cpp 4eda96e50a505eb36588bbcf9c3ba76d9ede7839 
  src/tests/slave_authorization_tests.cpp 4c7d37fd14c8f3e7a52d35fb685fb8f05cba1e70 
  src/tests/slave_recovery_tests.cpp 30d8c23de4312cc386354ef6cb44a62055c70f64 
  src/tests/slave_tests.cpp 6d1e98d59ad0b8a02f4696ca9cc663d048109ca6 
  src/tests/teardown_tests.cpp 5eada4f4392b7c721f5efbd537b0e817d40c7a27 


Diff: https://reviews.apache.org/r/62213/diff/6/

Changes: https://reviews.apache.org/r/62213/diff/5-6/


Testing
-------


Thanks,

Benno Evers


Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62213/#review187810
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Oct. 11, 2017, 10:21 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62213/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2017, 10:21 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
>     https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 3d0db3b6c6bfb088a79921c3841ad312dad1ee6a 
>   src/tests/check_tests.cpp fd15a47f1d67ad852d84d83aad54c9fa93c60bbb 
>   src/tests/command_executor_tests.cpp f706f55b5bfab824268498d95d775b216561cd66 
>   src/tests/container_logger_tests.cpp fb8e441bd3842b1840a384a025fa8e9ccbb22cf6 
>   src/tests/containerizer/environment_secret_isolator_tests.cpp cf7b9eb6fd76dbdd3650ea2ad5b9097cf490e948 
>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp 0030cd1e1f73422bef806bbc0453134e3d7840d8 
>   src/tests/default_executor_tests.cpp 63952d97b76c3e16973705cb0b16140dd381b7ce 
>   src/tests/disk_quota_tests.cpp 742b6e1a6340d488f4bae8acbd09a3e575c72ad2 
>   src/tests/fault_tolerance_tests.cpp c34850aaa76289d822317f30e5da0e0cb7f115c6 
>   src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
>   src/tests/master_tests.cpp 4c776012e84c34dda7410841e063faab2a84f2df 
>   src/tests/master_validation_tests.cpp f00dd9b6fcb963b995fa238766a531f073205ce9 
>   src/tests/oversubscription_tests.cpp 02b10d6689dd6f01510cd2d5db2bb76b4b190eca 
>   src/tests/partition_tests.cpp 0597bd2afaa60121245e0d43b81ac223257e377a 
>   src/tests/persistent_volume_endpoints_tests.cpp 7a24bf48e9d84bf31ad85397ac3e1b4e566cbc2c 
>   src/tests/persistent_volume_tests.cpp 1b35af427a2561f6094560c7bc9387dcb948b781 
>   src/tests/reconciliation_tests.cpp 64a1d3da9f03b863551555c4734aef39e835b122 
>   src/tests/reservation_endpoints_tests.cpp 5a6e9a7f08a5306542830f359868b2c31f4820c6 
>   src/tests/role_tests.cpp fc4c017dc59ab44a0ce0ea46f02eb6e1706ffb72 
>   src/tests/scheduler_tests.cpp 4eda96e50a505eb36588bbcf9c3ba76d9ede7839 
>   src/tests/slave_authorization_tests.cpp 4c7d37fd14c8f3e7a52d35fb685fb8f05cba1e70 
>   src/tests/slave_recovery_tests.cpp 30d8c23de4312cc386354ef6cb44a62055c70f64 
>   src/tests/slave_tests.cpp 2ff6daba236972a732618257b25dc3e7fa4dec60 
>   src/tests/teardown_tests.cpp 5eada4f4392b7c721f5efbd537b0e817d40c7a27 
> 
> 
> Diff: https://reviews.apache.org/r/62213/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62213/
-----------------------------------------------------------

(Updated Oct. 11, 2017, 10:21 p.m.)


Review request for mesos, Andrei Budnik and Alexander Rukletsov.


Bugs: MESOS-7941
    https://issues.apache.org/jira/browse/MESOS-7941


Repository: mesos


Description (updated)
-------

See summary.


Diffs
-----

  src/tests/api_tests.cpp 3d0db3b6c6bfb088a79921c3841ad312dad1ee6a 
  src/tests/check_tests.cpp fd15a47f1d67ad852d84d83aad54c9fa93c60bbb 
  src/tests/command_executor_tests.cpp f706f55b5bfab824268498d95d775b216561cd66 
  src/tests/container_logger_tests.cpp fb8e441bd3842b1840a384a025fa8e9ccbb22cf6 
  src/tests/containerizer/environment_secret_isolator_tests.cpp cf7b9eb6fd76dbdd3650ea2ad5b9097cf490e948 
  src/tests/containerizer/posix_rlimits_isolator_tests.cpp 0030cd1e1f73422bef806bbc0453134e3d7840d8 
  src/tests/default_executor_tests.cpp 63952d97b76c3e16973705cb0b16140dd381b7ce 
  src/tests/disk_quota_tests.cpp 742b6e1a6340d488f4bae8acbd09a3e575c72ad2 
  src/tests/fault_tolerance_tests.cpp c34850aaa76289d822317f30e5da0e0cb7f115c6 
  src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
  src/tests/master_tests.cpp 4c776012e84c34dda7410841e063faab2a84f2df 
  src/tests/master_validation_tests.cpp f00dd9b6fcb963b995fa238766a531f073205ce9 
  src/tests/oversubscription_tests.cpp 02b10d6689dd6f01510cd2d5db2bb76b4b190eca 
  src/tests/partition_tests.cpp 0597bd2afaa60121245e0d43b81ac223257e377a 
  src/tests/persistent_volume_endpoints_tests.cpp 7a24bf48e9d84bf31ad85397ac3e1b4e566cbc2c 
  src/tests/persistent_volume_tests.cpp 1b35af427a2561f6094560c7bc9387dcb948b781 
  src/tests/reconciliation_tests.cpp 64a1d3da9f03b863551555c4734aef39e835b122 
  src/tests/reservation_endpoints_tests.cpp 5a6e9a7f08a5306542830f359868b2c31f4820c6 
  src/tests/role_tests.cpp fc4c017dc59ab44a0ce0ea46f02eb6e1706ffb72 
  src/tests/scheduler_tests.cpp 4eda96e50a505eb36588bbcf9c3ba76d9ede7839 
  src/tests/slave_authorization_tests.cpp 4c7d37fd14c8f3e7a52d35fb685fb8f05cba1e70 
  src/tests/slave_recovery_tests.cpp 30d8c23de4312cc386354ef6cb44a62055c70f64 
  src/tests/slave_tests.cpp 2ff6daba236972a732618257b25dc3e7fa4dec60 
  src/tests/teardown_tests.cpp 5eada4f4392b7c721f5efbd537b0e817d40c7a27 


Diff: https://reviews.apache.org/r/62213/diff/5/


Testing
-------


Thanks,

Benno Evers


Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62213/#review186868
-----------------------------------------------------------



FAIL: Some Mesos tests failed.

Reviews applied: `['62212', '62213']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose --gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62213

Relevant logs:

- [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62213/logs/mesos-tests-stdout.log):

```
[       OK ] ContentType/SchedulerTest.SchedulerReconnect/0 (270 ms)
[ RUN      ] ContentType/SchedulerTest.SchedulerReconnect/1
[       OK ] ContentType/SchedulerTest.SchedulerReconnect/1 (271 ms)
[----------] 30 tests from ContentType/SchedulerTest (25886 ms total)

[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest
[ RUN      ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0
[       OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/0 (961 ms)
[ RUN      ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1
[       OK ] ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/1 (1048 ms)
[----------] 2 tests from ContentTypeAndSSLConfig/SchedulerSSLTest (2104 ms total)

[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (150 ms)
[ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (149 ms)
[----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (338 ms total)

[----------] Global test environment tear-down
[==========] 634 tests from 67 test cases ran. (333837 ms total)
[  PASSED  ] 632 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.ROOT_ContainerStatusForTask/0, where GetParam() = "mesos"
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() = "mesos"

 2 FAILED TESTS
  YOU HAVE 182 DISABLED TESTS

```

- [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62213/logs/mesos-tests-stderr.log):

```
I1002 18:59:23.112658 39736 master.cpp:8438] Removing framework 39ecafac-8c8f-4d59-974f-ac892e112d1c-0000 (default)
I1002 18:59:23.113657 39736 master.cpp:3317] Deactivating framework 39ecafac-8c8f-4d59-974f-ac892e112d1c-0000 (default)
I1002 18:59:23.117661 39148 hierarchical.cpp:412] Deactivated framework 39ecafac-8c8f-4d59-974f-ac892e112d1c-0000
I1002 18:59:23.117661 37024 slave.cpp:3239] Shutting down framework 39ecafac-8c8f-4d59-974f-ac892e112d1c-0000
I1002 18:59:23.117661 39736 master.cpp:9136] Updating the state of task d0b7c9c4-54f5-45c3-be1c-a3eee8fb1a02 of framework 39ecafac-8c8f-4d59-974f-ac892e112d1c-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED)
I1002 18:59:23.118656 37024 slave.cpp:5746] Shutting down executor 'default' of framework 39ecafac-8c8f-4d59-974f-ac892e112d1c-0000 (via HTTP)
I1002 18:59:23.130655 39736 master.cpp:9230] Removing task d0b7c9c4-54f5-45c3-be1c-a3eee8fb1a02 with resources [{"allocation_info":{"role":"*"},"name":"cpus","scalar":{"value":2.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"mem","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"disk","scalar":{"value":1024.0},"type":"SCALAR"},{"allocation_info":{"role":"*"},"name":"ports","ranges":{"range":[{"begin":31000,"end":32000}]},"type":"RANGES"}] of framework 39ecafac-8c8f-4d59-974f-ac892e112d1c-0000 on agent 39ecafac-8c8f-4d59-974f-ac892e112d1c-S0 at slave(251)@10.3.1.5:59141 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1002 18:59:23.149662 39736 master.cpp:9259] Removing executor 'default' with resources [] of framework 39ecafac-8c8f-4d59-974f-ac892e112d1c-0000 on agent 39ecafac-8c8f-4d59-974f-ac892e112d1c-S0 at slave(251)@10.3.1.5:59141 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1002 18:59:23.153650 39148 hierarchical.cpp:355] Removed framework 39ecafac-8c8f-4d59-974f-ac892e112d1c-0000
E1002 18:59:23.154649 38724 scheduler.cpp:649] End-Of-File received from master. The master closed the event stream
I1002 18:59:23.154649 39148 scheduler.cpp:444] Re-detecting master
I1002 18:59:23.158648 39148 scheduler.cpp:470] New master detected at master@10.3.1.5:59141
I1002 18:59:23.171648 34868 slave.cpp:5411] Executor 'default' of framework 39ecafac-8c8f-4d59-974f-ac892e112d1c-0000 exited with status 0
I1002 18:59:23.172665 34868 slave.cpp:5515] Cleaning up executor 'default' of framework 39ecafac-8c8f-4d59-974f-ac892e112d1c-0000 (via HTTP)
W1002 18:59:23.172665 39736 master.cpp:7089] Ignoring unknown exited executor 'default' of framework 39ecafac-8c8f-4d59-974f-ac892e112d1c-0000 on agent 39ecafac-8c8f-4d59-974f-ac892e112d1c-S0 at slave(251)@10.3.1.5:59141 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1002 18:59:23.176646 37024 gc.cpp:90] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\9YiKpX\slaves\39ecafac-8c8f-4d59-974f-ac892e112d1c-S0\frameworks\39ecafac-8c8f-4d59-974f-ac892e112d1c-0000\executors\default\runs\7e5396c4-657f-4520-a9a6-c625c77dbd31' for gc 6.99998638140148days in the future
I1002 18:59:23.179647 34868 slave.cpp:5622] Cleaning up framework 39ecafac-8c8f-4d59-974f-ac892e112d1c-0000
I1002 18:59:23.185649 39148 status_update_manager.cpp:285] Closing status update streams for framework 39ecafac-8c8f-4d59-974f-ac892e112d1c-0000
I1002 18:59:23.185649 37024 gc.cpp:90] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\9YiKpX\slaves\39ecafac-8c8f-4d59-974f-ac892e112d1c-S0\frameworks\39ecafac-8c8f-4d59-974f-ac892e112d1c-0000\executors\default' for gc 6.99998635825185days in the future
I1002 18:59:23.186645 34868 slave.cpp:869] Agent terminating
I1002 18:59:23.196647 37024 gc.cpp:90] Scheduling 'C:\Users\mesos\AppData\Local\Temp\2\9YiKpX\slaves\39ecafac-8c8f-4d59-974f-ac892e112d1c-S0\frameworks\39ecafac-8c8f-4d59-974f-ac892e112d1c-0000' for gc 6.99998626567111days in the future
I1002 18:59:23.197643 35140 master.cpp:1321] Agent 39ecafac-8c8f-4d59-974f-ac892e112d1c-S0 at slave(251)@10.3.1.5:59141 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I1002 18:59:23.197643 35140 master.cpp:3354] Disconnecting agent 39ecafac-8c8f-4d59-974f-ac892e112d1c-S0 at slave(251)@10.3.1.5:59141 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1002 18:59:23.197643 35140 master.cpp:3373] Deactivating agent 39ecafac-8c8f-4d59-974f-ac892e112d1c-S0 at slave(251)@10.3.1.5:59141 (mesos-bld-s1.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I1002 18:59:23.198644 37024 hierarchical.cpp:690] Agent 39ecafac-8c8f-4d59-974f-ac892e112d1c-S0 deactivated
I1002 18:59:23.223640 36696 master.cpp:1163] Master terminating
I1002 18:59:23.226639 38428 hierarchical.cpp:626] Removed agent 39ecafac-8c8f-4d59-974f-ac892e112d1c-S0
W1002 18:59:23.240877 36696 master.hpp:2882] Failed to close HTTP pipe for 39ecafac-8c8f-4d59-974f-ac892e112d1c-0000 (default)
I1002 18:59:24.165506 39380 process.cpp:1068] Failed to accept socket: future discarded
```

- Mesos Reviewbot Windows


On Sept. 29, 2017, 12:48 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62213/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2017, 12:48 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
>     https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix unit tests that were broken by the additional TASK_STARTING update.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 3d0db3b6c6bfb088a79921c3841ad312dad1ee6a 
>   src/tests/check_tests.cpp fd15a47f1d67ad852d84d83aad54c9fa93c60bbb 
>   src/tests/command_executor_tests.cpp f706f55b5bfab824268498d95d775b216561cd66 
>   src/tests/container_logger_tests.cpp fb8e441bd3842b1840a384a025fa8e9ccbb22cf6 
>   src/tests/containerizer/environment_secret_isolator_tests.cpp cf7b9eb6fd76dbdd3650ea2ad5b9097cf490e948 
>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp 0030cd1e1f73422bef806bbc0453134e3d7840d8 
>   src/tests/default_executor_tests.cpp 63952d97b76c3e16973705cb0b16140dd381b7ce 
>   src/tests/disk_quota_tests.cpp 742b6e1a6340d488f4bae8acbd09a3e575c72ad2 
>   src/tests/fault_tolerance_tests.cpp c34850aaa76289d822317f30e5da0e0cb7f115c6 
>   src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
>   src/tests/master_tests.cpp 4c776012e84c34dda7410841e063faab2a84f2df 
>   src/tests/master_validation_tests.cpp f00dd9b6fcb963b995fa238766a531f073205ce9 
>   src/tests/oversubscription_tests.cpp 02b10d6689dd6f01510cd2d5db2bb76b4b190eca 
>   src/tests/partition_tests.cpp 0597bd2afaa60121245e0d43b81ac223257e377a 
>   src/tests/persistent_volume_endpoints_tests.cpp 7a24bf48e9d84bf31ad85397ac3e1b4e566cbc2c 
>   src/tests/persistent_volume_tests.cpp 1b35af427a2561f6094560c7bc9387dcb948b781 
>   src/tests/reconciliation_tests.cpp 64a1d3da9f03b863551555c4734aef39e835b122 
>   src/tests/reservation_endpoints_tests.cpp 5a6e9a7f08a5306542830f359868b2c31f4820c6 
>   src/tests/role_tests.cpp fc4c017dc59ab44a0ce0ea46f02eb6e1706ffb72 
>   src/tests/scheduler_tests.cpp 4eda96e50a505eb36588bbcf9c3ba76d9ede7839 
>   src/tests/slave_authorization_tests.cpp 4c7d37fd14c8f3e7a52d35fb685fb8f05cba1e70 
>   src/tests/slave_recovery_tests.cpp 30d8c23de4312cc386354ef6cb44a62055c70f64 
>   src/tests/slave_tests.cpp 2ff6daba236972a732618257b25dc3e7fa4dec60 
>   src/tests/teardown_tests.cpp 5eada4f4392b7c721f5efbd537b0e817d40c7a27 
> 
> 
> Diff: https://reviews.apache.org/r/62213/diff/5/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

Posted by Benno Evers <be...@yandex-team.ru>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62213/
-----------------------------------------------------------

(Updated Sept. 29, 2017, 7:48 p.m.)


Review request for mesos, Andrei Budnik and Alexander Rukletsov.


Bugs: MESOS-7941
    https://issues.apache.org/jira/browse/MESOS-7941


Repository: mesos


Description
-------

Fix unit tests that were broken by the additional TASK_STARTING update.


Diffs (updated)
-----

  src/tests/api_tests.cpp d260a1c9560e8ff6b46eea7f2f4ddb11e18653e3 
  src/tests/check_tests.cpp fd15a47f1d67ad852d84d83aad54c9fa93c60bbb 
  src/tests/command_executor_tests.cpp f706f55b5bfab824268498d95d775b216561cd66 
  src/tests/container_logger_tests.cpp fb8e441bd3842b1840a384a025fa8e9ccbb22cf6 
  src/tests/containerizer/environment_secret_isolator_tests.cpp cf7b9eb6fd76dbdd3650ea2ad5b9097cf490e948 
  src/tests/containerizer/posix_rlimits_isolator_tests.cpp 0030cd1e1f73422bef806bbc0453134e3d7840d8 
  src/tests/default_executor_tests.cpp dd1a6ad0d4e2bf74972e15b478652196ee9cd927 
  src/tests/disk_quota_tests.cpp 742b6e1a6340d488f4bae8acbd09a3e575c72ad2 
  src/tests/fault_tolerance_tests.cpp c34850aaa76289d822317f30e5da0e0cb7f115c6 
  src/tests/health_check_tests.cpp f4b50b1cb505084f64bf2dd279d9189ca65c8cdc 
  src/tests/master_tests.cpp 98908c00c2d5bfd08122fd317a2ce95332d9583d 
  src/tests/master_validation_tests.cpp f00dd9b6fcb963b995fa238766a531f073205ce9 
  src/tests/oversubscription_tests.cpp 02b10d6689dd6f01510cd2d5db2bb76b4b190eca 
  src/tests/partition_tests.cpp 0886f4890ac3fec6f38146946892769a99c3e68f 
  src/tests/persistent_volume_endpoints_tests.cpp 7a24bf48e9d84bf31ad85397ac3e1b4e566cbc2c 
  src/tests/persistent_volume_tests.cpp 1b35af427a2561f6094560c7bc9387dcb948b781 
  src/tests/reconciliation_tests.cpp 64a1d3da9f03b863551555c4734aef39e835b122 
  src/tests/reservation_endpoints_tests.cpp 5a6e9a7f08a5306542830f359868b2c31f4820c6 
  src/tests/role_tests.cpp fc4c017dc59ab44a0ce0ea46f02eb6e1706ffb72 
  src/tests/scheduler_tests.cpp 4eda96e50a505eb36588bbcf9c3ba76d9ede7839 
  src/tests/slave_authorization_tests.cpp 4c7d37fd14c8f3e7a52d35fb685fb8f05cba1e70 
  src/tests/slave_recovery_tests.cpp 0cd2b5d37e35ccc2fa2c14db750d1314238bc312 
  src/tests/slave_tests.cpp e9bcfefd52e1e99a7a5877b2e7c30af958ca1723 
  src/tests/teardown_tests.cpp 5eada4f4392b7c721f5efbd537b0e817d40c7a27 


Diff: https://reviews.apache.org/r/62213/diff/4/

Changes: https://reviews.apache.org/r/62213/diff/3-4/


Testing
-------


Thanks,

Benno Evers


Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62213/#review185303
-----------------------------------------------------------



FAIL: Mesos tests failed to build.

Reviews applied: `['62212', '62213']`

Failed command: `cmake.exe --build . --target mesos-tests --config Debug`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62213

Relevant logs:

- [mesos-tests-cmake-build-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62213/logs/mesos-tests-cmake-build-stdout.log):

```


"C:\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"C:\mesos\src\checks\mesos-tcp-connect.vcxproj" (default target) (26) ->
  C:\mesos\mesos\src\checks\tcp_connect.cpp(93): warning C4244: 'initializing': conversion from 'SOCKET' to 'int', possible loss of data [C:\mesos\src\checks\mesos-tcp-connect.vcxproj]


"C:\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"C:\mesos\src\tests\test-helper.vcxproj" (default target) (28) ->
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\mesos\mesos\src\tests\active_user_test_helper.cpp) [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(436): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\mesos\mesos\src\tests\active_user_test_helper.cpp) [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\mesos\mesos\src\tests\http_server_test_helper.cpp) [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(436): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\mesos\mesos\src\tests\http_server_test_helper.cpp) [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\src\tests\resources_utils.cpp(93): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\mesos\mesos\src\tests\flags.cpp) [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(436): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\mesos\mesos\src\tests\flags.cpp) [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(56): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\mesos\mesos\src\tests\utils.cpp) [C:\mesos\src\tests\test-helper.vcxproj]
  C:\mesos\mesos\3rdparty\stout\include\stout/windows/os.hpp(436): warning C4996: 'GetVersionExW': was declared deprecated (compiling source file C:\mesos\mesos\src\tests\utils.cpp) [C:\mesos\src\tests\test-helper.vcxproj]


"C:\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"C:\mesos\src\launcher\mesos-default-executor.vcxproj" (default target) (23) ->
(ClCompile target) -> 
  C:\mesos\mesos\src\launcher\default_executor.cpp(556): error C2039: 'launched': is not a member of 'process::Owned<mesos::internal::DefaultExecutor::Container>' [C:\mesos\src\launcher\mesos-default-executor.vcxproj]

    141 Warning(s)
    1 Error(s)

Time Elapsed 00:38:21.06
```

- Mesos Reviewbot Windows


On Sept. 12, 2017, 9:58 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62213/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2017, 9:58 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
>     https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix unit tests that were broken by the additional TASK_STARTING update.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 0902a66772d178505e83b81878b7878a45c7bb25 
>   src/tests/check_tests.cpp cc7be317030d147c5617e784a50e42b0365b9df6 
>   src/tests/command_executor_tests.cpp f706f55b5bfab824268498d95d775b216561cd66 
>   src/tests/container_logger_tests.cpp 97e79792d3ea8023890ad2a705db47f2aeb419cf 
>   src/tests/containerizer/environment_secret_isolator_tests.cpp 38fef2d5f677f768a0533d1ac085b1197b3b764d 
>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp 0030cd1e1f73422bef806bbc0453134e3d7840d8 
>   src/tests/default_executor_tests.cpp 186b8333c02ba3b9257e19437c6d689761085362 
>   src/tests/disk_quota_tests.cpp 3bf0508238a228d86737d6cc899fa68e2046f2e2 
>   src/tests/fault_tolerance_tests.cpp 5ac38a897fefb6f40d69ca6e27a6f23176e42d36 
>   src/tests/health_check_tests.cpp 2c43241a5cc245a1797ea16c68c94638cec6803d 
>   src/tests/master_tests.cpp 59fbad468ae671a8fd39457632262015989f26c2 
>   src/tests/master_validation_tests.cpp 710b25c1afdff4de7b2eb9b8a38f6856c373fb3c 
>   src/tests/oversubscription_tests.cpp a4c4a6083a2cb55e2d69eba1719555a7a13ee8fb 
>   src/tests/partition_tests.cpp 0886f4890ac3fec6f38146946892769a99c3e68f 
>   src/tests/persistent_volume_endpoints_tests.cpp 7a24bf48e9d84bf31ad85397ac3e1b4e566cbc2c 
>   src/tests/persistent_volume_tests.cpp 3e1d1fe468298186347b07b5882973c5a16231a3 
>   src/tests/reconciliation_tests.cpp 728961874239c7e5ce8accbaeb2a1c86a73a4f0f 
>   src/tests/reservation_endpoints_tests.cpp 3278732cb130c73be0f20c0204eddaee05123ff9 
>   src/tests/role_tests.cpp fc4c017dc59ab44a0ce0ea46f02eb6e1706ffb72 
>   src/tests/scheduler_tests.cpp 21f8825c214bb0c331f66bfb9b12a354d6673a43 
>   src/tests/slave_authorization_tests.cpp 30eceae0920351cffc9c3393c6d08917c4041c1a 
>   src/tests/slave_recovery_tests.cpp 0e46748be266809c413fb10fc447516c51504fce 
>   src/tests/slave_tests.cpp 1bdadce4c50cbff958f2be2a4261e130b414acfd 
>   src/tests/teardown_tests.cpp 8834333bbcdb6a04a95a6ed9632ad4ead0791f76 
> 
> 
> Diff: https://reviews.apache.org/r/62213/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62213/#review185182
-----------------------------------------------------------



FAIL: Mesos failed to build.

Reviews applied: [62212, 62213]

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62213

Relevant logs:

 - mesos-cmake-build.log:

��-- The C compiler identification is MSVC 19.10.25019.0

-- The CXX compiler identification is MSVC 19.10.25019.0

-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe

-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe -- works

-- Detecting C compiler ABI info

-- Detecting C compiler ABI info - done

-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe

-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe -- works

-- Detecting CXX compiler ABI info

-- Detecting CXX compiler ABI info - done

-- Detecting CXX compile features

-- Detecting CXX compile features - done

-- cotire 1.7.10 loaded.

-- ************************************************************

-- ********* Beginning Mesos CMake configuration step *********

-- ************************************************************

-- INSTALLATION PREFIX: C:/Program Files/Mesos

-- MACHINE SPECS:

--     Hostname: 

--     OS:       WINDOWS(10.0.14393)

--     Arch:     AMD64

--     BitMode:  

--     BuildID:  

-- ************************************************************


Full log available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62213/logs/mesos-cmake-build.log

- Mesos Reviewbot Windows


On Sept. 12, 2017, 9:58 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62213/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2017, 9:58 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
>     https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix unit tests that were broken by the additional TASK_STARTING update.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 0902a66772d178505e83b81878b7878a45c7bb25 
>   src/tests/check_tests.cpp cc7be317030d147c5617e784a50e42b0365b9df6 
>   src/tests/command_executor_tests.cpp f706f55b5bfab824268498d95d775b216561cd66 
>   src/tests/container_logger_tests.cpp 97e79792d3ea8023890ad2a705db47f2aeb419cf 
>   src/tests/containerizer/environment_secret_isolator_tests.cpp 38fef2d5f677f768a0533d1ac085b1197b3b764d 
>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp 0030cd1e1f73422bef806bbc0453134e3d7840d8 
>   src/tests/default_executor_tests.cpp 186b8333c02ba3b9257e19437c6d689761085362 
>   src/tests/disk_quota_tests.cpp 3bf0508238a228d86737d6cc899fa68e2046f2e2 
>   src/tests/fault_tolerance_tests.cpp 5ac38a897fefb6f40d69ca6e27a6f23176e42d36 
>   src/tests/health_check_tests.cpp 2c43241a5cc245a1797ea16c68c94638cec6803d 
>   src/tests/master_tests.cpp 59fbad468ae671a8fd39457632262015989f26c2 
>   src/tests/master_validation_tests.cpp 710b25c1afdff4de7b2eb9b8a38f6856c373fb3c 
>   src/tests/oversubscription_tests.cpp a4c4a6083a2cb55e2d69eba1719555a7a13ee8fb 
>   src/tests/partition_tests.cpp 0886f4890ac3fec6f38146946892769a99c3e68f 
>   src/tests/persistent_volume_endpoints_tests.cpp 7a24bf48e9d84bf31ad85397ac3e1b4e566cbc2c 
>   src/tests/persistent_volume_tests.cpp 3e1d1fe468298186347b07b5882973c5a16231a3 
>   src/tests/reconciliation_tests.cpp 728961874239c7e5ce8accbaeb2a1c86a73a4f0f 
>   src/tests/reservation_endpoints_tests.cpp 3278732cb130c73be0f20c0204eddaee05123ff9 
>   src/tests/role_tests.cpp fc4c017dc59ab44a0ce0ea46f02eb6e1706ffb72 
>   src/tests/scheduler_tests.cpp 21f8825c214bb0c331f66bfb9b12a354d6673a43 
>   src/tests/slave_authorization_tests.cpp 30eceae0920351cffc9c3393c6d08917c4041c1a 
>   src/tests/slave_recovery_tests.cpp 0e46748be266809c413fb10fc447516c51504fce 
>   src/tests/slave_tests.cpp 1bdadce4c50cbff958f2be2a4261e130b414acfd 
>   src/tests/teardown_tests.cpp 8834333bbcdb6a04a95a6ed9632ad4ead0791f76 
> 
> 
> Diff: https://reviews.apache.org/r/62213/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Re: Review Request 62213: Fix unit tests that were broken by the additional TASK_STARTING update.

Posted by Benno Evers <be...@yandex-team.ru>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62213/
-----------------------------------------------------------

(Updated Sept. 12, 2017, 9:58 a.m.)


Review request for mesos, Andrei Budnik and Alexander Rukletsov.


Changes
-------

Fix DefaultExecutorTest.ROOT_ContainerStatusForTas


Summary (updated)
-----------------

Fix unit tests that were broken by the additional TASK_STARTING update.


Bugs: MESOS-7941
    https://issues.apache.org/jira/browse/MESOS-7941


Repository: mesos


Description (updated)
-------

Fix unit tests that were broken by the additional TASK_STARTING update.


Diffs (updated)
-----

  src/tests/api_tests.cpp 0902a66772d178505e83b81878b7878a45c7bb25 
  src/tests/check_tests.cpp cc7be317030d147c5617e784a50e42b0365b9df6 
  src/tests/command_executor_tests.cpp f706f55b5bfab824268498d95d775b216561cd66 
  src/tests/container_logger_tests.cpp 97e79792d3ea8023890ad2a705db47f2aeb419cf 
  src/tests/containerizer/environment_secret_isolator_tests.cpp 38fef2d5f677f768a0533d1ac085b1197b3b764d 
  src/tests/containerizer/posix_rlimits_isolator_tests.cpp 0030cd1e1f73422bef806bbc0453134e3d7840d8 
  src/tests/default_executor_tests.cpp 186b8333c02ba3b9257e19437c6d689761085362 
  src/tests/disk_quota_tests.cpp 3bf0508238a228d86737d6cc899fa68e2046f2e2 
  src/tests/fault_tolerance_tests.cpp 5ac38a897fefb6f40d69ca6e27a6f23176e42d36 
  src/tests/health_check_tests.cpp 2c43241a5cc245a1797ea16c68c94638cec6803d 
  src/tests/master_tests.cpp 59fbad468ae671a8fd39457632262015989f26c2 
  src/tests/master_validation_tests.cpp 710b25c1afdff4de7b2eb9b8a38f6856c373fb3c 
  src/tests/oversubscription_tests.cpp a4c4a6083a2cb55e2d69eba1719555a7a13ee8fb 
  src/tests/partition_tests.cpp 0886f4890ac3fec6f38146946892769a99c3e68f 
  src/tests/persistent_volume_endpoints_tests.cpp 7a24bf48e9d84bf31ad85397ac3e1b4e566cbc2c 
  src/tests/persistent_volume_tests.cpp 3e1d1fe468298186347b07b5882973c5a16231a3 
  src/tests/reconciliation_tests.cpp 728961874239c7e5ce8accbaeb2a1c86a73a4f0f 
  src/tests/reservation_endpoints_tests.cpp 3278732cb130c73be0f20c0204eddaee05123ff9 
  src/tests/role_tests.cpp fc4c017dc59ab44a0ce0ea46f02eb6e1706ffb72 
  src/tests/scheduler_tests.cpp 21f8825c214bb0c331f66bfb9b12a354d6673a43 
  src/tests/slave_authorization_tests.cpp 30eceae0920351cffc9c3393c6d08917c4041c1a 
  src/tests/slave_recovery_tests.cpp 0e46748be266809c413fb10fc447516c51504fce 
  src/tests/slave_tests.cpp 1bdadce4c50cbff958f2be2a4261e130b414acfd 
  src/tests/teardown_tests.cpp 8834333bbcdb6a04a95a6ed9632ad4ead0791f76 


Diff: https://reviews.apache.org/r/62213/diff/2/

Changes: https://reviews.apache.org/r/62213/diff/1-2/


Testing
-------


Thanks,

Benno Evers


Re: Review Request 62213: Send TASK_STARTING from the built-in executors. [2/2]

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62213/#review185065
-----------------------------------------------------------



FAIL: Some Mesos tests failed. Please check http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62213/logs/mesos-tests-stdout.log and http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62213/logs/mesos-tests-stderr.log for any relevant errors

Reviews applied: [62212, 62213]

Logs available here: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62213/logs

- Mesos Reviewbot Windows


On Sept. 11, 2017, 9:17 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62213/
> -----------------------------------------------------------
> 
> (Updated Sept. 11, 2017, 9:17 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-7941
>     https://issues.apache.org/jira/browse/MESOS-7941
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Fix unit tests for previous commit.
> 
> 
> Diffs
> -----
> 
>   src/tests/api_tests.cpp 0902a66772d178505e83b81878b7878a45c7bb25 
>   src/tests/check_tests.cpp cc7be317030d147c5617e784a50e42b0365b9df6 
>   src/tests/command_executor_tests.cpp f706f55b5bfab824268498d95d775b216561cd66 
>   src/tests/container_logger_tests.cpp 97e79792d3ea8023890ad2a705db47f2aeb419cf 
>   src/tests/containerizer/environment_secret_isolator_tests.cpp 38fef2d5f677f768a0533d1ac085b1197b3b764d 
>   src/tests/containerizer/posix_rlimits_isolator_tests.cpp 0030cd1e1f73422bef806bbc0453134e3d7840d8 
>   src/tests/default_executor_tests.cpp 186b8333c02ba3b9257e19437c6d689761085362 
>   src/tests/disk_quota_tests.cpp 3bf0508238a228d86737d6cc899fa68e2046f2e2 
>   src/tests/fault_tolerance_tests.cpp 5ac38a897fefb6f40d69ca6e27a6f23176e42d36 
>   src/tests/health_check_tests.cpp 2c43241a5cc245a1797ea16c68c94638cec6803d 
>   src/tests/master_tests.cpp 59fbad468ae671a8fd39457632262015989f26c2 
>   src/tests/master_validation_tests.cpp 710b25c1afdff4de7b2eb9b8a38f6856c373fb3c 
>   src/tests/oversubscription_tests.cpp a4c4a6083a2cb55e2d69eba1719555a7a13ee8fb 
>   src/tests/partition_tests.cpp 0886f4890ac3fec6f38146946892769a99c3e68f 
>   src/tests/persistent_volume_endpoints_tests.cpp 7a24bf48e9d84bf31ad85397ac3e1b4e566cbc2c 
>   src/tests/persistent_volume_tests.cpp 3e1d1fe468298186347b07b5882973c5a16231a3 
>   src/tests/reconciliation_tests.cpp 728961874239c7e5ce8accbaeb2a1c86a73a4f0f 
>   src/tests/reservation_endpoints_tests.cpp 3278732cb130c73be0f20c0204eddaee05123ff9 
>   src/tests/role_tests.cpp fc4c017dc59ab44a0ce0ea46f02eb6e1706ffb72 
>   src/tests/scheduler_tests.cpp 21f8825c214bb0c331f66bfb9b12a354d6673a43 
>   src/tests/slave_authorization_tests.cpp 30eceae0920351cffc9c3393c6d08917c4041c1a 
>   src/tests/slave_recovery_tests.cpp 0e46748be266809c413fb10fc447516c51504fce 
>   src/tests/slave_tests.cpp 1bdadce4c50cbff958f2be2a4261e130b414acfd 
>   src/tests/teardown_tests.cpp 8834333bbcdb6a04a95a6ed9632ad4ead0791f76 
> 
> 
> Diff: https://reviews.apache.org/r/62213/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>