You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by GitBox <gi...@apache.org> on 2020/03/27 13:02:26 UTC
[GitHub] [qpid-proton] d98762625 opened a new pull request #235: [go] Add
ability to set capability on the terminus struct
d98762625 opened a new pull request #235: [go] Add ability to set capability on the terminus struct
URL: https://github.com/apache/qpid-proton/pull/235
We found that we needed to be able to set capabilities on the terminus struct, otherwise we couldn't share queues.
This PR adds a getter and setter for capabilities on the terminus struct.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] [qpid-proton] d98762625 commented on a change in pull request #235:
[go] Add ability to set capability on the terminus struct
Posted by GitBox <gi...@apache.org>.
d98762625 commented on a change in pull request #235: [go] Add ability to set capability on the terminus struct
URL: https://github.com/apache/qpid-proton/pull/235#discussion_r399247806
##########
File path: go/pkg/amqp/url_test.go
##########
@@ -32,13 +32,6 @@ func ExampleParseURL() {
"amqps://host",
"/path",
"",
- ":1234",
Review comment:
Removing this invalid case and the commented out ones, as per the comment on [this PR](https://github.com/apache/qpid-proton/pull/231#discussion_r399227856)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org