You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2019/11/15 15:28:28 UTC
[GitHub] [hadoop] bgaborg commented on a change in pull request #1721: HADOOP-16709. Consider having the ability to turn off TTL in S3Guard …
bgaborg commented on a change in pull request #1721: HADOOP-16709. Consider having the ability to turn off TTL in S3Guard …
URL: https://github.com/apache/hadoop/pull/1721#discussion_r346877206
##########
File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -2669,9 +2671,7 @@ S3AFileStatus innerGetFileStatus(final Path f,
// modification - compare the modTime to check if metadata is up to date
// Skip going to s3 if the file checked is a directory. Because if the
// dest is also a directory, there's no difference.
- // TODO After HADOOP-16085 the modification detection can be done with
Review comment:
If we really do modtime that's bad. That's so bad because we never store the modtime right when a new file is created, so we query it two times! Something to review and work on! (I'm not sure about this, this is just a fyi, should be checked.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org