You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/12/04 23:35:48 UTC

[GitHub] erenavsarogullari opened a new pull request #3126: [Message Routing] Set CustomPartition when messageRouter is set

erenavsarogullari opened a new pull request #3126: [Message Routing] Set CustomPartition when messageRouter is set
URL: https://github.com/apache/pulsar/pull/3126
 
 
   ### Motivation
   This PR proposes some refactoring and fixes on message routing logic.
   
   ### Modifications
   - `getMessageRouter` logic is refactored on`PartitionedProducerImpl`.
   - If `messageRouter` is set through `ProducerBuilderImpl`, `messageRoutingMode` needs to be set as `MessageRoutingMode.CustomPartition` implicitly. Default is `MessageRoutingMode.RoundRobinPartition`
   - Javadoc is fixed
   - Custom Message Router Documentation is fixed
   - UT coverage is added (`ProducerBuilderImplTest` and `PartitionedProducerConsumerTest`)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services