You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@weex.apache.org by GitBox <gi...@apache.org> on 2019/07/05 12:19:14 UTC

[GitHub] [incubator-weex] janpio edited a comment on issue #2656: [iOS] The PR #2394 does not included in latest release version

janpio edited a comment on issue #2656: [iOS] The PR #2394 does not included in latest release version
URL: https://github.com/apache/incubator-weex/issues/2656#issuecomment-508739276
 
 
   ~~That is very strange, as per git blame that line hasn't been changed for 2 years: https://github.com/wqyfavor/incubator-weex/blame/c72dc7fa570d5dcdb2d5f744f096ca12339106f3/ios/sdk/WeexSDK/Sources/Manager/WXSDKManager.m#L50~~
   
   ~~But https://github.com/apache/incubator-weex/commit/6dee825992ab2b8dc043b1bf82205a66adbec485#diff-ed3a1c92b451e932ba0afa5134c5ddd2L50 clearly shows this line getting added to `master` in the merge commit of #2394~~
   
   ~~https://github.com/apache/incubator-weex/commits/master?after=fdec2eeaefa9bfca4e46533049f1507a0b1ab9be+104 (commit history of `master`) clearly shows this commit actually happening on `master` (third commit from the bottom).~~
   
   ~~Something fishy is going on here or I am confused as hell.~~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services