[GitHub] [solr-operator] HoustonPutman commented on a diff in pull request #452: Make new TLSTermination option, with or w/o secret

[GitBox <gi...@apache.org>]

HoustonPutman commented on code in PR #452:
URL: https://github.com/apache/solr-operator/pull/452#discussion_r920289125


##########
api/v1beta1/solrcloud_types.go:
##########
@@ -576,8 +588,21 @@ const (
 )
 
 func (opts *ExternalAddressability) withDefaults(usesTLS bool) (changed bool) {
+	// TODO: Remove in v0.7.0
+	// If the deprecated IngressTLSTerminationSecret exists, use it to default the new location of the value.
+	// If that location already exists, then merely remove the deprecated option.
+	if opts.IngressTLSTerminationSecret != "" {
+		if !opts.HasIngressTLSTermination() {
+			opts.IngressTLSTermination = &SolrIngressTLSTermination{
+				TLSSecret: opts.IngressTLSTerminationSecret,
+			}
+		}

Review Comment:
   That's a good idea.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org