[GitHub] QiuMM commented on a change in pull request #6657: Add TaskCountStatsMonitor to monitor task count stats

[GitBox <gi...@apache.org>]

QiuMM commented on a change in pull request #6657: Add TaskCountStatsMonitor to monitor task count stats
URL: https://github.com/apache/incubator-druid/pull/6657#discussion_r237053156
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskMaster.java
 ##########
 @@ -41,14 +41,16 @@
 import org.apache.druid.java.util.emitter.service.ServiceEmitter;
 import org.apache.druid.server.DruidNode;
 import org.apache.druid.server.coordinator.CoordinatorOverlordServiceConfig;
+import org.apache.druid.server.metrics.TaskCountStatsProvider;
 
+import java.util.Map;
 import java.util.concurrent.atomic.AtomicReference;
 import java.util.concurrent.locks.ReentrantLock;
 
 /**
  * Encapsulates the indexer leadership lifecycle.
  */
-public class TaskMaster
+public class TaskMaster implements TaskCountStatsProvider
 
 Review comment:
   Hmm, `TaskCountStatsProvider` is bind to `TaskMaster`,  there is no need to let `TaskQueue` be `TaskCountStatsProvider`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org