You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Zhou wenjian (JIRA)" <ji...@apache.org> on 2012/08/13 06:14:37 UTC

[jira] [Created] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Zhou wenjian created HBASE-6563:
-----------------------------------

             Summary: s.isMajorCompaction() throws npe will cause current major Compaction checking abort
                 Key: HBASE-6563
                 URL: https://issues.apache.org/jira/browse/HBASE-6563
             Project: HBase
          Issue Type: Bug
          Components: regionserver
            Reporter: Zhou wenjian
             Fix For: 0.94.1


2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
java.lang.NullPointerException
at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Zhou wenjian (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432912#comment-13432912 ] 

Zhou wenjian commented on HBASE-6563:
-------------------------------------

patch for trunk 
                
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>             Fix For: 0.94.1
>
>         Attachments: HBASE-6563-trunk.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432938#comment-13432938 ] 

Hadoop QA commented on HBASE-6563:
----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12540603/HBASE-6563-trunk.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 hadoop2.0.  The patch compiles against the hadoop 2.0 profile.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 5 javac compiler warnings (more than the trunk's current 4 warnings).

    -1 findbugs.  The patch appears to introduce 9 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

     -1 core tests.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.coprocessor.TestClassLoading
                  org.apache.hadoop.hbase.master.TestAssignmentManager

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/2552//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2552//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2552//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2552//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2552//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/2552//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/2552//console

This message is automatically generated.
                
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>             Fix For: 0.94.1
>
>         Attachments: HBASE-6563-trunk.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Zhou wenjian (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493060#comment-13493060 ] 

Zhou wenjian commented on HBASE-6563:
-------------------------------------

[~lhofhansl]
not quite follow you, the npe will be throwed in trunk too, i think.

 private boolean isMajorCompaction(final List<StoreFile> filesToCompact) throws IOException {
    boolean result = false;
    long mcTime = getNextMajorCompactTime();
    if (filesToCompact == null || filesToCompact.isEmpty() || mcTime == 0) {
      return result;
    } long lowTimestamp = getLowestTimestamp(filesToCompact);
    long now = System.currentTimeMillis();
    if (lowTimestamp > 0l && lowTimestamp < (now - mcTime)) {
      // Major compaction time has elapsed.
      if (filesToCompact.size() == 1) {
        // Single file
        StoreFile sf = filesToCompact.get(0);
        long oldest =
            (sf.getReader().timeRangeTracker == null) ?
                Long.MIN_VALUE :
                now - sf.getReader().timeRangeTracker.minimumTimestamp;

if the file to compact is closed after the check, npe will be throwed too, which is  same to 94 and 90.
the  bad side is that current major compaction check for region is interrupted
IMO, need to catch and just Ingore it.
                
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>            Assignee: Zhou wenjian
>         Attachments: HBASE-6563-trunk.patch, HBASE-6563-trunk-v2.patch, HBASE-6563-trunk-v3.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13440299#comment-13440299 ] 

Zhihong Ted Yu commented on HBASE-6563:
---------------------------------------

{code}
+          } catch (Exception e) {
+            // Ignore the npe, see HBASE-6563
{code}
I would expect the exception caught to match comment.
                
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>            Assignee: Zhou wenjian
>             Fix For: 0.94.1
>
>         Attachments: HBASE-6563-trunk.patch, HBASE-6563-trunk-v2.patch, HBASE-6563-trunk-v3.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Zhou wenjian (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhou wenjian reassigned HBASE-6563:
-----------------------------------

    Assignee: Zhou wenjian
    
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>            Assignee: Zhou wenjian
>             Fix For: 0.94.1
>
>         Attachments: HBASE-6563-trunk.patch, HBASE-6563-trunk-v2.patch, HBASE-6563-trunk-v3.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-6563:
---------------------------------

    Fix Version/s:     (was: 0.94.3)
    
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>            Assignee: Zhou wenjian
>         Attachments: HBASE-6563-trunk.patch, HBASE-6563-trunk-v2.patch, HBASE-6563-trunk-v3.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Zhou wenjian (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432955#comment-13432955 ] 

Zhou wenjian commented on HBASE-6563:
-------------------------------------

The failed testcases have nothing to do with the patch


                
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>             Fix For: 0.94.1
>
>         Attachments: HBASE-6563-trunk.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Zhou wenjian (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhou wenjian updated HBASE-6563:
--------------------------------

    Attachment: HBASE-6563-trunk.patch
    
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>             Fix For: 0.94.1
>
>         Attachments: HBASE-6563-trunk.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Zhou wenjian (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13433936#comment-13433936 ] 

Zhou wenjian commented on HBASE-6563:
-------------------------------------

Submitted patch v2 for trunk. Please review and provide your comments/suggestions
                
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>             Fix For: 0.94.1
>
>         Attachments: HBASE-6563-trunk.patch, HBASE-6563-trunk-v2.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Zhihong Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434642#comment-13434642 ] 

Zhihong Ted Yu commented on HBASE-6563:
---------------------------------------

Hadoop QA got aborted:
https://builds.apache.org/job/PreCommit-HBASE-Build/2569/console
                
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>             Fix For: 0.94.1
>
>         Attachments: HBASE-6563-trunk.patch, HBASE-6563-trunk-v2.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Zhou wenjian (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhou wenjian updated HBASE-6563:
--------------------------------

    Attachment: HBASE-6563.patch
    
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>             Fix For: 0.94.1
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-6563:
---------------------------------

    Fix Version/s:     (was: 0.94.1)
                   0.94.3
    
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>            Assignee: Zhou wenjian
>             Fix For: 0.94.3
>
>         Attachments: HBASE-6563-trunk.patch, HBASE-6563-trunk-v2.patch, HBASE-6563-trunk-v3.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Zhou wenjian (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhou wenjian updated HBASE-6563:
--------------------------------

    Attachment: HBASE-6563-trunk-v2.patch
    
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>             Fix For: 0.94.1
>
>         Attachments: HBASE-6563-trunk.patch, HBASE-6563-trunk-v2.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Michael Drzal (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13454875#comment-13454875 ] 

Michael Drzal commented on HBASE-6563:
--------------------------------------

[~zhou wenjian] any response to Ted's comments?
                
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>            Assignee: Zhou wenjian
>             Fix For: 0.94.1
>
>         Attachments: HBASE-6563-trunk.patch, HBASE-6563-trunk-v2.patch, HBASE-6563-trunk-v3.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13484697#comment-13484697 ] 

Lars Hofhansl commented on HBASE-6563:
--------------------------------------

I'm not a fan of catching NPE. They should be addressed by null checks.
Also, I see in Store.isMajorCompaction (in 0.94+) that there already is such a null check.
                
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>            Assignee: Zhou wenjian
>             Fix For: 0.94.3
>
>         Attachments: HBASE-6563-trunk.patch, HBASE-6563-trunk-v2.patch, HBASE-6563-trunk-v3.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Zhou wenjian (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhou wenjian updated HBASE-6563:
--------------------------------

    Status: Patch Available  (was: Open)
    
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>             Fix For: 0.94.1
>
>         Attachments: HBASE-6563-trunk.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Zhou wenjian (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhou wenjian updated HBASE-6563:
--------------------------------

    Attachment:     (was: HBASE-6563.patch)
    
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>             Fix For: 0.94.1
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Zhou wenjian (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhou wenjian updated HBASE-6563:
--------------------------------

    Attachment: HBASE-6563-trunk-v3.patch
    
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>            Assignee: Zhou wenjian
>             Fix For: 0.94.1
>
>         Attachments: HBASE-6563-trunk.patch, HBASE-6563-trunk-v2.patch, HBASE-6563-trunk-v3.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Lars Hofhansl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Lars Hofhansl updated HBASE-6563:
---------------------------------

    Resolution: Not A Problem
        Status: Resolved  (was: Patch Available)

Closing, since this was only 0.94.
                
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>            Assignee: Zhou wenjian
>             Fix For: 0.94.3
>
>         Attachments: HBASE-6563-trunk.patch, HBASE-6563-trunk-v2.patch, HBASE-6563-trunk-v3.patch
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6563) s.isMajorCompaction() throws npe will cause current major Compaction checking abort

Posted by "Zhou wenjian (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13432910#comment-13432910 ] 

Zhou wenjian commented on HBASE-6563:
-------------------------------------

appears in 90, when we do major compaction checking,
the storefile maybe is closed now 
so sf.getReader().timeRangeTracker will throw npe, which will abort current major Compaction

I think trunk will be affected too.
                
> s.isMajorCompaction() throws npe will cause current major Compaction checking abort
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-6563
>                 URL: https://issues.apache.org/jira/browse/HBASE-6563
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: Zhou wenjian
>             Fix For: 0.94.1
>
>
> 2012-05-05 00:49:43,265 ERROR org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker: Caught exception
> java.lang.NullPointerException
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:938)
> at org.apache.hadoop.hbase.regionserver.Store.isMajorCompaction(Store.java:917)
> at org.apache.hadoop.hbase.regionserver.HRegion.isMajorCompaction(HRegion.java:3250)
> at org.apache.hadoop.hbase.regionserver.HRegionServer$MajorCompactionChecker.chore(HRegionServer.java:1222)
> at org.apache.hadoop.hbase.Chore.run(Chore.java:66)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira