You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jeff Coffler <je...@taltos.com> on 2018/02/08 23:09:50 UTC
Re: Review Request 65509: Fixed CURL_ prefix in unit test name to
succeed on Windows.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65509/
-----------------------------------------------------------
(Updated Feb. 8, 2018, 11:09 p.m.)
Review request for mesos, Andrew Schwartzmeyer and John Kordich.
Summary (updated)
-----------------
Fixed CURL_ prefix in unit test name to succeed on Windows.
Bugs: MESOS-6715
https://issues.apache.org/jira/browse/MESOS-6715
Repository: mesos
Description
-------
Since the 'curl.exe' executable is built on part of Windows (it's a
build target), it will always exist for test purposes.
Diffs (updated)
-----
src/tests/environment.cpp 13a4c9514fcd3016fe623c597decd067457e86cd
Diff: https://reviews.apache.org/r/65509/diff/2/
Changes: https://reviews.apache.org/r/65509/diff/1-2/
Testing
-------
Thanks,
Jeff Coffler
Re: Review Request 65509: Fixed CURL_ prefix in unit test name to
succeed on Windows.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65509/#review197133
-----------------------------------------------------------
src/tests/environment.cpp
Line 219 (original), 219-224 (patched)
<https://reviews.apache.org/r/65509/#comment277262>
Fixing in commit: `#ifndef __WINDOWS__` since `__linux__` isn't our only non-Windows platform.
- Andrew Schwartzmeyer
On Feb. 8, 2018, 3:09 p.m., Jeff Coffler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65509/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2018, 3:09 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer and John Kordich.
>
>
> Bugs: MESOS-6715
> https://issues.apache.org/jira/browse/MESOS-6715
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since the 'curl.exe' executable is built on part of Windows (it's a
> build target), it will always exist for test purposes.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp 13a4c9514fcd3016fe623c597decd067457e86cd
>
>
> Diff: https://reviews.apache.org/r/65509/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Jeff Coffler
>
>