You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@storm.apache.org by "Zhengdai Hu (JIRA)" <ji...@apache.org> on 2018/08/09 16:06:00 UTC
[jira] [Updated] (STORM-3187) Nimbus code refactoring and cleanup

     [ https://issues.apache.org/jira/browse/STORM-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zhengdai Hu updated STORM-3187:
-------------------------------
    Description: 
Nimbus.java is bloated with many legacy code that are convoluted and inefficient. It would be nice if we can clean up the code a bit, especially now that we're moving away from Clojure.

Several suggestion are made in STORM-3133, including,

1. Remove logging that is of the same purpose of some metrics: https://github.com/apache/storm/pull/2764#discussion_r203727117

2. Refactor data type of return values/parameters to improve readability: https://github.com/apache/storm/pull/2764#discussion_r208699933
https://github.com/apache/storm/pull/2764#discussion_r208721202
https://github.com/apache/storm/pull/2764#discussion_r208707855

3. Other performance improvement
https://github.com/apache/storm/pull/2764#discussion_r208714561

  was:
Nimbus.java is bloated with many legacy code that are convoluted and inefficient. It would be nice if we can clean up the code a bit, especially now that we're moving away from Clojure.

Several suggestion are made in STORM-3133, including,

1. Remove logging that is of the same purpose of some metrics: https://github.com/apache/storm/pull/2764#discussion_r203727117

2. Refactor data type of return values/parameters to improve readability: https://github.com/apache/storm/pull/2764#discussion_r208699933
https://github.com/apache/storm/pull/2764#discussion_r208721202
https://github.com/apache/storm/pull/2764#discussion-diff-208707855R2230


> Nimbus code refactoring and cleanup
> -----------------------------------
>
>                 Key: STORM-3187
>                 URL: https://issues.apache.org/jira/browse/STORM-3187
>             Project: Apache Storm
>          Issue Type: Improvement
>          Components: storm-server
>    Affects Versions: 2.0.0
>            Reporter: Zhengdai Hu
>            Priority: Major
>
> Nimbus.java is bloated with many legacy code that are convoluted and inefficient. It would be nice if we can clean up the code a bit, especially now that we're moving away from Clojure.
> Several suggestion are made in STORM-3133, including,
> 1. Remove logging that is of the same purpose of some metrics: https://github.com/apache/storm/pull/2764#discussion_r203727117
> 2. Refactor data type of return values/parameters to improve readability: https://github.com/apache/storm/pull/2764#discussion_r208699933
> https://github.com/apache/storm/pull/2764#discussion_r208721202
> https://github.com/apache/storm/pull/2764#discussion_r208707855
> 3. Other performance improvement
> https://github.com/apache/storm/pull/2764#discussion_r208714561



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)