[GitHub] [arrow] yordan-pavlov commented on a change in pull request #7204: ARROW-8831: [Rust] change simd_compare_op in comparison kernel to use bitmask SIMD operation to significantly improve performance

[GitBox <gi...@apache.org>]

yordan-pavlov commented on a change in pull request #7204:
URL: https://github.com/apache/arrow/pull/7204#discussion_r427592201



##########
File path: rust/arrow/src/compute/kernels/comparison.rs
##########
@@ -210,6 +210,10 @@ where
     T: ArrowNumericType,
     F: Fn(T::Simd, T::Simd) -> T::SimdMask,
 {
+    use crate::buffer::MutableBuffer;

Review comment:
       yes, I did try putting the imports at the beginning of the file but this generates warnings when the simd feature is disabled (because these imports are only used for that feature); so I thought that to put the imports inside the function would be the most efficient way around this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org