You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/02 15:43:59 UTC
[GitHub] [incubator-shardingsphere] TaoZhiMLND opened a new pull request
#5052: Fix param check of KeyGeneratorConfiguration
TaoZhiMLND opened a new pull request #5052: Fix param check of KeyGeneratorConfiguration
URL: https://github.com/apache/incubator-shardingsphere/pull/5052
In KeyGeneratorConfigurationYamlSwapper.swap(final YamlKeyGeneratorConfiguration yamlConfiguration), check whether the type of keyGenerateAlgorithm is null.
In sharding.xsd, add use="required" on attribute column of element key-generator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5052: Fix
param check of KeyGeneratorConfiguration
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5052: Fix param check of KeyGeneratorConfiguration
URL: https://github.com/apache/incubator-shardingsphere/pull/5052#issuecomment-607972675
## Pull Request Test Coverage Report for [Build 10805](https://coveralls.io/builds/29802281)
* **2** of **2** **(100.0%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.002%**) to **57.169%**
---
| Totals | [](https://coveralls.io/builds/29802281) |
| :-- | --: |
| Change from base [Build 10803](https://coveralls.io/builds/29795656): | 0.002% |
| Covered Lines: | 11710 |
| Relevant Lines: | 20483 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] cherrylzhao merged pull request #5052:
Fix param check of KeyGeneratorConfiguration
Posted by GitBox <gi...@apache.org>.
cherrylzhao merged pull request #5052: Fix param check of KeyGeneratorConfiguration
URL: https://github.com/apache/incubator-shardingsphere/pull/5052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services