You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Alexander Shraer <sh...@yahoo-inc.com> on 2013/02/05 06:07:30 UTC
Re: Review Request: Dynamic reconfiguration,
see https://issues.apache.org/jira/browse/ZOOKEEPER-107
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6707/
-----------------------------------------------------------
(Updated Feb. 5, 2013, 5:07 a.m.)
Review request for zookeeper.
Changes
-------
Includes Michi's C client tests, fixed backward compatibility issues (backward compatibility will work from 3.4.6 assuming ZOOKEEPER-1633 goes in).
Addressed Flavio's comments.
Description
-------
see https://issues.apache.org/jira/browse/ZOOKEEPER-107
Diffs (updated)
-----
/src/c/include/proto.h 1442472
/src/c/include/zookeeper.h 1442472
/src/c/src/cli.c 1442472
/src/c/src/zookeeper.c 1442472
/src/java/main/org/apache/zookeeper/KeeperException.java 1442472
/src/java/main/org/apache/zookeeper/ZooDefs.java 1442472
/src/java/main/org/apache/zookeeper/ZooKeeper.java 1442472
/src/java/main/org/apache/zookeeper/ZooKeeperMain.java 1442472
/src/java/main/org/apache/zookeeper/common/StringUtils.java 1442472
/src/java/main/org/apache/zookeeper/server/DataTree.java 1442472
/src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 1442472
/src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 1442472
/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java 1442472
/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1442472
/src/java/main/org/apache/zookeeper/server/Request.java 1442472
/src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java 1442472
/src/java/main/org/apache/zookeeper/server/TraceFormatter.java 1442472
/src/java/main/org/apache/zookeeper/server/ZKDatabase.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/Follower.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/Leader.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/Learner.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/Observer.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/QuorumBean.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java 1442472
/src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumVerifier.java 1442472
/src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1442472
/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 1442472
/src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 1442472
/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 1442472
/src/java/test/org/apache/zookeeper/test/NIOConnectionFactoryFdLeakTest.java 1442472
/src/java/test/org/apache/zookeeper/test/QuorumUtil.java 1442472
/src/zookeeper.jute 1442472
Diff: https://reviews.apache.org/r/6707/diff/
Testing
-------
New test files were added: ReconfigTest, ReconfigRecoveryTest and QuorumMajorityTest. Many other tests were modified.
Thanks,
Alexander Shraer
Re: Review Request: Dynamic reconfiguration,
see https://issues.apache.org/jira/browse/ZOOKEEPER-107
Posted by Edward Ribeiro <ed...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6707/#review18298
-----------------------------------------------------------
/src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java
<https://reviews.apache.org/r/6707/#comment38498>
I'd be cool if you remove the white spaces (in red) at this line, as well as, l#46 and l#50
- Edward Ribeiro
On Feb. 6, 2013, 1 a.m., Alexander Shraer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6707/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2013, 1 a.m.)
>
>
> Review request for zookeeper.
>
>
> Description
> -------
>
> see https://issues.apache.org/jira/browse/ZOOKEEPER-107
>
>
> Diffs
> -----
>
> /src/c/include/proto.h 1442038
> /src/c/include/zookeeper.h 1442038
> /src/c/src/cli.c 1442038
> /src/c/src/zookeeper.c 1442038
> /src/c/tests/test-reconfig.py PRE-CREATION
> /src/java/main/org/apache/zookeeper/KeeperException.java 1442038
> /src/java/main/org/apache/zookeeper/ZooDefs.java 1442038
> /src/java/main/org/apache/zookeeper/ZooKeeper.java 1442038
> /src/java/main/org/apache/zookeeper/ZooKeeperMain.java 1442038
> /src/java/main/org/apache/zookeeper/cli/GetConfigCommand.java PRE-CREATION
> /src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java PRE-CREATION
> /src/java/main/org/apache/zookeeper/common/StringUtils.java 1442038
> /src/java/main/org/apache/zookeeper/server/DataTree.java 1442038
> /src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 1442038
> /src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 1442038
> /src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java 1442038
> /src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1442038
> /src/java/main/org/apache/zookeeper/server/Request.java 1442038
> /src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java 1442038
> /src/java/main/org/apache/zookeeper/server/TraceFormatter.java 1442038
> /src/java/main/org/apache/zookeeper/server/ZKDatabase.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/Follower.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/Leader.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/Learner.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/Observer.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumBean.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java 1442038
> /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumVerifier.java 1442038
> /src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java PRE-CREATION
> /src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1442038
> /src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 1442038
> /src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java PRE-CREATION
> /src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 1442038
> /src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 1442038
> /src/java/test/org/apache/zookeeper/test/NIOConnectionFactoryFdLeakTest.java 1442038
> /src/java/test/org/apache/zookeeper/test/QuorumMajorityTest.java PRE-CREATION
> /src/java/test/org/apache/zookeeper/test/QuorumUtil.java 1442038
> /src/java/test/org/apache/zookeeper/test/ReconfigTest.java PRE-CREATION
> /src/zookeeper.jute 1442038
>
> Diff: https://reviews.apache.org/r/6707/diff/
>
>
> Testing
> -------
>
> New test files were added: ReconfigTest, ReconfigRecoveryTest and QuorumMajorityTest. Many other tests were modified.
>
>
> Thanks,
>
> Alexander Shraer
>
>
Re: Review Request: Dynamic reconfiguration,
see https://issues.apache.org/jira/browse/ZOOKEEPER-107
Posted by Alexander Shraer <sh...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6707/
-----------------------------------------------------------
(Updated Feb. 6, 2013, 1 a.m.)
Review request for zookeeper.
Changes
-------
there were some files missing in last patch.
Description
-------
see https://issues.apache.org/jira/browse/ZOOKEEPER-107
Diffs (updated)
-----
/src/c/include/proto.h 1442038
/src/c/include/zookeeper.h 1442038
/src/c/src/cli.c 1442038
/src/c/src/zookeeper.c 1442038
/src/c/tests/test-reconfig.py PRE-CREATION
/src/java/main/org/apache/zookeeper/KeeperException.java 1442038
/src/java/main/org/apache/zookeeper/ZooDefs.java 1442038
/src/java/main/org/apache/zookeeper/ZooKeeper.java 1442038
/src/java/main/org/apache/zookeeper/ZooKeeperMain.java 1442038
/src/java/main/org/apache/zookeeper/cli/GetConfigCommand.java PRE-CREATION
/src/java/main/org/apache/zookeeper/cli/ReconfigCommand.java PRE-CREATION
/src/java/main/org/apache/zookeeper/common/StringUtils.java 1442038
/src/java/main/org/apache/zookeeper/server/DataTree.java 1442038
/src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java 1442038
/src/java/main/org/apache/zookeeper/server/NIOServerCnxnFactory.java 1442038
/src/java/main/org/apache/zookeeper/server/NettyServerCnxnFactory.java 1442038
/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 1442038
/src/java/main/org/apache/zookeeper/server/Request.java 1442038
/src/java/main/org/apache/zookeeper/server/ServerCnxnFactory.java 1442038
/src/java/main/org/apache/zookeeper/server/TraceFormatter.java 1442038
/src/java/main/org/apache/zookeeper/server/ZKDatabase.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/Follower.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/Leader.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/Learner.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/Observer.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/QuorumBean.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java 1442038
/src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumVerifier.java 1442038
/src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java PRE-CREATION
/src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java 1442038
/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java 1442038
/src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java PRE-CREATION
/src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java 1442038
/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java 1442038
/src/java/test/org/apache/zookeeper/test/NIOConnectionFactoryFdLeakTest.java 1442038
/src/java/test/org/apache/zookeeper/test/QuorumMajorityTest.java PRE-CREATION
/src/java/test/org/apache/zookeeper/test/QuorumUtil.java 1442038
/src/java/test/org/apache/zookeeper/test/ReconfigTest.java PRE-CREATION
/src/zookeeper.jute 1442038
Diff: https://reviews.apache.org/r/6707/diff/
Testing
-------
New test files were added: ReconfigTest, ReconfigRecoveryTest and QuorumMajorityTest. Many other tests were modified.
Thanks,
Alexander Shraer