You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by "ehds (via GitHub)" <gi...@apache.org> on 2024/08/09 07:18:21 UTC
[PR] wrap the class name in single quotes (brpc)
ehds opened a new pull request, #2732:
URL: https://github.com/apache/brpc/pull/2732
### What problem does this PR solve?
Issue Number:
https://github.com/apache/brpc/issues/2674
Problem Summary:
gdb_bthread_stack.py 调试时带有 template 的class 需要用单引号包裹，避免出现找不到符号的错误。
### What is changed and the side effects?
Changed:
Side effects:
- Performance effects(性能影响):
- Breaking backward compatibility(向后兼容性):
---
### Check List:
- Please make sure your changes are compilable(请确保你的更改可以通过编译).
- When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
- Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fix gdb_bthread_stack.py not recognize type name (brpc)
Posted by "ehds (via GitHub)" <gi...@apache.org>.
ehds commented on PR #2732:
URL: https://github.com/apache/brpc/pull/2732#issuecomment-2405061584
> > > @ehds 这个PR还有需要修改的地方吗？看标题是WIP
> >
> >
> > 这个 PR 主要解决 #2674 提到的问题，在相同的环境下可以复现，使用现在修改后可以正常使用。但是 [#2674 (comment)](https://github.com/apache/brpc/issues/2674#issuecomment-2295614443) 提出会遇到另外的报错，但在我这边本地无法复现。
>
> #2674 这个我这边复现了，用这个PR也可以解决。
@wwbmmm @yanglimingcn 那这个PR先合入吧，后续有问题再继续优化。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fix gdb_bthread_stack.py not recognize type name (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm merged PR #2732:
URL: https://github.com/apache/brpc/pull/2732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] WIP: fix gdb_bthread_stack.py not recognize type name (brpc)
Posted by "ehds (via GitHub)" <gi...@apache.org>.
ehds commented on PR #2732:
URL: https://github.com/apache/brpc/pull/2732#issuecomment-2378823604
> @ehds 这个PR还有需要修改的地方吗？看标题是WIP
这个 PR 主要解决 https://github.com/apache/brpc/issues/2674 提到的问题，在相同的环境下可以复现，使用现在修改后可以正常使用。但是 https://github.com/apache/brpc/issues/2674#issuecomment-2295614443 提出会遇到另外的报错，本地无法复现。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] WIP: fix gdb_bthread_stack.py not recognize type name (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #2732:
URL: https://github.com/apache/brpc/pull/2732#issuecomment-2375672302
@ehds 这个PR还有需要修改的地方吗？看标题是WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] WIP: fix gdb_bthread_stack.py not recognize type name (brpc)
Posted by "yanglimingcn (via GitHub)" <gi...@apache.org>.
yanglimingcn commented on PR #2732:
URL: https://github.com/apache/brpc/pull/2732#issuecomment-2404440191
> > @ehds 这个PR还有需要修改的地方吗？看标题是WIP
>
> 这个 PR 主要解决 #2674 提到的问题，在相同的环境下可以复现，使用现在修改后可以正常使用。但是 [#2674 (comment)](https://github.com/apache/brpc/issues/2674#issuecomment-2295614443) 提出会遇到另外的报错，但在我这边本地无法复现。
#2674 这个我这边复现了，用这个PR也可以解决。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
Re: [PR] fix gdb_bthread_stack.py not recognize type name (brpc)
Posted by "wwbmmm (via GitHub)" <gi...@apache.org>.
wwbmmm commented on PR #2732:
URL: https://github.com/apache/brpc/pull/2732#issuecomment-2296132464
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org