You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucene.apache.org by "Hoss Man (JIRA)" <ji...@apache.org> on 2013/08/29 02:15:52 UTC

[jira] [Updated] (SOLR-4249) change UniqFieldsUpdateProcessorFactory to subclass FieldValueSubsetUpdateProcessorFactory

     [ https://issues.apache.org/jira/browse/SOLR-4249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-4249:
---------------------------

    Attachment: SOLR-4249.patch

A "phase 1" patch that switches UniqFieldsUpdateProcessorFactory to be a subclass of FieldValueSubsetUpdateProcessorFactory with some custom init logic to deal with the previous "fields" config syntax and log a warning that it is deprecated.  Includes a new test of the FieldMutatingUpdateProcessor selector syntax, but leaves the other existing tests alone to prove that it still works.

plan is to commit & backport this, then commit a trunk only change removing the backcompat support for the hackish syntax and upate the test configs accordingly.
                
> change UniqFieldsUpdateProcessorFactory to subclass FieldValueSubsetUpdateProcessorFactory
> ------------------------------------------------------------------------------------------
>
>                 Key: SOLR-4249
>                 URL: https://issues.apache.org/jira/browse/SOLR-4249
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>            Priority: Minor
>         Attachments: SOLR-4249.patch
>
>
> UniqFieldsUpdateProcessorFactory has been arround for a while, but if we change it to subclass FieldValueSubsetUpdateProcessorFactory, a lot of redundent code could be eliminated from that class, and the factory could be made more configurable by supporting all of the field matching logic in FieldMutatingUpdateProcessorFactory, not just a list of field names.
> (the only new code that would be needed is handling the legacy config case currently supported by UniqFieldsUpdateProcessorFactory)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org