You are viewing a plain text version of this content. The canonical link for it is here.
Posted to batik-commits@xmlgraphics.apache.org by ca...@apache.org on 2007/11/15 00:22:30 UTC

svn commit: r595120 - /xmlgraphics/batik/trunk/sources/org/apache/batik/dom/svg/AbstractSVGAnimatedLength.java

Author: cam
Date: Wed Nov 14 15:22:26 2007
New Revision: 595120

URL: http://svn.apache.org/viewvc?rev=595120&view=rev
Log:
Make bridges throw when required length attributes are missing, like they
used to.

Modified:
    xmlgraphics/batik/trunk/sources/org/apache/batik/dom/svg/AbstractSVGAnimatedLength.java

Modified: xmlgraphics/batik/trunk/sources/org/apache/batik/dom/svg/AbstractSVGAnimatedLength.java
URL: http://svn.apache.org/viewvc/xmlgraphics/batik/trunk/sources/org/apache/batik/dom/svg/AbstractSVGAnimatedLength.java?rev=595120&r1=595119&r2=595120&view=diff
==============================================================================
--- xmlgraphics/batik/trunk/sources/org/apache/batik/dom/svg/AbstractSVGAnimatedLength.java (original)
+++ xmlgraphics/batik/trunk/sources/org/apache/batik/dom/svg/AbstractSVGAnimatedLength.java Wed Nov 14 15:22:26 2007
@@ -148,17 +148,16 @@
                 baseVal = new BaseSVGLength(direction);
             }
             baseVal.revalidate();
-            if (baseVal.unitType == SVGLength.SVG_LENGTHTYPE_UNKNOWN) {
-                if (baseVal.missing) {
-                    throw new LiveAttributeException
-                        (element, localName,
-                         LiveAttributeException.ERR_ATTRIBUTE_MISSING, null);
-                } else {
-                    throw new LiveAttributeException
-                        (element, localName,
-                         LiveAttributeException.ERR_ATTRIBUTE_MALFORMED,
-                         baseVal.getValueAsString());
-                }
+            if (baseVal.missing) {
+                throw new LiveAttributeException
+                    (element, localName,
+                     LiveAttributeException.ERR_ATTRIBUTE_MISSING, null);
+            } else if (baseVal.unitType ==
+                        SVGLength.SVG_LENGTHTYPE_UNKNOWN) {
+                throw new LiveAttributeException
+                    (element, localName,
+                     LiveAttributeException.ERR_ATTRIBUTE_MALFORMED,
+                     baseVal.getValueAsString());
             }
             if (nonNegative && baseVal.value < 0) {
                 throw new LiveAttributeException