You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/08/09 19:36:38 UTC
[GitHub] [maven-jxr] michael-o opened a new pull request, #66: Jxr 173
michael-o opened a new pull request, #66:
URL: https://github.com/apache/maven-jxr/pull/66
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/JXR) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[JXR-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `JXR-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jxr] asfgit merged pull request #66: [JXR-173] Upgrade Maven Reporting API to 3.1.1/Maven Reporting Impl to 3.2.0
Posted by GitBox <gi...@apache.org>.
asfgit merged PR #66:
URL: https://github.com/apache/maven-jxr/pull/66
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jxr] slawekjaranowski commented on a diff in pull request #66: [JXR-173] Upgrade Maven Reporting API to 3.1.1/Maven Reporting Impl to 3.2.0
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #66:
URL: https://github.com/apache/maven-jxr/pull/66#discussion_r945346169
##########
maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java:
##########
@@ -457,21 +414,14 @@ private void copyResources( String dir, String sourceFolder, String... files )
}
@Override
- protected Renderer getSiteRenderer()
+ protected MavenProject getProject()
Review Comment:
The same method in `AbstractMavenReport`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jxr] michael-o commented on a diff in pull request #66: [JXR-173] Upgrade Maven Reporting API to 3.1.1/Maven Reporting Impl to 3.2.0
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #66:
URL: https://github.com/apache/maven-jxr/pull/66#discussion_r945447525
##########
maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java:
##########
@@ -60,31 +57,9 @@
public abstract class AbstractJxrReport
extends AbstractMavenReport
{
- @Parameter( defaultValue = "${project}", readonly = true, required = true )
- private MavenProject project;
- @Component
- private Renderer siteRenderer;
-
- /**
- * Output folder where the main page of the report will be generated. Note that this parameter is only relevant if
- * the goal is run directly from the command line or from the default lifecycle. If the goal is run indirectly as
- * part of a site generation, the output directory configured in the Maven Site Plugin will be used instead.
- */
- @Parameter( defaultValue = "${project.reporting.outputDirectory}", required = true )
- private File outputDirectory;
-
- /**
- * File input encoding.
- */
- @Parameter( property = "encoding", defaultValue = "${project.build.sourceEncoding}" )
- private String inputEncoding;
-
- /**
- * File output encoding.
- */
- @Parameter( property = "outputEncoding", defaultValue = "${project.reporting.outputEncoding}" )
- private String outputEncoding;
+ @Parameter( defaultValue = "${session}", readonly = true, required = true )
+ private MavenSession session;
Review Comment:
Good question. This is used by UTs. Without it no repos can be injected. In next major Onwill pull it up.
##########
maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java:
##########
@@ -60,31 +57,9 @@
public abstract class AbstractJxrReport
extends AbstractMavenReport
{
- @Parameter( defaultValue = "${project}", readonly = true, required = true )
- private MavenProject project;
- @Component
- private Renderer siteRenderer;
-
- /**
- * Output folder where the main page of the report will be generated. Note that this parameter is only relevant if
- * the goal is run directly from the command line or from the default lifecycle. If the goal is run indirectly as
- * part of a site generation, the output directory configured in the Maven Site Plugin will be used instead.
- */
- @Parameter( defaultValue = "${project.reporting.outputDirectory}", required = true )
- private File outputDirectory;
-
- /**
- * File input encoding.
- */
- @Parameter( property = "encoding", defaultValue = "${project.build.sourceEncoding}" )
- private String inputEncoding;
-
- /**
- * File output encoding.
- */
- @Parameter( property = "outputEncoding", defaultValue = "${project.reporting.outputEncoding}" )
- private String outputEncoding;
+ @Parameter( defaultValue = "${session}", readonly = true, required = true )
+ private MavenSession session;
Review Comment:
Good question. This is used by UTs. Without it no repos can be injected. In next major I will pull it up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jxr] slawekjaranowski commented on a diff in pull request #66: [JXR-173] Upgrade Maven Reporting API to 3.1.1/Maven Reporting Impl to 3.2.0
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #66:
URL: https://github.com/apache/maven-jxr/pull/66#discussion_r945346060
##########
maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java:
##########
@@ -60,31 +57,9 @@
public abstract class AbstractJxrReport
extends AbstractMavenReport
{
- @Parameter( defaultValue = "${project}", readonly = true, required = true )
- private MavenProject project;
- @Component
- private Renderer siteRenderer;
-
- /**
- * Output folder where the main page of the report will be generated. Note that this parameter is only relevant if
- * the goal is run directly from the command line or from the default lifecycle. If the goal is run indirectly as
- * part of a site generation, the output directory configured in the Maven Site Plugin will be used instead.
- */
- @Parameter( defaultValue = "${project.reporting.outputDirectory}", required = true )
- private File outputDirectory;
-
- /**
- * File input encoding.
- */
- @Parameter( property = "encoding", defaultValue = "${project.build.sourceEncoding}" )
- private String inputEncoding;
-
- /**
- * File output encoding.
- */
- @Parameter( property = "outputEncoding", defaultValue = "${project.reporting.outputEncoding}" )
- private String outputEncoding;
+ @Parameter( defaultValue = "${session}", readonly = true, required = true )
+ private MavenSession session;
Review Comment:
where is used - field and getter method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jxr] michael-o commented on a diff in pull request #66: [JXR-173] Upgrade Maven Reporting API to 3.1.1/Maven Reporting Impl to 3.2.0
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #66:
URL: https://github.com/apache/maven-jxr/pull/66#discussion_r945447718
##########
maven-jxr-plugin/src/main/java/org/apache/maven/plugin/jxr/AbstractJxrReport.java:
##########
@@ -457,21 +414,14 @@ private void copyResources( String dir, String sourceFolder, String... files )
}
@Override
- protected Renderer getSiteRenderer()
+ protected MavenProject getProject()
Review Comment:
True, but again in UTs the visibility in package is different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org