You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Robin Gögge <r....@outlook.com> on 2018/08/29 10:10:14 UTC
Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/
-----------------------------------------------------------
(Updated Aug. 29, 2018, 10:10 a.m.)
Review request for mesos, Armand Grillet and Kevin Klues.
Summary (updated)
-----------------
Added Python 3.6 and pip to Docker images.
Repository: mesos
Description
-------
Following the update of the CLI to Python 3, we embed Python 3.6
(the minimum required Python version) to the docker images used
during continuous integration.
Diffs (updated)
-----
support/mesos-build/centos-7.dockerfile 068f946f8410772afd9aa45c6f864e475efe84c9
support/mesos-build/ubuntu-16.04-arm.dockerfile 352156fb14d90a4b248bc5d15f1d0127bec00161
support/mesos-build/ubuntu-16.04.dockerfile 503b2e370b9222a0e92b8d5db2b08256df3adef8
Diff: https://reviews.apache.org/r/68538/diff/2/
Changes: https://reviews.apache.org/r/68538/diff/1-2/
Testing (updated)
-------
For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
Thanks,
Robin Gögge
Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208087
-----------------------------------------------------------
PASS: Mesos patch 68538 was successfully built and tested.
Reviews applied: `['68538']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2258/mesos-review-68538
- Mesos Reviewbot Windows
On Aug. 29, 2018, 12:10 p.m., Robin Gögge wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2018, 12:10 p.m.)
>
>
> Review request for mesos, Armand Grillet and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Following the update of the CLI to Python 3, we embed Python 3.6
> (the minimum required Python version) to the docker images used
> during continuous integration.
>
>
> Diffs
> -----
>
> support/mesos-build/centos-7.dockerfile 068f946f8410772afd9aa45c6f864e475efe84c9
> support/mesos-build/ubuntu-16.04-arm.dockerfile 352156fb14d90a4b248bc5d15f1d0127bec00161
> support/mesos-build/ubuntu-16.04.dockerfile 503b2e370b9222a0e92b8d5db2b08256df3adef8
>
>
> Diff: https://reviews.apache.org/r/68538/diff/2/
>
>
> Testing
> -------
>
> For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
>
>
> Thanks,
>
> Robin Gögge
>
>
Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208199
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68538]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 29, 2018, 3:10 a.m., Robin Gögge wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> -----------------------------------------------------------
>
> (Updated Aug. 29, 2018, 3:10 a.m.)
>
>
> Review request for mesos, Armand Grillet and Kevin Klues.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Following the update of the CLI to Python 3, we embed Python 3.6
> (the minimum required Python version) to the docker images used
> during continuous integration.
>
>
> Diffs
> -----
>
> support/mesos-build/centos-7.dockerfile 068f946f8410772afd9aa45c6f864e475efe84c9
> support/mesos-build/ubuntu-16.04-arm.dockerfile 352156fb14d90a4b248bc5d15f1d0127bec00161
> support/mesos-build/ubuntu-16.04.dockerfile 503b2e370b9222a0e92b8d5db2b08256df3adef8
>
>
> Diff: https://reviews.apache.org/r/68538/diff/2/
>
>
> Testing
> -------
>
> For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
>
>
> Thanks,
>
> Robin Gögge
>
>
Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208486
-----------------------------------------------------------
support/mesos-build/centos-7.dockerfile
Lines 63 (patched)
<https://reviews.apache.org/r/68538/#comment292437>
Let's clean after this:
```
yum clean all && \
rm -rf /var/cache/yum
```
support/mesos-build/centos-7.dockerfile
Lines 64 (patched)
<https://reviews.apache.org/r/68538/#comment292438>
Let's cut here.
Also: can we use `update-alternatives` instead?
support/mesos-build/centos-7.dockerfile
Lines 66 (patched)
<https://reviews.apache.org/r/68538/#comment292439>
Let's cut here.
support/mesos-build/ubuntu-16.04-arm.dockerfile
Lines 62 (patched)
<https://reviews.apache.org/r/68538/#comment292444>
Let's clean after this:
```
apt-get clean && \
rm -rf /var/lib/apt/lists
```
support/mesos-build/ubuntu-16.04-arm.dockerfile
Lines 63 (patched)
<https://reviews.apache.org/r/68538/#comment292445>
Let's cut here.
support/mesos-build/ubuntu-16.04-arm.dockerfile
Lines 64 (patched)
<https://reviews.apache.org/r/68538/#comment292447>
Can we use `update-alternatives` instead?
support/mesos-build/ubuntu-16.04-arm.dockerfile
Lines 65 (patched)
<https://reviews.apache.org/r/68538/#comment292446>
Let's cut here.
support/mesos-build/ubuntu-16.04.dockerfile
Lines 59 (patched)
<https://reviews.apache.org/r/68538/#comment292440>
Let's clean after this:
```
apt-get clean && \
rm -rf /var/lib/apt/lists
```
support/mesos-build/ubuntu-16.04.dockerfile
Lines 60 (patched)
<https://reviews.apache.org/r/68538/#comment292441>
Let's cut here.
support/mesos-build/ubuntu-16.04.dockerfile
Lines 61 (patched)
<https://reviews.apache.org/r/68538/#comment292442>
Can we use `update-alternatives` instead?
support/mesos-build/ubuntu-16.04.dockerfile
Lines 62 (patched)
<https://reviews.apache.org/r/68538/#comment292443>
Let's cut here.
- Armand Grillet
On Sept. 7, 2018, 6:55 p.m., Robin Gögge wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2018, 6:55 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, and Kevin Klues.
>
>
> Bugs: MESOS-8957
> https://issues.apache.org/jira/browse/MESOS-8957
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Following the update of the CLI to Python 3, we embed Python 3.6
> (the minimum required Python version) to the docker images used
> during continuous integration.
>
>
> Diffs
> -----
>
> support/mesos-build/centos-7.dockerfile 068f946f8410772afd9aa45c6f864e475efe84c9
> support/mesos-build/ubuntu-16.04-arm.dockerfile 352156fb14d90a4b248bc5d15f1d0127bec00161
> support/mesos-build/ubuntu-16.04.dockerfile 503b2e370b9222a0e92b8d5db2b08256df3adef8
>
>
> Diff: https://reviews.apache.org/r/68538/diff/3/
>
>
> Testing
> -------
>
> For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
>
>
> Thanks,
>
> Robin Gögge
>
>
Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208465
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On sep. 7, 2018, 6:55 après-midi, Robin Gögge wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> -----------------------------------------------------------
>
> (Updated sep. 7, 2018, 6:55 après-midi)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, and Kevin Klues.
>
>
> Bugs: MESOS-8957
> https://issues.apache.org/jira/browse/MESOS-8957
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Following the update of the CLI to Python 3, we embed Python 3.6
> (the minimum required Python version) to the docker images used
> during continuous integration.
>
>
> Diffs
> -----
>
> support/mesos-build/centos-7.dockerfile 068f946f8410772afd9aa45c6f864e475efe84c9
> support/mesos-build/ubuntu-16.04-arm.dockerfile 352156fb14d90a4b248bc5d15f1d0127bec00161
> support/mesos-build/ubuntu-16.04.dockerfile 503b2e370b9222a0e92b8d5db2b08256df3adef8
>
>
> Diff: https://reviews.apache.org/r/68538/diff/3/
>
>
> Testing
> -------
>
> For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
>
>
> Thanks,
>
> Robin Gögge
>
>
Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208488
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On Sept. 10, 2018, 6:36 p.m., Robin Gögge wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2018, 6:36 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, Benjamin Bannier, and Kevin Klues.
>
>
> Bugs: MESOS-8957
> https://issues.apache.org/jira/browse/MESOS-8957
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Following the update of the CLI to Python 3, we embed Python 3.6
> (the minimum required Python version) to the docker images used
> during continuous integration.
>
>
> Diffs
> -----
>
> support/mesos-build/centos-7.dockerfile 068f946f8
> support/mesos-build/ubuntu-16.04-arm.dockerfile 352156fb1
> support/mesos-build/ubuntu-16.04.dockerfile 503b2e370
> support/mesos-tidy/Dockerfile ea28e4099
>
>
> Diff: https://reviews.apache.org/r/68538/diff/4/
>
>
> Testing
> -------
>
> For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
>
>
> Thanks,
>
> Robin Gögge
>
>
Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208492
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68538']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2313/mesos-review-68538
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2313/mesos-review-68538/logs/mesos-tests.log):
```
I0910 17:34:51.998980 5032 exec.cpp:445] Executor asked to shutdown
I0910 17:34:51.999984 14456 executor.cpp:182] Received SHUTDOWN event
I0910 17:34:51.999984 14456 executor.cpp:796] Shutting down
I0910 17:34:51.999984 14456 executor.cpp:909] Sending SIGTERM to process tree at pid 14ated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework d8c35ba1-0b4b-4bc2-b43f-c5d4388ab031-0000 on agent d8c35ba1-0b4b-4bc2-b43f-c5d4388ab031-S0 at slave(462)@192.10.1.5:59777 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
W0910 17:34:51.998980 16644 slave.cpp:3917] Ignoring shutdown framework d8c35ba1-0b4b-4bc2-b43f-c5d4388ab031-0000 because it is terminating
I0910 17:34:52.001989 16848 master.cpp:1251] Agent d8c35ba1-0b4b-4bc2-b43f-c5d4388ab031-S0 at slave(462)@192.10.1.5:59777 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net) disconnected
I0910 17:34:52.001989 16848 master.cpp:3267] Disconnecting agent d8c35ba1-0b4b-4bc2-b43f-c5d4388ab031-S0 at slave(462)@192.10.1.5:59777 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I0910 17:34:52.002990 16848 master.cpp:3286] Deactivating agent d8c35ba1-0b4b-4bc2-b43f-c5d4388ab031-S0 at slave(462)@192.10.1.5:59777 (windows-02.aa0q4n2kgcyefckmv0xukjvy4f.xx.internal.cloudapp.net)
I0910 17:[ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (693 ms)
[----------] 1 test from IsolationFlag/MemoryIsolatorTest (712 ms total)
[----------] Global test environment tear-down
[==========] 1051 tests from 103 test cases ran. (496387 ms total)
[ PASSED ] 1050 tests.
[ FAILED ] 1 test, listed below:
[ FAILED ] DockerFetcherPluginTest.INTERNET_CURL_FetchBlob
1 FAILED TEST
YOU HAVE 229 DISABLED TESTS
34:52.002990 10328 hierarchical.cpp:359] Removed framework d8c35ba1-0b4b-4bc2-b43f-c5d4388ab031-0000
I0910 17:34:52.003999 10328 hierarchical.cpp:795] Agent d8c35ba1-0b4b-4bc2-b43f-c5d4388ab031-S0 deactivated
I0910 17:34:52.003999 14540 containerizer.cpp:2455] Destroying container e06be2c0-7e11-4c22-8a3d-9c362a015bd0 in RUNNING state
I0910 17:34:52.003999 14540 containerizer.cpp:3118] Transitioning the state of container e06be2c0-7e11-4c22-8a3d-9c362a015bd0 from RUNNING to DESTROYING
I0910 17:34:52.005002 14540 launcher.cpp:166] Asked to destroy container e06be2c0-7e11-4c22-8a3d-9c362a015bd0
I0910 17:34:52.094002 16644 containerizer.cpp:2957] Container e06be2c0-7e11-4c22-8a3d-9c362a015bd0 has exited
I0910 17:34:52.127995 13816 master.cpp:1093] Master terminating
I0910 17:34:52.129988 16848 hierarchical.cpp:637] Removed agent d8c35ba1-0b4b-4bc2-b43f-c5d4388ab031-S0
I0910 17:34:52.450001 9692 process.cpp:926] Stopped the socket accept loop
```
- Mesos Reviewbot Windows
On Sept. 10, 2018, 4:36 p.m., Robin Gögge wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2018, 4:36 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, Benjamin Bannier, and Kevin Klues.
>
>
> Bugs: MESOS-8957
> https://issues.apache.org/jira/browse/MESOS-8957
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Following the update of the CLI to Python 3, we embed Python 3.6
> (the minimum required Python version) to the docker images used
> during continuous integration.
>
>
> Diffs
> -----
>
> support/mesos-build/centos-7.dockerfile 068f946f8
> support/mesos-build/ubuntu-16.04-arm.dockerfile 352156fb1
> support/mesos-build/ubuntu-16.04.dockerfile 503b2e370
> support/mesos-tidy/Dockerfile ea28e4099
>
>
> Diff: https://reviews.apache.org/r/68538/diff/4/
>
>
> Testing
> -------
>
> For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
>
>
> Thanks,
>
> Robin Gögge
>
>
Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Posted by Robin Gögge <r....@outlook.com>.
> On Sept. 10, 2018, 9:07 p.m., Benjamin Bannier wrote:
> > support/mesos-build/ubuntu-16.04-arm.dockerfile
> > Lines 42 (patched)
> > <https://reviews.apache.org/r/68538/diff/4/?file=2087575#file2087575line42>
> >
> > Is this still needed if we explicitly pull in python36 below?
This is needed to have the `add-apt-repository` command. This is also why the command is failing for the `support/mesos-tidy/Dockerfile`.
- Robin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208495
-----------------------------------------------------------
On Sept. 10, 2018, 4:36 p.m., Robin Gögge wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2018, 4:36 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, Benjamin Bannier, and Kevin Klues.
>
>
> Bugs: MESOS-8957
> https://issues.apache.org/jira/browse/MESOS-8957
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Following the update of the CLI to Python 3, we embed Python 3.6
> (the minimum required Python version) to the docker images used
> during continuous integration.
>
>
> Diffs
> -----
>
> support/mesos-build/centos-7.dockerfile 068f946f8
> support/mesos-build/ubuntu-16.04-arm.dockerfile 352156fb1
> support/mesos-build/ubuntu-16.04.dockerfile 503b2e370
> support/mesos-tidy/Dockerfile ea28e4099
>
>
> Diff: https://reviews.apache.org/r/68538/diff/4/
>
>
> Testing
> -------
>
> For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
>
>
> Thanks,
>
> Robin Gögge
>
>
Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208495
-----------------------------------------------------------
support/mesos-build/centos-7.dockerfile
Lines 54-64 (patched)
<https://reviews.apache.org/r/68538/#comment292461>
Could we instead use the Fedora epel7 repo?
```
yum install https://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm
yum install python36 python36-devel python36-pip
```
support/mesos-build/centos-7.dockerfile
Lines 70 (patched)
<https://reviews.apache.org/r/68538/#comment292457>
Can we disable pip caching here with `--no-cache-dir`?
support/mesos-build/ubuntu-16.04-arm.dockerfile
Lines 42 (patched)
<https://reviews.apache.org/r/68538/#comment292463>
Is this still needed if we explicitly pull in python36 below?
support/mesos-build/ubuntu-16.04-arm.dockerfile
Lines 57 (patched)
<https://reviews.apache.org/r/68538/#comment292464>
Looking at the details of this ppa it does only seem to provide `arm64`, `armd64`, and `armhf`, but not `armv8` used here. It would be nice to confirm whether this works. I checked this with janisz which should be close to you.
support/mesos-build/ubuntu-16.04-arm.dockerfile
Lines 59-62 (patched)
<https://reviews.apache.org/r/68538/#comment292460>
nit: indent by two more spaces.
support/mesos-build/ubuntu-16.04.dockerfile
Lines 42 (patched)
<https://reviews.apache.org/r/68538/#comment292462>
Is this still needed if we explicitly pull in python36 below?
support/mesos-build/ubuntu-16.04.dockerfile
Lines 57-59 (patched)
<https://reviews.apache.org/r/68538/#comment292454>
nit: indent by two more spaces.
support/mesos-tidy/Dockerfile
Lines 78-94 (patched)
<https://reviews.apache.org/r/68538/#comment292459>
These changes seem not required for this image, let's leave it as is to keep it small.
If you want to keep them, you'd need to fix the following error,
```
Step 10 : RUN add-apt-repository -y ppa:deadsnakes/ppa && apt-get update && apt-get install -qy python3.6 python3.6-dev python3.6-venv && add-apt-repository --remove -y ppa:deadsnakes/ppa && apt-get clean && rm -rf /var/lib/apt/lists
---> Running in 9680ad7925ea
/bin/sh: 1: add-apt-repository: not found
```
This does not look like a transient error.
- Benjamin Bannier
On Sept. 10, 2018, 6:36 p.m., Robin Gögge wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2018, 6:36 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, Benjamin Bannier, and Kevin Klues.
>
>
> Bugs: MESOS-8957
> https://issues.apache.org/jira/browse/MESOS-8957
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Following the update of the CLI to Python 3, we embed Python 3.6
> (the minimum required Python version) to the docker images used
> during continuous integration.
>
>
> Diffs
> -----
>
> support/mesos-build/centos-7.dockerfile 068f946f8
> support/mesos-build/ubuntu-16.04-arm.dockerfile 352156fb1
> support/mesos-build/ubuntu-16.04.dockerfile 503b2e370
> support/mesos-tidy/Dockerfile ea28e4099
>
>
> Diff: https://reviews.apache.org/r/68538/diff/4/
>
>
> Testing
> -------
>
> For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
>
>
> Thanks,
>
> Robin Gögge
>
>
Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208514
-----------------------------------------------------------
Fix it, then Ship it!
LGTM. I'll fix remaining issues before committing.
Let's please make sure to follow up with updating the arm CI. Could you create an issue for that?
support/mesos-build/centos-7.dockerfile
Lines 54 (patched)
<https://reviews.apache.org/r/68538/#comment292501>
No need to `update` here.
- Benjamin Bannier
On Sept. 11, 2018, 12:25 p.m., Robin Gögge wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2018, 12:25 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, Benjamin Bannier, and Kevin Klues.
>
>
> Bugs: MESOS-8957
> https://issues.apache.org/jira/browse/MESOS-8957
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Following the update of the CLI to Python 3, we embed Python 3.6
> (the minimum required Python version) to the docker images used
> during continuous integration.
>
>
> Diffs
> -----
>
> support/mesos-build/centos-7.dockerfile 068f946f8
> support/mesos-build/ubuntu-16.04.dockerfile 503b2e370
>
>
> Diff: https://reviews.apache.org/r/68538/diff/5/
>
>
> Testing
> -------
>
> For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
>
>
> Thanks,
>
> Robin Gögge
>
>
Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208512
-----------------------------------------------------------
PASS: Mesos patch 68538 was successfully built and tested.
Reviews applied: `['68538']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2318/mesos-review-68538
- Mesos Reviewbot Windows
On Sept. 11, 2018, 10:25 a.m., Robin Gögge wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> -----------------------------------------------------------
>
> (Updated Sept. 11, 2018, 10:25 a.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, Benjamin Bannier, and Kevin Klues.
>
>
> Bugs: MESOS-8957
> https://issues.apache.org/jira/browse/MESOS-8957
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Following the update of the CLI to Python 3, we embed Python 3.6
> (the minimum required Python version) to the docker images used
> during continuous integration.
>
>
> Diffs
> -----
>
> support/mesos-build/centos-7.dockerfile 068f946f8
> support/mesos-build/ubuntu-16.04.dockerfile 503b2e370
>
>
> Diff: https://reviews.apache.org/r/68538/diff/5/
>
>
> Testing
> -------
>
> For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
>
>
> Thanks,
>
> Robin Gögge
>
>
Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Posted by Robin Gögge <r....@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/
-----------------------------------------------------------
(Updated Sept. 11, 2018, 10:25 a.m.)
Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, Benjamin Bannier, and Kevin Klues.
Changes
-------
Fixed comments and removed changes from `support/mesos-build/ubuntu-16.04-arm` and `/support/mesos-tidy/Dockerfile`.
Bugs: MESOS-8957
https://issues.apache.org/jira/browse/MESOS-8957
Repository: mesos
Description
-------
Following the update of the CLI to Python 3, we embed Python 3.6
(the minimum required Python version) to the docker images used
during continuous integration.
Diffs (updated)
-----
support/mesos-build/centos-7.dockerfile 068f946f8
support/mesos-build/ubuntu-16.04.dockerfile 503b2e370
Diff: https://reviews.apache.org/r/68538/diff/5/
Changes: https://reviews.apache.org/r/68538/diff/4-5/
Testing
-------
For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
Thanks,
Robin Gögge
Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Posted by Robin Gögge <r....@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/
-----------------------------------------------------------
(Updated Sept. 10, 2018, 4:36 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, Benjamin Bannier, and Kevin Klues.
Changes
-------
Fixed issues.
Bugs: MESOS-8957
https://issues.apache.org/jira/browse/MESOS-8957
Repository: mesos
Description
-------
Following the update of the CLI to Python 3, we embed Python 3.6
(the minimum required Python version) to the docker images used
during continuous integration.
Diffs (updated)
-----
support/mesos-build/centos-7.dockerfile 068f946f8
support/mesos-build/ubuntu-16.04-arm.dockerfile 352156fb1
support/mesos-build/ubuntu-16.04.dockerfile 503b2e370
support/mesos-tidy/Dockerfile ea28e4099
Diff: https://reviews.apache.org/r/68538/diff/4/
Changes: https://reviews.apache.org/r/68538/diff/3-4/
Testing
-------
For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
Thanks,
Robin Gögge
Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208460
-----------------------------------------------------------
PASS: Mesos patch 68538 was successfully built and tested.
Reviews applied: `['68538']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2311/mesos-review-68538
- Mesos Reviewbot Windows
On Sept. 7, 2018, 4:55 p.m., Robin Gögge wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2018, 4:55 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, and Kevin Klues.
>
>
> Bugs: MESOS-8957
> https://issues.apache.org/jira/browse/MESOS-8957
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Following the update of the CLI to Python 3, we embed Python 3.6
> (the minimum required Python version) to the docker images used
> during continuous integration.
>
>
> Diffs
> -----
>
> support/mesos-build/centos-7.dockerfile 068f946f8410772afd9aa45c6f864e475efe84c9
> support/mesos-build/ubuntu-16.04-arm.dockerfile 352156fb14d90a4b248bc5d15f1d0127bec00161
> support/mesos-build/ubuntu-16.04.dockerfile 503b2e370b9222a0e92b8d5db2b08256df3adef8
>
>
> Diff: https://reviews.apache.org/r/68538/diff/3/
>
>
> Testing
> -------
>
> For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
>
>
> Thanks,
>
> Robin Gögge
>
>
Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/#review208487
-----------------------------------------------------------
We also need to updated `support/mesos-tidy/Dockerfile`. I have updated the Dockerfile a little below, add the same Python 3 installation as in the already changed Dockerfile.
```
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
# http://www.apache.org/licenses/LICENSE-2.0
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
FROM ubuntu:16.04
MAINTAINER The Apache Mesos Developers <de...@mesos.apache.org>
WORKDIR /tmp/build
# Build Mesos-flavored `clang-tidy`.
RUN apt-get update && \
apt-get install -qy --no-install-recommends \
build-essential \
ca-certificates \
curl \
git \
python-dev && \
apt-get clean
# Mesos requires at least cmake-3.7.0 on Linux and cmake-3.8.0 on Windows.
#
# TODO(abudnik): Skip this step when a newer version of CMake package is
# available in OS repository.
RUN curl -sSL https://cmake.org/files/v3.8/cmake-3.8.2-Linux-x86_64.sh \
-o /tmp/install-cmake.sh && \
sh /tmp/install-cmake.sh --skip-license --prefix=/usr/local
RUN \
git clone --depth 1 -b release_60 http://llvm.org/git/llvm /tmp/llvm && \
git clone --depth 1 -b mesos_60 http://github.com/mesos/clang.git /tmp/llvm/tools/clang && \
git clone --depth 1 -b mesos_60 http://github.com/mesos/clang-tools-extra.git /tmp/llvm/tools/clang/tools/extra && \
\
cmake /tmp/llvm -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/opt && \
cmake --build tools/clang/lib/Headers --target install -- -j $(nproc) && \
cmake --build tools/clang/tools/extra/clang-tidy --target install -- -j $(nproc) && \
\
cd / && \
rm -rf /tmp/llvm && \
rm -rf /tmp/build
ENV PATH /opt/bin:$PATH
# Install Mesos dependencies
RUN apt-get update && \
apt-get install -qy \
autoconf \
libacl1-dev \
libapr1-dev \
libcurl4-nss-dev \
libsasl2-dev \
libsasl2-modules \
libsvn-dev \
libtool \
zlib1g-dev && \
apt-get clean
# Install `jq` and `parallel` for `clang-tidy` invocation.
RUN apt-get update && \
apt-get install -qy \
jq \
parallel && \
apt-get clean
# Wire up the script which performs the actual work.
WORKDIR /BUILD
ADD ["entrypoint.sh", "entrypoint.sh"]
CMD exec ./entrypoint.sh
```
- Armand Grillet
On Sept. 7, 2018, 6:55 p.m., Robin Gögge wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68538/
> -----------------------------------------------------------
>
> (Updated Sept. 7, 2018, 6:55 p.m.)
>
>
> Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, and Kevin Klues.
>
>
> Bugs: MESOS-8957
> https://issues.apache.org/jira/browse/MESOS-8957
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Following the update of the CLI to Python 3, we embed Python 3.6
> (the minimum required Python version) to the docker images used
> during continuous integration.
>
>
> Diffs
> -----
>
> support/mesos-build/centos-7.dockerfile 068f946f8410772afd9aa45c6f864e475efe84c9
> support/mesos-build/ubuntu-16.04-arm.dockerfile 352156fb14d90a4b248bc5d15f1d0127bec00161
> support/mesos-build/ubuntu-16.04.dockerfile 503b2e370b9222a0e92b8d5db2b08256df3adef8
>
>
> Diff: https://reviews.apache.org/r/68538/diff/3/
>
>
> Testing
> -------
>
> For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
>
>
> Thanks,
>
> Robin Gögge
>
>
Re: Review Request 68538: Added Python 3.6 and pip to Docker images.
Posted by Robin Gögge <r....@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68538/
-----------------------------------------------------------
(Updated Sept. 7, 2018, 4:55 p.m.)
Review request for mesos, Andrew Schwartzmeyer, Armand Grillet, and Kevin Klues.
Changes
-------
Reordered packages.
Bugs: MESOS-8957
https://issues.apache.org/jira/browse/MESOS-8957
Repository: mesos
Description
-------
Following the update of the CLI to Python 3, we embed Python 3.6
(the minimum required Python version) to the docker images used
during continuous integration.
Diffs (updated)
-----
support/mesos-build/centos-7.dockerfile 068f946f8410772afd9aa45c6f864e475efe84c9
support/mesos-build/ubuntu-16.04-arm.dockerfile 352156fb14d90a4b248bc5d15f1d0127bec00161
support/mesos-build/ubuntu-16.04.dockerfile 503b2e370b9222a0e92b8d5db2b08256df3adef8
Diff: https://reviews.apache.org/r/68538/diff/3/
Changes: https://reviews.apache.org/r/68538/diff/2-3/
Testing
-------
For each of the docker files I have built the docker image and ran `PYTHON=python3 src/python/cli_new/bootstrap`.
Thanks,
Robin Gögge