You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/22 12:39:05 UTC
[GitHub] [pulsar] codelipenghui opened a new pull request #6052: [PIP-54] Support acknowledgment at batch index level
codelipenghui opened a new pull request #6052:
URL: https://github.com/apache/pulsar/pull/6052
Master issue: #6253
Fixes #5969
### Motivation
Add support for ack batch message local index. Can be disabled at broker side by set batchIndexAcknowledgeEnable=false at broker.conf
PIP-54 documentation will be created soon.
### Modifications
1. Managed cursor support track and persistent local index of batch message.
2. Client support send batch index ack to broker.
3. The batch messages with index ack information dispatched to the client.
4. Client skip the acked index.
### Verifying this change
New unit tests added
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (no)
- The public API: (no)
- The schema: (no)
- The default values of configurations: (no)
- The wire protocol: (yes)
- The rest endpoints: (no)
- The admin cli options: (no)
- Anything that affects deployment: (no)
### Documentation
- Does this pull request introduce a new feature? (yes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6052: [PIP-54] Support acknowledgment at batch index level
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6052:
URL: https://github.com/apache/pulsar/pull/6052#issuecomment-635059385
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6052: [PIP-54] Support acknowledgment at batch index level
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6052:
URL: https://github.com/apache/pulsar/pull/6052#issuecomment-634037418
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #6052: [PIP-54] Support acknowledgment at batch index level
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #6052:
URL: https://github.com/apache/pulsar/pull/6052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6052: [PIP-54] Support acknowledgment at batch index level
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6052:
URL: https://github.com/apache/pulsar/pull/6052#issuecomment-635711805
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6052: [PIP-54] Support acknowledgment at batch index level
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6052:
URL: https://github.com/apache/pulsar/pull/6052#issuecomment-635845264
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #6052: [PIP-54] Support acknowledgment at batch index level
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #6052:
URL: https://github.com/apache/pulsar/pull/6052#issuecomment-640344766
Doc has been added.
https://github.com/apache/pulsar/pull/7018
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6052: [PIP-54] Support acknowledgment at batch index level
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6052:
URL: https://github.com/apache/pulsar/pull/6052#issuecomment-636029103
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6052: [PIP-54] Support acknowledgment at batch index level
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6052:
URL: https://github.com/apache/pulsar/pull/6052#issuecomment-635421932
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Huanli-Meng commented on pull request #6052: [PIP-54] Support acknowledgment at batch index level
Posted by GitBox <gi...@apache.org>.
Huanli-Meng commented on pull request #6052:
URL: https://github.com/apache/pulsar/pull/6052#issuecomment-626452126
@codelipenghui , for docs may need to be updated for pulsar, i summarize the following part. Please help confirm whether it is OK?
concepts and architecture > architecture > broker
reference > pulsar configuration > broker: add a configure item in the configure file
Cookbooks: add a new doc ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #6052: [PIP-54] Support acknowledgment at batch index level
Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #6052:
URL: https://github.com/apache/pulsar/pull/6052
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6052: [PIP-54] Support acknowledgment at batch index level
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6052:
URL: https://github.com/apache/pulsar/pull/6052#issuecomment-632670193
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6052: [PIP-54] Support acknowledgment at batch index level
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6052:
URL: https://github.com/apache/pulsar/pull/6052#issuecomment-635075286
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6052: [PIP-54] Support acknowledgment at batch index level
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6052:
URL: https://github.com/apache/pulsar/pull/6052#issuecomment-633340804
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6052: [PIP-54] Support acknowledgment at batch index level
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6052:
URL: https://github.com/apache/pulsar/pull/6052#issuecomment-636340899
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #6052: [PIP-54] Support acknowledgment at batch index level
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #6052:
URL: https://github.com/apache/pulsar/pull/6052#issuecomment-635104385
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org