Breaking change in donation vis-a-vis mainline Hg NetBeans

[Lars Bruun-Hansen <lb...@gmail.com>]

I've found a minor "bug" in the donation, documented in NETBEANS-112.
Welcome page is broken and NetBeans attempts to download from aol.com.

The cause has been uncovered: it is due to a DTD file being removed from Hg
(on the donation branch) prior to the actual donation being made. I think I
understand *why* this was done by Oracle: the file isn't theirs to donate.
Still, grrr. I spent 2 hours of digging into this bug and it never occurred
to me that there were breaking changes between donation and mainline Hg
NetBeans. Well, well.

Ok, a broken Welcome page isn't the end of the world. I think the biggest
problem in NETBEANS-112 is that we now have a product which attempts to
contact main page of http://aol.com. This just looks bad. A serious Apache
product shouldn't do that and it might cause
NetBeans to be flagged as malware. Note that this isn't a corner case, it
will happen for every new install of NetBeans until the Welcome page (aka
Startup page) is turned off by the user.

Since I've now spent time digging into it, I might as well figure out a PR
for the specific issue too. For this I need your help, possibly in
particular mentors, as there may be a minor licensing issue to deal with.

For the specific issue, please comment in the Jira ticket. For more general
comments on the changes made to the donation and how we deal with them /
are ware of them, I think this is the appropriate place.

Re: Breaking change in donation vis-a-vis mainline Hg NetBeans

[Sven Reimers <sv...@gmail.com>]

How about diffing the both source trees to find those removed dtd or xsd
files?

Sven

Am 04.11.2017 4:56 nachm. schrieb "Geertjan Wielenga" <
geertjan.wielenga@googlemail.com>:

> On Sat, Nov 4, 2017 at 4:38 PM, Lars Bruun-Hansen <lb...@gmail.com>
> wrote:
>
> > Yeah, well, I guess my point is: these removed files causes subtle errors
> > at runtime, not at build time. Are we just going to discover this as
> people
> > start logging bugs ?
> >
>
>
> Shouldn't be much of this, though, yes, you're right, this is true, it may
> happen here and there.
>
> Gj
>
>
>
> >
> > Anyway, I'll do a PR for this specific one.
> >
> >
> >
> > On Sat, Nov 4, 2017 at 3:55 PM, Geertjan Wielenga <
> > geertjan.wielenga@googlemail.com> wrote:
> >
> > > Indeed, just because Oracle was not able to donate certain files, does
> > not
> > > mean that those files cannot be included by those working on Apache
> > > NetBeans, assuming there's no IP problem with those files from Apache's
> > > perspective.
> > >
> > > Gj
> > >
> > > On Sat, Nov 4, 2017 at 3:53 PM, Matthias Bläsing <
> > > mblaesing@doppel-helix.eu>
> > > wrote:
> > >
> > > > Hey Lars,
> > > >
> > > > Am Samstag, den 04.11.2017, 15:48 +0100 schrieb Lars Bruun-Hansen:
> > > > > The cause has been uncovered: it is due to a DTD file being removed
> > > from
> > > > Hg
> > > > > (on the donation branch) prior to the actual donation being made. I
> > > > think I
> > > > > understand *why* this was done by Oracle: the file isn't theirs to
> > > > donate.
> > > > > Still, grrr. I spent 2 hours of digging into this bug and it never
> > > > occurred
> > > > > to me that there were breaking changes between donation and
> mainline
> > Hg
> > > > > NetBeans. Well, well.
> > > >
> > > > this sounds like a similar problem as:
> > > >
> > > > https://issues.apache.org/jira/browse/NETBEANS-114
> > > >
> > > > The DTDs and Entity definitions were indeed removed and need to be
> > > > readded.
> > > >
> > > > Greetings
> > > >
> > > > Matthias
> > > >
> > >
> >
>

Re: Breaking change in donation vis-a-vis mainline Hg NetBeans

[Geertjan Wielenga <ge...@googlemail.com>]

On Sat, Nov 4, 2017 at 4:38 PM, Lars Bruun-Hansen <lb...@gmail.com>
wrote:

> Yeah, well, I guess my point is: these removed files causes subtle errors
> at runtime, not at build time. Are we just going to discover this as people
> start logging bugs ?
>


Shouldn't be much of this, though, yes, you're right, this is true, it may
happen here and there.

Gj



>
> Anyway, I'll do a PR for this specific one.
>
>
>
> On Sat, Nov 4, 2017 at 3:55 PM, Geertjan Wielenga <
> geertjan.wielenga@googlemail.com> wrote:
>
> > Indeed, just because Oracle was not able to donate certain files, does
> not
> > mean that those files cannot be included by those working on Apache
> > NetBeans, assuming there's no IP problem with those files from Apache's
> > perspective.
> >
> > Gj
> >
> > On Sat, Nov 4, 2017 at 3:53 PM, Matthias Bläsing <
> > mblaesing@doppel-helix.eu>
> > wrote:
> >
> > > Hey Lars,
> > >
> > > Am Samstag, den 04.11.2017, 15:48 +0100 schrieb Lars Bruun-Hansen:
> > > > The cause has been uncovered: it is due to a DTD file being removed
> > from
> > > Hg
> > > > (on the donation branch) prior to the actual donation being made. I
> > > think I
> > > > understand *why* this was done by Oracle: the file isn't theirs to
> > > donate.
> > > > Still, grrr. I spent 2 hours of digging into this bug and it never
> > > occurred
> > > > to me that there were breaking changes between donation and mainline
> Hg
> > > > NetBeans. Well, well.
> > >
> > > this sounds like a similar problem as:
> > >
> > > https://issues.apache.org/jira/browse/NETBEANS-114
> > >
> > > The DTDs and Entity definitions were indeed removed and need to be
> > > readded.
> > >
> > > Greetings
> > >
> > > Matthias
> > >
> >
>

Re: Breaking change in donation vis-a-vis mainline Hg NetBeans

[Lars Bruun-Hansen <lb...@gmail.com>]

Yeah, well, I guess my point is: these removed files causes subtle errors
at runtime, not at build time. Are we just going to discover this as people
start logging bugs ?

Anyway, I'll do a PR for this specific one.



On Sat, Nov 4, 2017 at 3:55 PM, Geertjan Wielenga <
geertjan.wielenga@googlemail.com> wrote:

> Indeed, just because Oracle was not able to donate certain files, does not
> mean that those files cannot be included by those working on Apache
> NetBeans, assuming there's no IP problem with those files from Apache's
> perspective.
>
> Gj
>
> On Sat, Nov 4, 2017 at 3:53 PM, Matthias Bläsing <
> mblaesing@doppel-helix.eu>
> wrote:
>
> > Hey Lars,
> >
> > Am Samstag, den 04.11.2017, 15:48 +0100 schrieb Lars Bruun-Hansen:
> > > The cause has been uncovered: it is due to a DTD file being removed
> from
> > Hg
> > > (on the donation branch) prior to the actual donation being made. I
> > think I
> > > understand *why* this was done by Oracle: the file isn't theirs to
> > donate.
> > > Still, grrr. I spent 2 hours of digging into this bug and it never
> > occurred
> > > to me that there were breaking changes between donation and mainline Hg
> > > NetBeans. Well, well.
> >
> > this sounds like a similar problem as:
> >
> > https://issues.apache.org/jira/browse/NETBEANS-114
> >
> > The DTDs and Entity definitions were indeed removed and need to be
> > readded.
> >
> > Greetings
> >
> > Matthias
> >
>

Re: Breaking change in donation vis-a-vis mainline Hg NetBeans

[Geertjan Wielenga <ge...@googlemail.com>]

Indeed, just because Oracle was not able to donate certain files, does not
mean that those files cannot be included by those working on Apache
NetBeans, assuming there's no IP problem with those files from Apache's
perspective.

Gj

On Sat, Nov 4, 2017 at 3:53 PM, Matthias Bläsing <mb...@doppel-helix.eu>
wrote:

> Hey Lars,
>
> Am Samstag, den 04.11.2017, 15:48 +0100 schrieb Lars Bruun-Hansen:
> > The cause has been uncovered: it is due to a DTD file being removed from
> Hg
> > (on the donation branch) prior to the actual donation being made. I
> think I
> > understand *why* this was done by Oracle: the file isn't theirs to
> donate.
> > Still, grrr. I spent 2 hours of digging into this bug and it never
> occurred
> > to me that there were breaking changes between donation and mainline Hg
> > NetBeans. Well, well.
>
> this sounds like a similar problem as:
>
> https://issues.apache.org/jira/browse/NETBEANS-114
>
> The DTDs and Entity definitions were indeed removed and need to be
> readded.
>
> Greetings
>
> Matthias
>

Re: Breaking change in donation vis-a-vis mainline Hg NetBeans

[Matthias Bläsing <mb...@doppel-helix.eu>]

Hey Lars,

Am Samstag, den 04.11.2017, 15:48 +0100 schrieb Lars Bruun-Hansen:
> The cause has been uncovered: it is due to a DTD file being removed from Hg
> (on the donation branch) prior to the actual donation being made. I think I
> understand *why* this was done by Oracle: the file isn't theirs to donate.
> Still, grrr. I spent 2 hours of digging into this bug and it never occurred
> to me that there were breaking changes between donation and mainline Hg
> NetBeans. Well, well.

this sounds like a similar problem as:

https://issues.apache.org/jira/browse/NETBEANS-114

The DTDs and Entity definitions were indeed removed and need to be
readded.

Greetings

Matthias