You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/04/11 23:23:23 UTC
[GitHub] [pinot] timsants opened a new pull request, #8509: Fix table creation bug for invalid realtime consumer props
timsants opened a new pull request, #8509:
URL: https://github.com/apache/pinot/pull/8509
Instructions:
1. The PR has to be tagged with at least one of the following labels (*):
1. `feature`
2. `bugfix`
3. `performance`
4. `ui`
5. `backward-incompat`
6. `release-notes` (**)
2. Remove these instructions before publishing the PR.
(*) Other labels to consider:
- `testing`
- `dependencies`
- `docker`
- `kubernetes`
- `observability`
- `security`
- `code-style`
- `extension-point`
- `refactor`
- `cleanup`
(**) Use `release-notes` label for scenarios like:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] timsants commented on pull request #8509: Fix table creation bug for invalid realtime consumer props
Posted by GitBox <gi...@apache.org>.
timsants commented on PR #8509:
URL: https://github.com/apache/pinot/pull/8509#issuecomment-1095730780
> I think this behavior is intentional to avoid creating a table on a recently deleted table that doesn't have all entries cleaned up. We remove the table config as the last step when deleting a table, and check the table config existence when adding a table to ensure the states are clean before creating the table. cc @walterddr who added the fix in #8103
If that is the intended behavior, a better exception message could reduce the confusion here. Customers have been thinking the that the table has been already been created but it does not show up in any of the GET table response visible in the API or UI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on pull request #8509: Fix table creation bug for invalid realtime consumer props
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on PR #8509:
URL: https://github.com/apache/pinot/pull/8509#issuecomment-1095725223
I think this behavior is intentional to avoid creating a table on a recently deleted table that doesn't have all entries cleaned up. We remove the table config as the last step when deleting a table, and check the table config existence when adding a table to ensure the states are clean before creating the table.
cc @walterddr who added the fix in #8103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] timsants commented on a diff in pull request #8509: Fix table creation bug for invalid realtime consumer props
Posted by GitBox <gi...@apache.org>.
timsants commented on code in PR #8509:
URL: https://github.com/apache/pinot/pull/8509#discussion_r848989982
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1385,7 +1385,9 @@ public void addTable(TableConfig tableConfig)
throws IOException {
String tableNameWithType = tableConfig.getTableName();
if (getTableConfig(tableNameWithType) != null) {
- throw new TableAlreadyExistsException("Table " + tableNameWithType + " already exists");
+ throw new TableAlreadyExistsException("Table config for " + tableNameWithType
+ + " already exists. If this is unexpected, try deleting the table to remove all metadata associated"
+ + " with it.");
Review Comment:
We don't know the intention of the user for this operation. The user might not know that another table has already been created with this name and we wouldn't want to blindly overwrite an existing table config in that case.
Regarding your questions above:
When the consumer error error happens, the tableConfig is created but it is not easily understood that it stopped after the table config was uploaded to ZK. I don't think this is a UI specific issue. The issue is that the user does not have awareness of what states were persisted until it hit the consumer failure. We should undo any partial operations that occurred during the table creation process because the user has no
From what I see, only some basic validation happens up front before uploading the tableconfig to ZK. I think uploading the table config to ZK up front + checking it, acts as a good operation to prevent race conditions with other table creation/deletion operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a diff in pull request #8509: Fix table creation bug for invalid realtime consumer props
Posted by GitBox <gi...@apache.org>.
walterddr commented on code in PR #8509:
URL: https://github.com/apache/pinot/pull/8509#discussion_r848610947
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1385,7 +1385,9 @@ public void addTable(TableConfig tableConfig)
throws IOException {
String tableNameWithType = tableConfig.getTableName();
if (getTableConfig(tableNameWithType) != null) {
- throw new TableAlreadyExistsException("Table " + tableNameWithType + " already exists");
+ throw new TableAlreadyExistsException("Table config for " + tableNameWithType
+ + " already exists. If this is unexpected, try deleting the table to remove all metadata associated"
+ + " with it.");
Review Comment:
qq: if table config already exist. why can't we use the PUT endpoint to modify the streamConfig so that ingestion error could be fixed?
any reason we had to delete and re-create again? (is it because the table isn't showing up on UI?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] mcvsubbu commented on pull request #8509: Fix table creation bug for invalid realtime consumer props
Posted by GitBox <gi...@apache.org>.
mcvsubbu commented on PR #8509:
URL: https://github.com/apache/pinot/pull/8509#issuecomment-1096951319
We have use cases where tables are created automatically via pipelines, and would like to make sure that this does not break the pipeline. Please give us a couple of days to review this, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] timsants commented on a diff in pull request #8509: Fix table creation bug for invalid realtime consumer props
Posted by GitBox <gi...@apache.org>.
timsants commented on code in PR #8509:
URL: https://github.com/apache/pinot/pull/8509#discussion_r847866608
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1384,7 +1384,7 @@ public List<String> getSchemaNames() {
public void addTable(TableConfig tableConfig)
throws IOException {
String tableNameWithType = tableConfig.getTableName();
- if (getTableConfig(tableNameWithType) != null) {
+ if (hasTable(tableNameWithType)) {
throw new TableAlreadyExistsException("Table " + tableNameWithType + " already exists");
Review Comment:
Added a more detailed message saying that the table config existed and a suggestion to cleanup the table.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8509: Fix table creation bug for invalid realtime consumer props
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on code in PR #8509:
URL: https://github.com/apache/pinot/pull/8509#discussion_r847909780
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1448,7 +1449,14 @@ public void addTable(TableConfig tableConfig)
* We also need to support the case when a high-level consumer already exists for a table and we are adding
* the low-level consumers.
*/
- ensureRealtimeClusterIsSetUp(tableConfig);
+ try {
Review Comment:
Let's have a larger try-catch that covers both offline case and realtime case (having 2 separate try-catch is also fine. Essentially when the table creation didn't finish properly, we should clean up all the records already written to ZK
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1385,7 +1385,8 @@ public void addTable(TableConfig tableConfig)
throws IOException {
String tableNameWithType = tableConfig.getTableName();
if (getTableConfig(tableNameWithType) != null) {
- throw new TableAlreadyExistsException("Table " + tableNameWithType + " already exists");
+ throw new TableAlreadyExistsException("Table config for " + tableNameWithType
+ + " already exists. Try deleting the table to remove all metadata associated with it.");
Review Comment:
```suggestion
+ " already exists. If this is unexpected, try deleting the table to remove all metadata associated with it.");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] timsants commented on a diff in pull request #8509: Fix table creation bug for invalid realtime consumer props
Posted by GitBox <gi...@apache.org>.
timsants commented on code in PR #8509:
URL: https://github.com/apache/pinot/pull/8509#discussion_r847965981
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1448,7 +1449,14 @@ public void addTable(TableConfig tableConfig)
* We also need to support the case when a high-level consumer already exists for a table and we are adding
* the low-level consumers.
*/
- ensureRealtimeClusterIsSetUp(tableConfig);
+ try {
Review Comment:
Increased the try-catch to the offline table creation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] timsants commented on a diff in pull request #8509: Fix table creation bug for invalid realtime consumer props
Posted by GitBox <gi...@apache.org>.
timsants commented on code in PR #8509:
URL: https://github.com/apache/pinot/pull/8509#discussion_r848989982
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1385,7 +1385,9 @@ public void addTable(TableConfig tableConfig)
throws IOException {
String tableNameWithType = tableConfig.getTableName();
if (getTableConfig(tableNameWithType) != null) {
- throw new TableAlreadyExistsException("Table " + tableNameWithType + " already exists");
+ throw new TableAlreadyExistsException("Table config for " + tableNameWithType
+ + " already exists. If this is unexpected, try deleting the table to remove all metadata associated"
+ + " with it.");
Review Comment:
We don't know the intention of the user for this operation. The user might not know that another table has already been created with this name and we wouldn't want to blindly overwrite an existing table config in that case.
Regarding your questions above:
When the consumer error error happens, the tableConfig is created but it is not easily understood that it stopped partially after the table config was uploaded. I don't think this is a UI specific issue. The issue is that the user does not have awareness of what states were persisted until it go to the consumer failure. We should undo any partial operation that occurred during the table creation process because the user has no
From what I see, only some basic validation happens up front before uploading the tableconfig to ZK. I think uploading the table config to ZK up front + checking it, acts as a good operation to prevent race conditions with other table creation/deletion operations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #8509: Fix table creation bug for invalid realtime consumer props
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang merged PR #8509:
URL: https://github.com/apache/pinot/pull/8509
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] navina commented on a diff in pull request #8509: Fix table creation bug for invalid realtime consumer props
Posted by GitBox <gi...@apache.org>.
navina commented on code in PR #8509:
URL: https://github.com/apache/pinot/pull/8509#discussion_r847837277
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -1384,7 +1384,7 @@ public List<String> getSchemaNames() {
public void addTable(TableConfig tableConfig)
throws IOException {
String tableNameWithType = tableConfig.getTableName();
- if (getTableConfig(tableNameWithType) != null) {
+ if (hasTable(tableNameWithType)) {
throw new TableAlreadyExistsException("Table " + tableNameWithType + " already exists");
Review Comment:
nit: I think the error message can be more detailed -
```
Table already exists in helix ??
```
Or maybe add a debug line in there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #8509: Fix table creation bug for invalid realtime consumer props
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #8509:
URL: https://github.com/apache/pinot/pull/8509#issuecomment-1095707470
# [Codecov](https://codecov.io/gh/apache/pinot/pull/8509?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8509](https://codecov.io/gh/apache/pinot/pull/8509?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a186de8) into [master](https://codecov.io/gh/apache/pinot/commit/9314e600808c378663de99a2cdce4d5542ea99df?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9314e60) will **increase** coverage by `37.78%`.
> The diff coverage is `65.54%`.
> :exclamation: Current head a186de8 differs from pull request most recent head 96ef815. Consider uploading reports for the commit 96ef815 to get more accurate results
```diff
@@ Coverage Diff @@
## master #8509 +/- ##
=============================================
+ Coverage 29.25% 67.03% +37.78%
- Complexity 0 4203 +4203
=============================================
Files 1660 1272 -388
Lines 87126 63985 -23141
Branches 13203 10047 -3156
=============================================
+ Hits 25492 42895 +17403
+ Misses 59316 18011 -41305
- Partials 2318 3079 +761
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `67.03% <65.54%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8509?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...pache/pinot/common/config/provider/TableCache.java](https://codecov.io/gh/apache/pinot/pull/8509/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL3Byb3ZpZGVyL1RhYmxlQ2FjaGUuamF2YQ==) | `0.00% <0.00%> (-76.20%)` | :arrow_down: |
| [...inot/common/function/scalar/DateTimeFunctions.java](https://codecov.io/gh/apache/pinot/pull/8509/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vZnVuY3Rpb24vc2NhbGFyL0RhdGVUaW1lRnVuY3Rpb25zLmphdmE=) | `95.23% <ø> (+90.47%)` | :arrow_up: |
| [...inot/core/data/manager/offline/DimensionTable.java](https://codecov.io/gh/apache/pinot/pull/8509/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvb2ZmbGluZS9EaW1lbnNpb25UYWJsZS5qYXZh) | `90.90% <0.00%> (+90.90%)` | :arrow_up: |
| [...ata/manager/offline/DimensionTableDataManager.java](https://codecov.io/gh/apache/pinot/pull/8509/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvb2ZmbGluZS9EaW1lbnNpb25UYWJsZURhdGFNYW5hZ2VyLmphdmE=) | `84.61% <0.00%> (+84.61%)` | :arrow_up: |
| [...he/pinot/segment/local/utils/TableConfigUtils.java](https://codecov.io/gh/apache/pinot/pull/8509/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC91dGlscy9UYWJsZUNvbmZpZ1V0aWxzLmphdmE=) | `65.13% <0.00%> (+65.13%)` | :arrow_up: |
| [...local/segment/index/loader/IndexLoadingConfig.java](https://codecov.io/gh/apache/pinot/pull/8509/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9zZWdtZW50L2luZGV4L2xvYWRlci9JbmRleExvYWRpbmdDb25maWcuamF2YQ==) | `66.00% <12.50%> (+66.00%)` | :arrow_up: |
| [...egment/spi/index/metadata/SegmentMetadataImpl.java](https://codecov.io/gh/apache/pinot/pull/8509/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3NlZ21lbnQvc3BpL2luZGV4L21ldGFkYXRhL1NlZ21lbnRNZXRhZGF0YUltcGwuamF2YQ==) | `73.59% <25.00%> (+73.59%)` | :arrow_up: |
| [...local/recordtransformer/ExpressionTransformer.java](https://codecov.io/gh/apache/pinot/pull/8509/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9yZWNvcmR0cmFuc2Zvcm1lci9FeHByZXNzaW9uVHJhbnNmb3JtZXIuamF2YQ==) | `87.71% <30.00%> (+87.71%)` | :arrow_up: |
| [...ot/spi/config/table/TimestampIndexGranularity.java](https://codecov.io/gh/apache/pinot/pull/8509/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL1RpbWVzdGFtcEluZGV4R3JhbnVsYXJpdHkuamF2YQ==) | `81.25% <81.25%> (ø)` | |
| [...ot/segment/spi/creator/SegmentGeneratorConfig.java](https://codecov.io/gh/apache/pinot/pull/8509/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc2VnbWVudC1zcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3Bpbm90L3NlZ21lbnQvc3BpL2NyZWF0b3IvU2VnbWVudEdlbmVyYXRvckNvbmZpZy5qYXZh) | `82.49% <87.09%> (+82.49%)` | :arrow_up: |
| ... and [1464 more](https://codecov.io/gh/apache/pinot/pull/8509/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8509?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8509?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9314e60...96ef815](https://codecov.io/gh/apache/pinot/pull/8509?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org