[GitHub] [superset] kgabryje commented on a change in pull request #17115: perf(native-filters): Decrease number of unnecessary rerenders in native filters

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #17115:
URL: https://github.com/apache/superset/pull/17115#discussion_r730795403



##########
File path: superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
##########
@@ -274,6 +281,8 @@ const FilterBar: React.FC<FiltersBarProps> = ({
   );
   const isInitialized = useInitialization();
 
+  const tabPaneStyle = useMemo(() => ({ overflow: 'auto', height }), [height]);

Review comment:
       If we didn't `useMemo` here we'd get a different object on each render, meaning the prop through which we pass that object would change and trigger rerender




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org